Bug#530016: [ffmpeg] qtrle 1:1 conversation creates bigger files

Reinhard Tartler siretart at tauware.de
Sat Jun 20 16:30:41 UTC 2009


Resul Cetin <Resul-Cetin at gmx.net> writes:

> On Saturday 20 June 2009 16:46:39 you wrote:
>> Unfortunately I don't know enough about the qtrle encoder to debug/fix
>> this for you.
> It seems to be fixed upstream

Okay, I've looked what change upstream might be related to this, and I
guess that it would be this one:

------------------------------------------------------------------------
r18351 | rbultje | 2009-04-07 17:59:50 +0200 (Di, 07. Apr 2009) | 9 lines

Implement avcodec_decode_video2(), _audio3() and _subtitle2() which takes an
AVPacket argument rather than a const uint8_t *buf + int buf_size. This allows
passing of packet-specific flags from demuxer to decoder, such as the keyframe
flag, which appears necessary to playback corePNG P-frames.

Patch by Thilo Borgmann thilo.borgmann googlemail com, see also the thread
"Google Summer of Code participation" on the mailinglist.


The problem with that patch is that it is rather invasive:

>> svn diff -cr18351 P diffstat
 4xm.c                |    4 +-
 8bps.c               |    4 +-
 8svx.c               |    4 +-
 aac.c                |    4 +-
 aasc.c               |    4 +-
 ac3dec.c             |    4 +-
 adpcm.c              |    4 +-
 adxdec.c             |    4 +-
 alac.c               |    4 +-
 apedec.c             |    4 +-
 asv1.c               |    4 +-
 atrac3.c             |    4 +-
 avcodec.h            |   92 +++++++++++++++++++++++++++++++++++++++------------
 avs.c                |    4 +-
 bethsoftvideo.c      |    4 +-
 bfi.c                |    5 +-
 bmp.c                |    4 +-
 c93.c                |    4 +-
 cavsdec.c            |    4 +-
 cinepak.c            |    4 +-
 cljr.c               |    4 +-
 cook.c               |    4 +-
 cscd.c               |    4 +-
 cyuv.c               |    4 +-
 dca.c                |    4 +-
 dnxhddec.c           |    4 +-
 dpcm.c               |    4 +-
 dsicinav.c           |    8 +++-
 dv.c                 |    4 +-
 dvbsubdec.c          |    4 +-
 dvdsubdec.c          |    4 +-
 dxa.c                |    4 +-
 eacmv.c              |    4 +-
 eatgq.c              |    4 +-
 eatgv.c              |    4 +-
 eatqi.c              |    4 +-
 escape124.c          |    4 +-
 ffv1.c               |    4 +-
 flacdec.c            |    4 +-
 flashsv.c            |    4 +-
 flicvideo.c          |    4 +-
 fraps.c              |    4 +-
 g726.c               |    4 +-
 gifdec.c             |    4 +-
 h261dec.c            |    4 +-
 h263dec.c            |    4 +-
 h264.c               |    4 +-
 huffyuv.c            |    4 +-
 idcinvideo.c         |    4 +-
 imc.c                |    4 +-
 indeo2.c             |    4 +-
 indeo3.c             |    4 +-
 interplayvideo.c     |    4 +-
 kmvc.c               |    5 +-
 lcldec.c             |    4 +-
 libamr.c             |    8 +++-
 libdiracdec.c        |    4 +-
 libfaad.c            |    4 +-
 libgsm.c             |    4 +-
 libopenjpeg.c        |    4 +-
 libschroedingerdec.c |    4 +-
 libspeexdec.c        |    4 +-
 loco.c               |    4 +-
 mace.c               |    4 +-
 mdec.c               |    4 +-
 mimic.c              |    4 +-
 mjpegbdec.c          |    4 +-
 mjpegdec.c           |    4 +-
 mjpegdec.h           |    2 -
 mlpdec.c             |    4 +-
 mmvideo.c            |    4 +-
 motionpixels.c       |    4 +-
 mpc7.c               |    4 +-
 mpc8.c               |    4 +-
 mpeg12.c             |    4 +-
 mpegaudiodec.c       |   12 ++++--
 mpegvideo.h          |    2 -
 msrle.c              |    4 +-
 msvideo1.c           |    4 +-
 nellymoserdec.c      |    4 +-
 nuv.c                |    4 +-
 pcm.c                |    4 +-
 pcx.c                |    4 +-
 pngdec.c             |    4 +-
 pnmenc.c             |    4 +-
 ptx.c                |    4 +-
 qcelpdec.c           |    4 +-
 qdm2.c               |    4 +-
 qdrw.c               |    4 +-
 qpeg.c               |    4 +-
 qtrle.c              |    4 +-
 ra144.c              |    4 +-
 ra288.c              |    5 +-
 rawdec.c             |    4 +-
 rl2.c                |    4 +-
 roqvideodec.c        |    4 +-
 rpza.c               |    4 +-
 rv10.c               |    4 +-
 rv34.c               |    4 +-
 rv34.h               |    2 -
 sgidec.c             |    4 +-
 shorten.c            |    4 +-
 smacker.c            |    8 +++-
 smc.c                |    4 +-
 snow.c               |    4 +-
 sonic.c              |    4 +-
 sp5xdec.c            |   10 ++++-
 sunrast.c            |    4 +-
 svq1dec.c            |    4 +-
 svq3.c               |    4 +-
 targa.c              |    4 +-
 tiertexseqv.c        |    4 +-
 tiff.c               |    4 +-
 truemotion1.c        |    4 +-
 truemotion2.c        |    4 +-
 truespeech.c         |    4 +-
 tscc.c               |    4 +-
 tta.c                |    4 +-
 txd.c                |    4 +-
 ulti.c               |    4 +-
 utils.c              |   54 ++++++++++++++++++++++++++---
 vb.c                 |    4 +-
 vc1.c                |    4 +-
 vcr1.c               |    4 +-
 vmdav.c              |    8 +++-
 vmnc.c               |    4 +-
 vorbis_dec.c         |    4 +-
 vp3.c                |    4 +-
 vqavideo.c           |    4 +-
 wavpack.c            |    4 +-
 wmadec.c             |    4 +-
 wnv1.c               |    4 +-
 ws-snd1.c            |    4 +-
 xan.c                |    4 +-
 xl.c                 |    4 +-
 xsubdec.c            |    4 +-
 zmbv.c               |    4 +-
 137 files changed, 541 insertions(+), 172 deletions(-)


Since it also touches publicly exported header files, I'm don't think we
can easily backport that into the debian package.

Sorry :(

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4





More information about the pkg-multimedia-maintainers mailing list