ugly patches, Re: Bug#520113: [SCM] mplayer packaging branch, master, updated. debian/1.0.rc2+svn20090303-2-5-g0640320

[A Mennucc]

On Sat, Mar 21, 2009 at 04:27:35PM +0100, Diego Biurrun wrote:
> What an exceptionally ugly patch.  My eyes are bleeding.

hi Diego,

around that line there are 2 such snippets, that
alter config.mak after it was created;
(it was "4 snippets" but I just deleted two)

I do not like those snippets too

I added them to satisfy some Debian recommended practices

a better way would be to have specific ./configure switches;

those are the issues:

1)  when DEB_BUILD_OPTIONS contains 'noopt'
  then all optimization should be disabled.
 (I did not test it in long time, it may be unworking now)

 note that currently in Debian MPlayer is already compiled with
 ./configure --enable-debug
 so that symbols are generated and shipped in mplayer-dbg...deb

2) and of course the linking problem in MIPS we are discussing

then there is another issue

-) when DEB_BUILD_OPTIONS contains 'nostrip'
 the resulting binaries should not be stripped.
This is currently not implemented

a.