distclean, Re: proper way to link mplayer to shared ffmpeg , was Re: Bug#520113

[Reinhard Tartler]

Diego Biurrun <diego at biurrun.de> writes:

>> On Fri, Mar 27, 2009 at 11:15:32AM +0100, Diego Biurrun wrote:
>> > [...]
>> > 
>> > And while we're at it, why do you run distclean before configure?  It is
>> > completely pointless and fails of course because config.mak was not yet
>> > created by configure...
>> 
>> this is standard in Debian; 
>> 1) distclean tree 
>> 2) create the diff.gz .dsc 
>> 3) build the package
>> 4) pack into .deb
>> 
>> note that the above is idempotent: this AFAICR
>> is required by the policy
>
> Maybe I'm missing something totally obvious about your packaging, but if
> you take a fresh tarball, the distclean is totally pointless...

indeed.

but AFAIUI the buildds call the clean target always before the build, so
it is a very good idea to make the rule idempotent.

The current version of the clean rule does not fail if config.mak
doesn't exist:

clean-real:
	dh_testdir
	dh_testroot
	test -r config.mak && $(MAKE) -C DOCS/xml distclean || true
	$(MAKE) distclean
	dh_clean config.h config.mak configure.log
	dh_clean build-arch-stamp build-indep-stamp configure-arch-stamp snapshot_version
	find -name '*.o' -or -name '*.a' -or -name '*~' \
		-or -name semantic.cache -print0 |\
		xargs -r0 rm -v

I believe the last find is unnecessary, but should be harmless.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4