JACK and unclean upstream tarballs

[Felipe Sateler]

El domingo 10 de mayo, Adrian Knoth escribió:
> On Sat, May 09, 2009 at 07:20:04PM +1000, Felipe Sateler wrote:
>
> Hi!
>
> > Upstream apparently doesn't run make distclean on their tarballs. Running
> > debian/rules clean leaves a dirty git repo, which makes it annoying for
> > testing stuff.
> >
> > How do you propose to handle this?
>
> Here is what upstream says (so far):
>
> 23:22 < torbenh3> adi: hmmm... at least there is no reason to do that. i
> dont know what happened there. but we need to ask paul. he generates the
> tarballs.
> 23:24 < torbenh3> adi: imo a tarball needs to be generated by make dist ...
> and its not necessary to run ditstclean on them. but maybe the Makefiles
> are a bit broken.
> 23:26 < torbenh3> adi: i dont want to look at this right now. maybe you
> guys can look into the problem and fix the Makefiles ? i will happyly apply
> a fix for this. gonna look into this, when i am able to compile jack2 under
> windows :D
>
>
> Sounds good to me. Can we come up with a patch? Which files are
> affected?

They explicitly distribute the generated documentation: 

in doc/Makefile.am:

dist-hook: dist-hook-local
        mkdir $(distdir)/reference
        mkdir $(distdir)/reference/html
        -cp reference/html/*.html reference/html/*.css \
            reference/html/*.png  $(distdir)/reference/html

in ./Makefile.am:

if HAVE_DOXYGEN
DOC_DIR = doc
dist-check-doxygen:
else
DOC_DIR =
dist-check-doxygen:
        @echo
        @echo ' ******' You need doxygen installed to make dist.' ******'
        @echo
        @false
endif
<snip>
EXTRA_DIST = COPYING COPYING.GPL COPYING.LGPL libjack/simd.c jack.spec

in jackd/Makefile.am:

man_MANS = jackd.1 jackstart.1
EXTRA_DIST = $(man_MANS)


I assume this is to prevent people from needing to build the documentation... 

Saludos,
Felipe Sateler