Bug#370599: ffmpeg-debian: please add dlopen patch for amr libraries

[Andres Mejia]

On Tuesday 12 May 2009 02:31:47 Reinhard Tartler wrote:
> severity 370599 wishlist
> tag 370599 help
> stop
>
> forwarding to the debian bts
>
> > Le 10/05/2009 21:26, Reinhard Tartler a écrit :
> >> Mantas Kriaučiūnas <mantas at akl.lt> writes:
> >>> Hi Reinhard,
> >>>
> >>> On Sun, May 10, 2009 at 07:00:43AM -0000, Reinhard Tartler wrote:
> >>>> Mantas Kriaučiūnas <mantas at akl.lt> writes:
> >>>>> Lionel Le Folgoc <mrpouit at ubuntu.com> already created ffmpeg deb
> >>>>> packages with AMRNB and AMRWB format support, I found packages for
> >>>>> Ubuntu 8.10 (Intrepid) at Medibuntu-maintainers package archive
> >>>>
> >>>> the problem with that approach is that it creates a hard dependency on
> >>>> the libamr packages, which are totally unredistributable and cannot
> >>>> possibly included into ubuntu proper.
> >>>
> >>> Are you soru, that ffmpeg packages created by mrpouit at ubuntu.com
> >>> creates hard dependancy? According to the changelog, these ffmpeg
> >>> packages adds libamr support via dlopen(), this is runtime libamr
> >>> detection, so, no hard dependancies on the libamr packages. I can paste
> >>> changelog from patched ffmpeg packages for Ubuntu 8.10 again:
> >>>
> >>> ffmpeg (3:0.svn20080206-12ubuntu3+unstripped5+amr1) intrepid;
> >>> urgency=low * debian/patches/60_dlopen_libamr.diff: add libamr support
> >>> via dlopen(). (LP: #93849)
> >>>   * debian/patches/series: add the above patch.
> >>>   * debian/confflags: pass --enable-libamrnbbin and
> >>> --enable-libamrwbbin. -- Lionel Le Folgoc < mrpouit at ubuntu.com>   Mon,
> >>> 27 Oct 2008 17:54:09
> >>
> >> that is news to me. we could probably integrate this in the
> >> ffmpeg-debian package.
> >>
> >> could you (or Lionel) please extract that patch and file it against the
> >> ffmpeg-debian package in debian? I'll review it and see if we can
> >> integrate it.
> >
> > Hi Reinhard,
> >
> > This patch was taken from the altlinux package (I probably slightly
> > changed it to apply cleanly). You wrote about it in a previous comment
> > (<https://bugs.launchpad.net/ubuntu/+source/ffmpeg-debian/+bug/93849/comm
> >ents/18> I think), that it needs more work, and indeed, it seems it was
> > rejected upstream when it was submitted (thread available at
> > <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-April/027866.html>
> >).
> >
> > I don't have the time to further work on this currently unfortunately
> > (not even to update it for jaunty in the PPA). There is probably an
> > up-to-date version on
> > <http://sisyphus.ru/srpm/Sisyphus/ffmpeg/patches/0> though.
>
> Okay, thanks for the status update.
>
> This report should now have enough pointers so that someone could
> integrate and test it in the debian package.
>
> short summary: the patch dlopen() the amr libraries at runtime. this way
> we don't need to link it against the libraries but can just use them if
> they are around. This patch now needs cleaning up and testing. Michael
> (ffmpeg project leader) seems interested in having this integrated, so
> it would need someone to pick up his latest review and finish the
> cleanup.
>
> FWIW, I personally don't have any sound material that would require
> these libs so that I cannot test it myself. Help welcome.
>
>
> --
> Gruesse/greetings,
> Reinhard Tartler, KeyID 945348A4

I'll look at this.

-- 
Regards,
Andres
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20090512/be2ee2fe/attachment.pgp>