[SCM] FFmpeg packaging branch, master, updated. debian/0.5+svn20090420-2-17-gc8d8dad

[Reinhard Tartler]

Andres Mejia <mcitadel at gmail.com> writes:

> On Wednesday 13 May 2009 01:35:05 Reinhard Tartler wrote:
>> ceros-guest at users.alioth.debian.org writes:
>> > The following commit has been merged in the master branch:
>> > commit 4b453cb6e97f4c960433e2134228b266458ed2bd
>> > Author: Andres Mejia <mcitadel at gmail.com>
>> > Date:   Tue May 12 23:18:59 2009 -0400
>> >
>> >     Add new confflags for new build dependencies.
>> >     Also add confflag for zlib.
>> >     Add 'fix-fpic' DEB_BUILD_OPTIONS for resolving fpic issues.
>>
>> This commit breaks compilation of non-optimized builds that can be
>> requested by setting DEB_BUILD_OPTIONS.
>
> That is unless they apply fpic-ftbfs-fix.patch. In any case, this is a bug in 
> gcc, from what I've read in ffmpeg-devel.

Yes, but that patch has also its own problems.

For us as ffmpeg maintainers, it doesn't matter if it is a bug in gcc or
not, we won't be able to fix them in either case.

> Also, I am going to remove that option but introduce some way to pass in any 
> cflags and other arguments to the configure script.

I don't think this is the right approach. I think it would be much
better to directly work inside the configure script. This would also be
much easier to communicate and discuss with with upstream.

>> As I told you several times, this is really a no-go. In fact, in etch we
>> shipped an ffmpeg compiled this way but did stop that madness in
>> lenny. So this is really a step backwards.
>>
>> Why the heck do you insist on that approach?
>
> ffmpeg is built with -fpic on other archs right? I'm going to check amd64 libs 
> and if they have non-pic code, then I will insist on pursuing this further. If 
> not, very well.

The configure script carefully select the right compiler flags depending
on the architecture and the compilation unit. Passing compiler flags at
configure time is too chunky for ffmpeg, there are too many hand
optimisations, both for architectures and source files. That's why it's
much better to work directly on the configure flags.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4