[Bug 481448] [NEW] VLC lacks build-dep on libupnp3-dev

Reinhard Tartler siretart at tauware.de
Fri Nov 13 07:32:23 UTC 2009 

Whoopie <whoopie79 at gmx.net> writes:

> Please find attached the debdiffs for karmic-proposed and lucid to fix
> the following LP bug reports:
>
> 481448: VLC lacks build-dep on libupnp3-dev
> 439131: libcddb2 not enabled in karmic vlc
> 439077: enable globalhotkeys in karmic vlc

Thank you very much for your patches. I still have some questions on
them before applying.

> diff -u vlc-1.0.2/debian/control vlc-1.0.2/debian/control
> --- vlc-1.0.2/debian/control
> +++ vlc-1.0.2/debian/control
> @@ -23,6 +23,7 @@
>                 libavcodec-dev (>= 0.cvs20060823),
>                 libavformat-dev (>= 0.cvs20060823),
>                 libcaca-dev (>= 0.99.beta4),
> +               libcddb2-dev,
>                 libcdio-dev,
>                 libdca-dev,
>                 libdvbpsi5-dev | libdvbpsi-dev,
> @@ -67,11 +68,13 @@
>                 libtar-dev,
>                 libtheora-dev,
>                 libtwolame-dev (>= 0.3.8),
> +               libupnp3-dev,
>                 libv4l-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
>                 libvcdinfo-dev,
>                 libvorbis-dev,
>                 libx11-dev,
>                 libx264-dev,
> +               libxcb-keysyms1-dev,
>                 libxext-dev,
>                 libxml2-dev,
>                 libxpm-dev,

OK

> diff -u vlc-1.0.2/debian/vlc-nox.install vlc-1.0.2/debian/vlc-nox.install
> --- vlc-1.0.2/debian/vlc-nox.install
> +++ vlc-1.0.2/debian/vlc-nox.install
> @@ -67,7 +67,16 @@
>  usr/lib/vlc/codec/libtheora_plugin.so
>  usr/lib/vlc/codec/libtwolame_plugin.so
>  usr/lib/vlc/codec/libvorbis_plugin.so
> -usr/lib/vlc/control
> +usr/lib/vlc/control/libdbus_plugin.so
> +usr/lib/vlc/control/libgestures_plugin.so
> +usr/lib/vlc/control/libhotkeys_plugin.so
> +usr/lib/vlc/control/libhttp_plugin.so
> +usr/lib/vlc/control/liblirc_plugin.so
> +usr/lib/vlc/control/libmotion_plugin.so
> +usr/lib/vlc/control/librc_plugin.so
> +usr/lib/vlc/control/libshowintf_plugin.so
> +usr/lib/vlc/control/libsignals_plugin.so
> +usr/lib/vlc/control/libtelnet_plugin.so
>  usr/lib/vlc/demux
>  usr/lib/vlc/gui/libncurses_plugin.so
>  usr/lib/vlc/meta_engine

I don't understand this. Previously, the while usr/lib/vlc/control
directory was installed. Now you make the list explicit. I don't see any
practical difference in the resulting vlc-nox package, but I want to ask
here to be sure if this change is indeed spurious.


> diff -u vlc-1.0.2/debian/vlc.install vlc-1.0.2/debian/vlc.install
> --- vlc-1.0.2/debian/vlc.install
> +++ vlc-1.0.2/debian/vlc.install
> @@ -3,6 +3,7 @@
>  usr/lib/vlc/access/libx11_screen_plugin.so
>  usr/lib/vlc/codec/libsdl_image_plugin.so
>  usr/lib/vlc/codec/libx264_plugin.so
> +usr/lib/vlc/control/libglobalhotkeys_plugin.so
>  usr/lib/vlc/gui/libqt4_plugin.so
>  usr/lib/vlc/gui/libskins2_plugin.so
>  usr/lib/vlc/misc/libnotify_plugin.so

This plugin seems to come from the added libxcb-keysyms1-dev, right?

Do the other build dependencies libupnp3-dev and libcddb2-dev not
produce additional functionality? upnp seem to have its sources in
modules/services_discover, and is declared in:

,----[ modules/services_discovery/Modules.am ]
| SOURCES_sap = sap.c
| SOURCES_hal = hal.c
| SOURCES_shout = shout.c
| SOURCES_upnp_cc = upnp_cc.cpp
| SOURCES_upnp_intel = upnp_intel.cpp upnp_intel.hpp
| SOURCES_bonjour = bonjour.c
| SOURCES_podcast = podcast.c
| SOURCES_mtp = mtp.c
| SOURCES_udev = udev.c
`----

without having testbuilt it it seems to me that upnp_cc.so and
upnp_intel.so should have been created, but are left uninstalled in the
package. Is this a correct guess?

Have you checked that the upnp functionality actually works?

for cddb, it seems that indeed no additional module is created, and only
files in modules/access/cdda/* check the define HAVE_LIBCDDB.

The "other" patch for lucid seems largely redundant, but
debian/changelog is missing the upnp change.

> diff -u vlc-1.0.2/debian/changelog vlc-1.0.2/debian/changelog
> --- vlc-1.0.2/debian/changelog
> +++ vlc-1.0.2/debian/changelog
> @@ -1,3 +1,13 @@
> +vlc (1.0.2-1ubuntu2.1) karmic-proposed; urgency=low
> +
> +  * add libupnp3-dev as build-dep to enable UPnP module (LP: #481448) 
> +  * add libcddb2-dev as build-dep to enable CDDB in the CDDA
> +    module (LP: #439131)
> +  * add libxcb-keysyms1-dev as build-dep to enable globalhotkeys
> +    module (LP: #439077)
> +
> + -- Whoopie <whoopie79 at gmx.net>  Thu, 12 Nov 2009 17:32:43 +0100
> +
>  vlc (1.0.2-1ubuntu2) karmic; urgency=low
>  
>    * PulseAudio: higher priority than ALSA, LP: #402018
> diff -u vlc-1.0.3/debian/control vlc-1.0.3/debian/control
> --- vlc-1.0.3/debian/control
> +++ vlc-1.0.3/debian/control
> @@ -23,6 +23,7 @@
>                 libavcodec-dev (>= 0.cvs20060823),
>                 libavformat-dev (>= 0.cvs20060823),
>                 libcaca-dev (>= 0.99.beta4),
> +               libcddb2-dev,
>                 libcdio-dev,
>                 libdca-dev,
>                 libdvbpsi5-dev | libdvbpsi-dev,
> @@ -74,6 +75,7 @@
>                 libvorbis-dev,
>                 libx11-dev,
>                 libx264-dev,
> +               libxcb-keysyms1-dev,
>                 libxext-dev,
>                 libxml2-dev,
>                 libxpm-dev,
> diff -u vlc-1.0.3/debian/vlc-nox.install vlc-1.0.3/debian/vlc-nox.install
> --- vlc-1.0.3/debian/vlc-nox.install
> +++ vlc-1.0.3/debian/vlc-nox.install
> @@ -67,7 +67,16 @@
>  usr/lib/vlc/codec/libtheora_plugin.so
>  usr/lib/vlc/codec/libtwolame_plugin.so
>  usr/lib/vlc/codec/libvorbis_plugin.so
> -usr/lib/vlc/control
> +usr/lib/vlc/control/libdbus_plugin.so
> +usr/lib/vlc/control/libgestures_plugin.so
> +usr/lib/vlc/control/libhotkeys_plugin.so
> +usr/lib/vlc/control/libhttp_plugin.so
> +usr/lib/vlc/control/liblirc_plugin.so
> +usr/lib/vlc/control/libmotion_plugin.so
> +usr/lib/vlc/control/librc_plugin.so
> +usr/lib/vlc/control/libshowintf_plugin.so
> +usr/lib/vlc/control/libsignals_plugin.so
> +usr/lib/vlc/control/libtelnet_plugin.so
>  usr/lib/vlc/demux
>  usr/lib/vlc/gui/libncurses_plugin.so
>  usr/lib/vlc/meta_engine
> diff -u vlc-1.0.3/debian/vlc.install vlc-1.0.3/debian/vlc.install
> --- vlc-1.0.3/debian/vlc.install
> +++ vlc-1.0.3/debian/vlc.install
> @@ -3,6 +3,7 @@
>  usr/lib/vlc/access/libx11_screen_plugin.so
>  usr/lib/vlc/codec/libsdl_image_plugin.so
>  usr/lib/vlc/codec/libx264_plugin.so
> +usr/lib/vlc/control/libglobalhotkeys_plugin.so
>  usr/lib/vlc/gui/libqt4_plugin.so
>  usr/lib/vlc/gui/libskins2_plugin.so
>  usr/lib/vlc/misc/libnotify_plugin.so
> diff -u vlc-1.0.3/debian/changelog vlc-1.0.3/debian/changelog
> --- vlc-1.0.3/debian/changelog
> +++ vlc-1.0.3/debian/changelog
> @@ -1,3 +1,12 @@
> +vlc (1.0.3-1ubuntu2) lucid; urgency=low
> +
> +  * add libcddb2-dev as build-dep to enable CDDB in the CDDA
> +    module (LP: #439131)
> +  * add libxcb-keysyms1-dev as build-dep to enable globalhotkeys
> +    module (LP: #439077)
> +
> + -- Whoopie <whoopie79 at gmx.net>  Thu, 12 Nov 2009 21:28:41 +0100
> +
>  vlc (1.0.3-1ubuntu1) lucid; urgency=low
>  
>    * Merge from Debian unstable (LP: #435524), remaining changes:
> _______________________________________________
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

More information about the pkg-multimedia-maintainers mailing list