quick XBMC review

Bruno Kleinert fuddl at tauware.de
Wed Nov 25 21:35:59 UTC 2009


Hi there,

I had a quick look at XBMC's source tree and wrote some kind of
"protocol" about everything that didn't look that good to me. Here we
go...

---[ snip ]---
Copies of external packages' source code
========================================
tinyXML version unknown
lib/fontconfig_win32 version 2.7.3
lib/freetype version 2.3.9
lib/libSDL-WIN32 unknown version, patched with
lib/libSDL-WIN32/SDL_SetWidthHeight.diff
system/python/spyce
cdrip/oggvorbis/*
cores/dvdplayer/Codecs/ffmpeg
cores/dvdplayer/Codecs/liba52
cores/dvdplayer/Codecs/libdts
cores/dvdplayer/Codecs/libdvd
cores/dvdplayer/Codecs/libfaad2
cores/dvdplayer/Codecs/libmad
cores/dvdplayer/Codecs/libmpeg2
cores/dvdplayer/DVDCodecs/Audio/liba52
cores/dvdplayer/DVDCodecs/Audio/libdts
cores/dvdplayer/DVDCodecs/Audio/libfaad
cores/dvdplayer/DVDCodecs/Audio/libmad
cores/dvdplayer/DVDInputStreams/dvdnav
cores/dvdplayer/DVDInputStreams/mms
cores/ffmpeg
cores/paplayer/AC3Codec
cores/paplayer/FLACCodec/flac-1.2.1
cores/paplayer/ModuleCodec/dumb also it's non-DFSG free
cores/paplayer/ogg
cores/paplayer/SIDCodec/libsidplay
cores/paplayer/SIDCodec/builders/hardsid-build
cores/paplayer/SIDCodec/builders/resid-builder
cores/paplayer/SPCCodec
xbmc/cores/paplayer/timidity
cores/paplayer/vgmstream
cores/paplayer/vorbisfile
cores/paplayer/WavPackCodec
cores/paplayer/YMCodec
FileSystem/curl
lib/"mostly"* - WTF?! What an unbelievable mess! Even source copies
contain other source copies?!?
xbmc/screensavers/rsxs-0.9
xbmc/visualizations/Goom/goom2k4-0 - Copied & patched
xbmc/visualizations/Milkdrop/vis_milkdrop
xbmc/visualizations/OpenGLSpectrum


Illegal sources
===============
media/Fonts/arial.ttf
All precompiled binaries (Some with not so obvious suffixes)
skin/PM3.HD/HomeSystemIcon Licence.txt is non-DFSG free
skin/Project Mayhem III/fonts/FrancophilSans_readme.txt is non-DFSG free
found in tools/Linux/debian/copyright - DUMB license is non-DFSG;
requires the licensee to feed their dogs at full moon. Haha, that is so
funny...


Questionable/Useless
====================
media/weather.rar
credits/credits.mod
find -iname "*.bat"
keymapping-schematic.pdf (Xbox, Microsoft logos, origin/author?)
project/*
xbmc-xrandr.c - WTF?!
scripts/*.zip
skin/PM3.HD/backgrounds/*.jpg (copyrights/authors questionable)
skin/PM3.HD/media/flagging/audio/{dolbydigital.png,dts.png,mp3.png,wmapro.png} trademark logos and license/redistribution?
skin/PM3.HD/media/flagging/video/{divx.png,h264.png} trademark logos and
license/redistribution?
system/asound.conf - WTF?!
system/python/DLLs 'file' says precompiled PE32 binaries for .pyd files
system/scrapers/video some files are company/trademark logos. author?
copyright? redistribution?
tools/MingwBuildEnvironment/msys.7z
tools/PackageMaker
tools/TexturePacker
tools/XBMCLive
tools/XBMCTex
tools/XprPack
visualisations - 'file' says there are lots of PE32 binaries with
suffix .vis
visualisations/Milkdrop/*.zip - ?!?
visualisations/projectM - Authors? Copyright? Redistribution? Looks
stolen to me
cores/paplayer/ADPCMCodec
cores/paplayer/GYMCodec
cores/paplayer/MACDll MAC code? License is non-DFSG free
cores/paplayer/shn - non-DFSG free
xbmxc/osx - Whatever its licenses are, do we care about such sources?


General
=======
Most GPL source code comment headers have an outdated FSF address
Stuff (source or binary doesn't matter) from commercial platforms like
Mac OS X and Windows is not our business. Whatever its licences say, it
should not be part of an .orig.tar.*
---[ snap ]---

I don't plan to dig into XBMC myself because I don't use it nor do I
plan to use it. It simply got my attraction because a friend uses it and
some things looked like a very messy hack to me ;)

Maybe some of the above things are already fixed, I reviewed XBMC some
weeks ago, so my protocol is probably a bit outdated.

Cheers - Fuddl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20091125/4c79139c/attachment.pgp>


More information about the pkg-multimedia-maintainers mailing list