[RFR] templates://jack-audio-connection-kit/{jackd.templates}

Jonathan Wiltshire debian at jwiltshire.org.uk
Mon Sep 21 21:40:18 UTC 2009


Please find, for review, the debconf templates of jack-audio-connection-kit.

This review will last from Monday, September 21, 2009 to Thursday, October 01, 2009.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I will send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Diff and rationale:


--- /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit.old/debian/jackd.templates	2009-07-26 20:15:56.000000000 +0100
+++ /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit/debian/jackd.templates	2009-09-21 22:30:19.000000000 +0100
@@ -1,17 +1,12 @@
 Template: jackd/tweak_rt_limits
 Type: boolean
 Default: false
-_Description: Do you want to enable realtime priorities in /etc/security/limits.d?
+_Description: Enable realtime process priority?


Shorten the description and clarify what's going to be set realtime

- If you want to run jackd with realtime priorities, the user starting jackd
- needs realtime permissions. This is usually accomplished by tweaking
- rtprio and memlock in /etc/security/limits.conf, either for a specific
- user or for the audio group in general.
+ To run jackd with realtime priority, the user starting jackd
+ needs realtime permissions. The installer can enable realtime priority
+ for the audio group in /etc/security/limits.d/audio.conf.
  .
- Raising memlock and rtprio limits may lead to complete system lock-ups due
- to highest scheduler priorities or denial of service attacks by requesting
+ Running jackd with realtime priority minimizes latency, but
+ may lead to complete system lock-ups by requesting
  all the available physical system memory, which is unacceptable in
  multi-user environments.

Shorten and make more concise the template so it's easy to read and
understand, including the risks. 

- .
- The Debian default is to DISABLE realtime priorities, however, if you
- intend to run jackd with very low latencies, enable this option in order to
- place the approriate settings in /etc/security/limits.d/audio.conf.

Not needed; we already know the Debian default because...well, it's the
default.

--- /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit.old/debian/control	2009-07-26 20:15:56.000000000 +0100
+++ /home/jona/debian/rewrite/jack-audio-connection-kit/jack-audio-connection-kit/debian/control	2009-09-21 22:31:14.000000000 +0100
@@ -46,8 +46,6 @@
  to an audio device, as well as allowing them to share audio between
  themselves.
  .
- See <http://jackaudio.org/> for more info.
- .
  This package contains the daemon jackd as well as some example clients.

Here and below, the boilerplate looks fine but doesn't need to duplicate
the Homepage: field.
 
 Package: libjack0
@@ -63,8 +61,6 @@
  to an audio device, as well as allowing them to share audio between
  themselves.
  .
- See <http://jackaudio.org/> for more info.
- .
  This package contains the shared libraries.
 
 Package: libjack-dev
@@ -81,7 +77,5 @@
  to an audio device, as well as allowing them to share audio between
  themselves.
  .
- See <http://jackaudio.org/> for more info.
- .
  This package contains files needed for the development of JACK applications
  and an API reference.
-------------- next part --------------
Template: jackd/tweak_rt_limits
Type: boolean
Default: false
_Description: Enable realtime process priority?
 To run jackd with realtime priority, the user starting jackd
 needs realtime permissions. The installer can enable realtime priority
 for the audio group in /etc/security/limits.d/audio.conf.
 .
 Running jackd with realtime priority minimizes latency, but
 may lead to complete system lock-ups by requesting
 all the available physical system memory, which is unacceptable in
 multi-user environments.
-------------- next part --------------
--- ../jack-audio-connection-kit.old/debian/jackd.templates	2009-07-26 20:15:56.000000000 +0100
+++ debian/jackd.templates	2009-09-21 22:30:19.000000000 +0100
@@ -1,17 +1,12 @@
 Template: jackd/tweak_rt_limits
 Type: boolean
 Default: false
-_Description: Do you want to enable realtime priorities in /etc/security/limits.d?
- If you want to run jackd with realtime priorities, the user starting jackd
- needs realtime permissions. This is usually accomplished by tweaking
- rtprio and memlock in /etc/security/limits.conf, either for a specific
- user or for the audio group in general.
+_Description: Enable realtime process priority?
+ To run jackd with realtime priority, the user starting jackd
+ needs realtime permissions. The installer can enable realtime priority
+ for the audio group in /etc/security/limits.d/audio.conf.
  .
- Raising memlock and rtprio limits may lead to complete system lock-ups due
- to highest scheduler priorities or denial of service attacks by requesting
+ Running jackd with realtime priority minimizes latency, but
+ may lead to complete system lock-ups by requesting
  all the available physical system memory, which is unacceptable in
  multi-user environments.
- .
- The Debian default is to DISABLE realtime priorities, however, if you
- intend to run jackd with very low latencies, enable this option in order to
- place the approriate settings in /etc/security/limits.d/audio.conf.
--- ../jack-audio-connection-kit.old/debian/control	2009-07-26 20:15:56.000000000 +0100
+++ debian/control	2009-09-21 22:31:14.000000000 +0100
@@ -46,8 +46,6 @@
  to an audio device, as well as allowing them to share audio between
  themselves.
  .
- See <http://jackaudio.org/> for more info.
- .
  This package contains the daemon jackd as well as some example clients.
 
 Package: libjack0
@@ -63,8 +61,6 @@
  to an audio device, as well as allowing them to share audio between
  themselves.
  .
- See <http://jackaudio.org/> for more info.
- .
  This package contains the shared libraries.
 
 Package: libjack-dev
@@ -81,7 +77,5 @@
  to an audio device, as well as allowing them to share audio between
  themselves.
  .
- See <http://jackaudio.org/> for more info.
- .
  This package contains files needed for the development of JACK applications
  and an API reference.
-------------- next part --------------
Source: jack-audio-connection-kit
Section: sound
Priority: optional
Maintainer: Debian Multimedia Maintainers <pkg-multimedia-maintainers at lists.alioth.debian.org>
Uploaders: Guenter Geiger (Debian/GNU) <geiger at debian.org>,
	   Junichi Uekawa <dancer at debian.org>,
	   Free Ekanayaka <freee at debian.org>,
	   Reinhard Tartler <siretart at tauware.de>,
	   Adrian Knoth <adi at drcomp.erfurt.thur.de>
Build-Depends: cdbs,
	       type-handling,
	       debhelper (>= 7.0.0),
	       patchutils,
	       dh-buildinfo,
	       libasound2-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
	       libsndfile1-dev,
	       doxygen,
	       automake,
	       libtool,
	       libreadline5-dev,
	       libraw1394-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
	       libfreebob0-dev [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
	       libsamplerate-dev,
	       po-debconf,
	       libcelt-dev,
	       libffado-dev [amd64 i386 powerpc]
Standards-Version: 3.8.2
Homepage: http://jackaudio.org/
Vcs-Git: git://git.debian.org/git/pkg-multimedia/jack-audio-connection-kit.git
Vcs-Browser: http://git.debian.org/?p=pkg-multimedia/jack-audio-connection-kit.git;a=summary

Package: jackd
Architecture: any
Depends: ${shlibs:Depends},
	 ${misc:Depends},
	 coreutils (>= 4.0),
	 debconf | debconf-2.0,
	 libjack0 (= ${binary:Version})
Recommends: qjackctl,
	    libpam-modules
Suggests: jack-tools,
	  meterbridge,
	  libjackasyn0
Description: JACK Audio Connection Kit (server and example clients)
 Low-latency sound server. JACK allows the connection of multiple applications
 to an audio device, as well as allowing them to share audio between
 themselves.
 .
 This package contains the daemon jackd as well as some example clients.

Package: libjack0
Architecture: any
Section: libs
Depends: ${shlibs:Depends},
	 ${misc:Depends}
Conflicts: jackd (>> ${binary:Version}),
	   jackd (<< ${binary:Version})
Suggests: jackd (= ${binary:Version})
Description: JACK Audio Connection Kit (libraries)
 Low-latency sound server. JACK allows the connection of multiple applications
 to an audio device, as well as allowing them to share audio between
 themselves.
 .
 This package contains the shared libraries.

Package: libjack-dev
Architecture: any
Section: libdevel
Depends: libjack0 (= ${binary:Version}),
	 ${asound:Depends},
	 pkg-config,
	 ${misc:Depends},
	 ${shlibs:Depends}
Provides: libjack0.100.0-dev
Description: JACK Audio Connection Kit (development files)
 Low-latency sound server. JACK allows the connection of multiple applications
 to an audio device, as well as allowing them to share audio between
 themselves.
 .
 This package contains files needed for the development of JACK applications
 and an API reference.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20090921/04441b12/attachment.pgp>


More information about the pkg-multimedia-maintainers mailing list