Bug#548537: libjack-dev: functions described as deprecated should be marked as such

[Darren Salt]

I demand that Adrian Knoth may or may not have written...

> On Sun, Sep 27, 2009 at 12:12:32AM +0100, Darren Salt wrote:
>> Functions such as jack_client_new() are marked in *comments* as
>> deprecated. They should be marked as deprecated such that the compiler
>> will notice and emit appropriate warnings should any of them be used.

> Though I agree that this would be nice, I don't see how to achieve it.

Function attributes.

[snip]
> Don't worry, jack_client_new is well supported by all versions of jackd
> and will stay there for quite some time.

> If you know a way how to issue a warning from a header file, please let
> me know and I'll craft a patch.

I think that this will do for Debian purposes:

  int foo (void) __attribute__((__deprecated__));

Upstream might prefer something like this, though:

  #if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ >= 3 )
  # define JACK_DEPRECATED __attribute__((__deprecated__))
  #else
  # define JACK_DEPRECATED
  #endif

  int foo (void) JACK_DEPRECATED;

(FWIW, xine-lib does this kind of thing.)

-- 
| Darren Salt            | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
| + Generate power using sun, wind, water, nuclear.      FORGET COAL AND OIL.

How many weeks are there in a light year?