RFS: advene

Alessandro Ghedini al3xbio at gmail.com
Wed Dec 1 18:18:02 UTC 2010


Hi,
Your package seems interesting, but I have some remarks about the packaging.
First of all there is no reason to make it a native package, since it does 
not relate directly to Debian (the fact that you use Debian as development 
system doesn't make any difference). You should really switch 3.0 
(quilt) and provide all the Debian related files (debian/*) in a 
different archive, regardless of the Debian Multimedia Team policies.

I also noticed that in the source tarball you provided, are present all the 
temporary files created by the package generation process. You should 
remove them. Just do:

  $ fakeroot debian/rules clean
  $ fakeroot debian/rules build

(or debclean && debuild if you want to use the devscripts).
That would generate a cleaner archive.

Last but not least your package is not Lintian clean. I can count 4 
warnings, 1 pedantic and many other info tags (mostly because of the empty 
directories), you should fix them.

This was just a quick review (I didn't tried to build or test it), so
there may be other issues I didn't notice. Please wait a review by someone 
else, hopefully more experienced than me.

Thanks for your work.

Cheers

-- 
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'



More information about the pkg-multimedia-maintainers mailing list