RFS: deadbeef (2nd try)
paultag at ubuntu.com
Mon Dec 6 23:22:29 UTC 2010
On Sat, Dec 4, 2010 at 8:55 AM, Alessandro Ghedini <al3xbio at gmail.com> wrote:
> Dear mentors,
> I am looking for a sponsor for my package "deadbeef".
> * Package name : deadbeef
> Version : 0.4.4~dfsg-1
> Upstream Author : Alexey Yakovenko <waker at users.sourceforge.net>
> * URL : http://sf.net/projects/deadbeef
> * License : Mostly GPL-2+ and LGPL-2+
> Section : sound
> It builds these binary packages:
> deadbeef - Ultimate Music Player For GNU/Linux
> deadbeef-plugins - Plugins for DeaDBeeF music player
> deadbeef-plugins-dev - Plugins for DeaDBeeF music player (development files)
> The package appears to be lintian clean.
> The upload would fix these bugs: 576975 (ITP)
> I removed all the non DFSG-compliant files (which are documented in
> README.source) and also added a get-orig-source rule (thanks to Paul,
> Alessio and Jonas for the help).
> I managed to get all the patches to work and finished the debian/copyright,
> so the todo list  is now empty (besides the review part).
> I would be glad if someone reviewed it and created a git repo.
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/d/deadbeef
> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/d/deadbeef/deadbeef_0.4.4~dfsg-1.dsc
> Kind regards
> Alessandro Ghedini
>  http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/2010-December/014427.html
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
I'm not a DD, but here's my review ( I'd still wait for quadrispro,
he's way better at this then me )
At first glance, it seems like you're newlining a bit too much on the
control deps. It's valid, and better then a single line, but see if
you can hit under 80, and get more then one to a line. Helps cut out
some scrolling ( and you can check all the deps in a terminal :)
Your description is great, but way-y-y-y-y long :)
You have a few non-critical errors on your debs:
P: deadbeef: no-upstream-changelog
P: deadbeef-plugins: no-upstream-changelog
X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/alsa.so.0.0.0
X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/dca.so.0.0.0
X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/gtkui.so.0.0.0
X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/notify.so.0.0.0
X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/sid.so.0.0.0
X: deadbeef-plugins: shlib-calls-exit usr/lib/deadbeef/vtx.so.0.0.0
P: deadbeef-plugins-dev: no-upstream-changelog
My guess is that the changelog one does not need fixing, just set it
to install in the core package, and similink it something. There was
just a thread where I said the same thing.
Those X: errors are for upstream, my guess is.
Nice patches, copyright file.
0.4.4~dfsg-1 might be better phrased as 0.4.4-1~dfsg1
guesses here, I am guessing as to what's going on ( take this last bit
with a grain of salt )--
install should be deadbeef.install
menu should be deadbeef.menu
manpages should be deadbeef.manpages
docs should be deadbeef.docs
All programmers are playwrights, and all computers are lousy actors.
#define sizeof(x) rand()
More information about the pkg-multimedia-maintainers