[SCM] mplayer packaging branch, ubuntu, updated. debian/1.0.rc3++final-0ubuntu2

[Felipe Sateler]

On Thu, Jun 3, 2010 at 09:26, Reinhard Tartler <siretart at tauware.de> wrote:
> On Do, Jun 03, 2010 at 15:05:04 (CEST), siretart at users.alioth.debian.org wrote:
>
>> +clean:
>>       dh_testdir
>>       dh_testroot
>>       [ ! -f config.mak ] || $(MAKE) distclean
>>       dh_clean build-arch-stamp configure-arch-stamp snapshot_version
>> +     ! test -d .git || quilt pop -a || test $$? = 2
>
> This line expects that if we are building in a git repo, that quilt is
> installed on the developer system. I guess this to is a reasonable
> assumption.

I agree, but may be confusing in the case that it does fail. Maybe a
note in README.source would be useful?

>
>>  # Build architecture-independent packages
>>  binary-indep: install-indep
>> diff --git a/debian/source/format b/debian/source/format
>> index d3827e7..163aaf8 100644
>> --- a/debian/source/format
>> +++ b/debian/source/format
>> @@ -1 +1 @@
>> -1.0
>> +3.0 (quilt)
>> diff --git a/debian/source/options b/debian/source/options
>> new file mode 100644
>> index 0000000..98a0c1a
>> --- /dev/null
>> +++ b/debian/source/options
>> @@ -0,0 +1,2 @@
>> +single-debian-patch
>
> this fixes the filename of the generated patch.

I'm not quite sure this is correct... You already have
debian/patches/*. What is your intended purpose with this flag?

>
>> +skip-patches
>
> Does anyone object to this? I hoped that it would have effect on
> building a source package, unfortunately, it has not.

This options should be applied at extract time. It has no meaning at
build time (patches are never applied when building a source package,
they are stored in the debian.tar.gz).

>
>
> --
> Gruesse/greetings,
> Reinhard Tartler, KeyID 945348A4
>
> _______________________________________________
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/mailman/listinfo/pkg-multimedia-maintainers
>



-- 

Saludos,
Felipe Sateler