RFS: mpd-sima (updated package)

[Kilian Krause]

Hi Geoff,

On Wed, Aug 03, 2011 at 09:47:47PM +0200, Geoffroy Youri Berret wrote:
> Thanks for your review :)
> 
> Le 03/08/2011 18:29, Kilian Krause a écrit :
> > On Mon, Aug 01, 2011 at 04:42:15PM +0200, Geoffroy Youri Berret wrote:
> >> I gentle ping on this package :)
> >>
> >> I moved the packaged to "Debian Multimedia Maintainers".
> >> 	git://git.debian.org/pkg-multimedia/mpd-sima.git
> >>
> >> I believe the package to be in pretty good shape now.
> > […]
> > 1.) You build-depend on bash-completion. What for? Moreover you build-depend
> >     on python-all which huge compared to what you will actually need IMHO.
> >     Why not limit that more to what is actually required?
> [bash-completion]
> I need bash-completion because it provides dh_bash-completion.
> It'll handle debian/mpd-sima.bash-completion properly.

Right. See that now. ;-)


> [python-all]
> Well, I think need python 2.6 and python 2.7, I guess then I could save python
> 2.5 setting a build depends on python2.6 instead of python-all.
> But isn't “python-all (>= 2.6.6-3~)” similar?

Ok, in that case I guess I can consider your solution a good solution. I was
hoping that you only need some few modules to build and reducing to only
these modules with reducing the amount of build-depends (looking at the
whole tree) in mind would make sense. I'll have your word for it that this
isn't an option. 


[...]
> “4.)” somehow disappeared ^^

Yes, that was a criticism that didn't sustain a second look. ;-)



[...]
> I've uploaded a new version, tagged 0.8.0-1, to mentors.
> I haven't pushed to the git repo yet.
> 
> http://mentors.debian.net/debian/pool/main/m/mpd-sima/mpd-sima_0.8.0-1.dsc

Very good. Built, Signed, Uploaded. 

Please don't forget to update your git (including retagging the 0.8.0-1 and
deleting a eventually existing -2 tag).

-- 
Best regards,
Kilian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20110803/bb11c0b7/attachment.pgp>