[Lame-dev] New lame upstream release?

[Rogério Brito]

Hi, Andreas and others.

On Jul 27 2011, Andres Mejia wrote:
> 2011/7/27 Rogério Brito <rbrito at ime.usp.br>:
> > Oh, shit. I'll take a look at that... I thought that the code were
> > ifdef'ed... Isn't it?
> 
> I have a patch here with some changes we do to the build system.

OK.

> We outright disable the use of the GTK frontend, since it requires a very
> old version of GTK. I think there are better tools out now (audacity
> maybe). Perhaps the GTK frontend should be removed from lame entirely.

Sure, it has not compiled for ages and I think that killing it leaves us
with less cruft. If someone happens to want to port it forward to GTK2 or
GTK3, though, we may reinstate it...

> The other change simply changes how the debian directory is included
> in the generated tarball. The debian directory still gets included,
> but there's no need to have any "Makefile*" files in the debian
> directory. This would remove our need to patch the build system for
> each release of lame.
(...)
> 
>  CLEANFILES = lclint.txt $(EXTRA_PROGRAMS)

Can you please send "git format-patch/git send-email" patches against my
github tree (branch origin), with one topic per patch?

Your patches came foo-bared and they are changing at least two things (the
GTK stuff and the debian subdir).

> I've started replacing frontend/portableio.* code. I should have
> something available later on tonight.

Please see the attached patch to kill portableio.c if you are using
libsndfile (which we should be in debian, anyway).

It *is* dirty and there's one function (the one to read stuff) that is not
used, but works for the purpose of decoding some files (I tested).

I should probably adapt something from a patch that I once wrote to mplayer
ages ago when I was trying to make the generated PCM files works for little
and big-endian arches (hey, I *care* about PowerPC).

Or if libsdnfile does that already, that's even better. But for the sake of
just shipping a first package in unstable, I am very anxious... :-) I want
to see this darn thing in Debian proper! :-)

> One final thing, I delete the "LICENSE" file from the upstream tarball
> since the "COPYING" file has the actual license text and the contents
> of "LICENSE" seem to what is already said in the "README" file.
> Perhaps you might want to look into that too.

Will look into that for the next release. Please, *do* ping me if I forget
about this.


Thanks,

-- 
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kill-portable-audio.patch
Type: text/x-diff
Size: 22270 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20110728/42dc35c3/attachment-0001.patch>