Bug#649462: csound: FTBFS: InOut/virtual_keyboard/virtual_keyboard.cpp:435:77: error: format not a string literal and no format arguments [-Werror=format-security]

[Nobuhiro Iwamatsu]

Source: csound
Version: 1:5.14.2~dfsg-1
Severity: serious
Justification: fails to build from source

Hi,

csound FTBFS on some architecture.

 https://buildd.debian.org/status/package.php?p=csound
 http://buildd.debian-ports.org/status/package.php?p=csound

-----
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/FLTKKeyboard.os -c
-Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/FLTKKeyboard.cpp
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/FLTKKeyboardWidget.os
-c -Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/FLTKKeyboardWidget.cpp
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/FLTKKeyboardWindow.os
-c -Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/FLTKKeyboardWindow.cpp
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/KeyboardMapping.os -c
-Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/KeyboardMapping.cpp
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/Program.os -c
-Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/Program.cpp
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/SliderBank.os -c
-Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/SliderBank.cpp
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/SliderData.os -c
-Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/SliderData.cpp
arm-linux-gnueabi-g++ -o InOut/virtual_keyboard/virtual_keyboard.os -c
-Wno-format -Wno-format -DGNU_GETTEXT -g -fomit-frame-pointer
-freorder-blocks -DLINUX -DPIPES -DNO_FLTK_THREADS -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Wformat-security
-Werror=format-security -fPIC -DHAVE_LIBSNDFILE=1016 -DHAVE_FLTK
-DUSE_DOUBLE -DHAVE_SOCKETS -DHAVE_PTHREAD_SPIN_LOCK
-DHAVE_PTHREAD_BARRIER_INIT -DHAVE_SYNC_LOCK_TEST_AND_SET
-DHAVE_FCNTL_H -DHAVE_UNISTD_H -DHAVE_STDINT_H -DHAVE_SYS_TIME_H
-DHAVE_SYS_TYPES_H -DHAVE_TERMIOS_H -DHAVE_VALUES_H -DHAVE_SOCKETS
-DHAVE_DIRENT_H -D_FORTIFY_SOURCE=2 -D_THREAD_SAFE -D_REENTRANT -I.
-IH -I/usr/include/lua5.1 -I/usr/include/tcl
-I/usr/lib/jvm/default-java/include
-I/usr/lib/jvm/default-java/include/linux -I/usr/include/stk
-I/usr/local/include -I/usr/include -I/usr/X11R6/include
-I/usr/include/freetype2 -IInOut -IInOut/virtual_keyboard
InOut/virtual_keyboard/virtual_keyboard.cpp
InOut/virtual_keyboard/virtual_keyboard.cpp: In function 'int
csoundModuleInit(CSOUND*)':
InOut/virtual_keyboard/virtual_keyboard.cpp:435:77: error: format not
a string literal and no format arguments [-Werror=format-security]
cc1plus: some warnings being treated as errors

scons: *** [InOut/virtual_keyboard/virtual_keyboard.os] Error 1
scons: building terminated because of errors.
make: *** [debian/stamp-scons-build] Error 2
-----

Please check your package.

Best regards,
 Nobuhiro

--
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6