RFS: screenkey - utility to display pressed keys in screencasts/presentations

[Alessandro Ghedini]

On Wed, Oct 12, 2011 at 04:32:26PM +0200, Eshat Cakar wrote:
> Hi everybody,

Hi,

> I am happy to become a memeber of the multimedia team and help in getting 
> debian a little bit better when it comes to multimedia stuff. 

Welcome on board :)

Did you read our docs about packaging? [0]

> .:: Further information ::.
> ===========================
> 
>  * Package name    : screenkey
>    Version         : 0.2-1
>    Upstream Author : Pablo Seminario <pabluk at gmail.com>
>  * URL             : http://launchpad.net/screenkey
>  * License         : GPLv3
>    Section         : video
>    Language        : python/pygtk
> 
> It builds the binary package: screenkey

Here are few notes on your package. Note that I'm not a DD therefore I 
can't upload the package.

First thing first, the git repository is missing the "pristine-tar" branch,
please create it (it should be automatically generated by git-import-orig
using the --pristine-tar flag, or manually using the pristine-tar(1) 
utility). It is also missing an "upstream/0.2" tag (also created by 
git-import-orig).

* debian/chaneglog:
  - This shouldn't mention versions previous to the actual upload to Debian
    (moreover if they refer to Ubuntu).
* debian/compat:
  - Any reason why you are not using compat level 8?
* debian/control:
  - The Maintainer field should read "Debian Multimedia Maintainers <...>"
    (note the initial "Debian").
  - The package FTBS: you are missing a Build-Depends on python (needed 
    because of dh_python2). I'm not really into packaging Python stuff
    hence I can't help any further.
  - You should probably rewrite the short and long descriptions, since they 
    are, IMHO, not very helpful (a bit better are the ones from the 
    manpage, or the Subject of your RFS email).
* debian/patches/*:
  - Have a look at DEP3 [1] about "Patch Tagging Guidelines" and please use
    it for your patches, or use the gbp-pq(1) utility that comes with
    git-buildpackage (this is not mandatory, but appreciated).
  - You may also want to forward your patches upstream (also valid for the
    manpage).

That's all from me, but I may have missed something.

Cheers

[0] http://wiki.debian.org/DebianMultimedia/DevelopPackaging
[1] http://dep.debian.net/deps/dep3/

-- 
perl -E'$_=q;$/= @{[@_]};and s;\S+;<inidehG ordnasselA>;eg;say~~reverse'