Bug#654395: problem in debian/patches/0005-install_in_usr_lib.patch

[Antonio Ospite]

Tags: patch

On Thu, 05 Jan 2012 01:50:18 +0100
Luka Frelih <luka at ljudmila.org> wrote:

> the crash seems to be introduced in 
> debian/patches/0005-install_in_usr_lib.patch by omitting blender version 
> in printf arguments
> 
> diff --git a/source/blender/blenlib/intern/path_util.c 
> b/source/blender/blenlib/intern/path_util.c
> index e79d850..eb5e063 100644
> --- a/source/blender/blenlib/intern/path_util.c
> +++ b/source/blender/blenlib/intern/path_util.c
> @@ -1025,7 +1025,7 @@ static int get_path_system(char *targetpath, const 
> char *folder_name, const char
> 
>       system_base_path = (const char *)GHOST_getSystemDir();
>       if (system_base_path) {
> -        BLI_snprintf(system_path, FILE_MAX, BLENDER_SYSTEM_FORMAT, 
> system_base_path, blender_version_decimal(ver));
> +        BLI_snprintf(system_path, FILE_MAX, BLENDER_SYSTEM_FORMAT, 
> system_base_path);
>       }
> 
>       if(!system_path[0])
> 
> 
> built with this change reversed, blender runs and does not crash.
> 
> however, for some reason no menus are showing in my build... may be 
> another bug or something in my build environment?

Probably when 0005-install_in_usr_lib.patch was refreshed for 2.61 the
maintainers forgot to include also the bits about BLENDER_SYSTEM_FORMAT.

The attached patch makes everything work again.

The patch is against the master branch of the debian packaging at
git://anonscm.debian.org/pkg-multimedia/blender.git
you can apply it with "git am" so I figure out as the author.

The attached file contains two commits:
 - The first one is a refresh of 0008-update_manpages.patch to make
   "git buildpackage" happy.
 - The second one adds
   0010-Don-t-use-version-number-in-the-system_path.patch
   to fix this very bug.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debian-blender-close-654395-and-misc.patch
Type: text/x-diff
Size: 4386 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120106/af4ff240/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20120106/af4ff240/attachment.pgp>