Bug#641701: A patch for ffaudio with audacious 3.2

[Cyril Lavier]

On 01/28/2012 05:26 PM, Reinhard Tartler wrote:
> On Sa, Jan 28, 2012 at 11:46:46 (CET), Cyril Lavier wrote:
>
>> Hi.
>>
>> On the audacious forum, Andrei Alin proposed a patch for this.
>>
>> I tried to include it in the audacious-plugins source package (I rewrote
>> it, using autoconf for regenerate the configure file). It builds fine
>> and the ffaudio plugin is enabled again (not enabled in the 3.2-1).
>>
>> I don't know if I will include it in the next upload (I don't even know
>> if I will push it in the GIT repo), as it's a quite big patch. But
>> audacious developers are not going to make the plugin compatible with
>> older versions of ffmpeg.
> Well, the patch *reduces* the requirements on libavformat and libavcodec
> considerably (libavcodec53 ->  libavcodec52, and libavformat53 ->
> libavformat52:
>
> --- a/configure.ac
> +++ b/configure.ac
> @@ -549,7 +549,7 @@
>
>   if test $enable_ffaudio = yes ; then
>       PKG_CHECK_MODULES([FFMPEG],
> -     [libavcodec>= 53.40.0 libavformat>= 53.5.0 libavutil>= 50.42.0],
> +     [libavcodec>= 52.64.0 libavformat>= 52.110.0 libavutil>= 50.42.0],
>        [have_ffaudio=yes], [have_ffaudio=no])
>   fi
>
> Note that these requirements do not suffice for squeeze, which ships
> libavformat with these library version numbers:
>
>    24 #define LIBAVFORMAT_VERSION_MAJOR 52
>    25 #define LIBAVFORMAT_VERSION_MINOR 31
>    26 #define LIBAVFORMAT_VERSION_MICRO  0
>
> and libavcodec with:
>
>    32 #define LIBAVCODEC_VERSION_MAJOR 52
>    33 #define LIBAVCODEC_VERSION_MINOR 20
>    34 #define LIBAVCODEC_VERSION_MICRO  1
>
> I therefore wonder why you've chosen those particular version
> requirements, since there is an updated libav package set in
> squeeze-backports.
Hi.

I didn't choose anything, I just took the patch which Andrei did, just 
rewrote it and applied it to the sources. But I agree with your comment, 
as I don't know why he chose those particular version.

I will work on reducing these requirements for easing the making of a 
squeeze-backport (as I'm the backporter, I won't have to work twice on 
the patch).
>
>> I completely understand that upgrading the needed libs is quite risky
>> and won't be done in the next days/weeks without risking to break a lot
>> of packages.
> What libraries would require updates? Currently, we do ship up-to-date
> packages.
Sorry, I completely messed this paragraph, I was writing 2 mails at the 
same time and my colleagues might think I'm crazy now, after talking 
about audacious in a corporate mail about an off-hours product update 
which turned bad :/.
>
>> So I would like to know what do you think about this patch, if this can
>> be a good solution, and then I will perform the needed changes and push
>> it to the git repo or if you think it's not a good solution, we won't
>> have the plugin working for now.
> The configure part can be dropped if you run the autofoo toolchain on
> the buildds (cf. dh-autoreconf or similar).
Thanks for this idea.
> The ffaudio-core part looks reasonable to me on the first sight. It
> could probably simplified a bit by requiring libav{codec,format}>= 53
>
> Cheers,
> Reinhard
>
Thanks for this quick review.

I will focus on making this patch working for debian squeeze and more 
testing with this patch activated.

Thanks

-- 
Cyril "Davromaniak" Lavier