team-wide uniform ~/.quiltrc

Alessio Treglia alessio at debian.org
Sun Jun 24 09:15:00 UTC 2012


Ciao Thorsten!

How are you mate? I hope you're doing well.

On Sat, Jun 23, 2012 at 4:58 PM, Thorsten Glaser <tg at mirbsd.de> wrote:
> Ciao Alessio ;-) and greetings from your favourite croatian restaurant ☺

Ohh jealousy here, the best soups ever! :-)

> I’ve not added --diffstat to mine out of personal preference, I found
> them to be spam and uninteresting, but you can clear that within your
> team. I’ve also not added --strip-trailing-whitespace because the docs
> didn’t make it clear whether it strips trailing whitespace only in the
> rest of the file (good!) or also in the patched files’ “+” parts which,
> while I’d prefer it, is actually harmful (there are files that require
> trailing whitespace in their syntax, and I’d rather not break those by
> accident; while they are few, debugging this is usually a real PITA).

A really a good catch! So agreed, adding '--strip-trailing-whitespace' is
definitely _not_ a good practice.

Regarding '--diffstat', although diffstat's histograms actually introduce
unnecessary rubbish with small patches, I find those headers showing
statistics very handy when reviewing large patches involving multiple files.

So, I'd suggest adding '--diffstat' only to patchset worthing it and avoid it
when dealing with small, minimalistic or single file patches.

> This ~/.quiltrc file does not contain enough copyrightable work to
> fall under copyright law and thus does not need a copyright licence,
> but if you’d prefer one, take any licence that has ever been OSI
> approved.

Very good, I suppose we can adopt it as is and I think we don't need any
kind of licensing, a small "Originally written by" note is enough, isn't it?

Cheers, and thank you so much for the review!

-- 
Alessio Treglia          | www.alessiotreglia.com
Debian Developer         | alessio at debian.org
Ubuntu Core Developer    | quadrispro at ubuntu.com
0416 0004 A827 6E40 BB98 90FB E8A4 8AE5 311D 765A



More information about the pkg-multimedia-maintainers mailing list