x264_0.120.2171+git01f7a33-2_amd64.changes ACCEPTED into unstable

Andres Mejia amejia004 at gmail.com
Mon Mar 19 12:41:56 UTC 2012


On Mon, Mar 19, 2012 at 4:48 AM, Fabian Greffrath <fabian at greffrath.com> wrote:
> Hi Andres,
>
> Am 17.03.2012 18:48, schrieb Debian FTP Masters:
>
>>   * Add hardened build flags excluding -O2 and -g.
>
>
> I don't quite get it. These packages already have dh compat 9 enabled and
> thus have the hardeneing build flags exported into their build environment.
> Why do you now explicitely set CFLAGS again, and while at it, ignore
> CPPFLAGS and LDFLAGS?
>
>  - Fabian
>
> _______________________________________________
> pkg-multimedia-maintainers mailing list
> pkg-multimedia-maintainers at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

x264 set -O3 by default. Us setting -O2 would have overridden that.
And with -g, x264 doesn't set -g by default (I presume because full
optimizations are enabled). Even so, x264 doesn't provide dbg packages
so there's no use in enabling -g anyway.

-- 
~ Andres



More information about the pkg-multimedia-maintainers mailing list