feedback for libdvdcss-pkg

[Fabian Greffrath]

Hi Dmitry,

and thanks for your work on this.

Am 20.09.2012 08:54, schrieb Dmitry Smirnov:
> Any ideas how it can be improved
> or it is technically ready for upload?

I just had a short look, but to me this looks overly complicated. Why 
do we have to download the sources and build them into a separate 
package and then install this one - all that mixed with debconf 
interaction? Why not download the sources, check integrity, compile 
them and install them - just like flashplugin-nonfree or 
ttf-mscorefonts-installer do?

Apart from this:

- Each mention of the word "illegal" *must* disappear!
- Please no leading commas in debian/control (cosmetic).
- You have both "dh_makeshlibs -V" in rules and a symbols file,
   that's redundant.
- Why did you modify the changelog? We already worked on libdvdcss
   packaging and have properly documented that in this file.
- We should maybe install NEWS as changelog.
- Symbol visibility support is now included upstream, we should
   include this patch instead.

  - Fabian