hello! I would like to join the pkg-multimedia team

[Sebastian Ramacher]

On 2014-02-12 22:10:36, Andrew Kelley wrote:
>  * I have libebur128 packaged up and ready to go into unstable over
> here: http://mentors.debian.net/package/libgroove
> The packaging repository is currently
> https://github.com/andrewrk/libebur128 with the debian/* files in the
> debian branch. I am happy to move this to a pkg-multimedia -sanctioned
> repository and use the master branch for debian/* files and upstream
> branch for upstream as the wiki suggests.

Here are some comments:

debian/copyright:
 - The Source field refers to the origin of the orig tarball, not the
   source of the copyright information. This should be
   https://github.com/jiixyj/libebur128 or with /tags.
 - Quoting CF 1.0: "There are many versions of the MIT license. Please
   use Expat instead, when it matches." Expat matches in your case.
 - What about your contribution in debian/*? Please add yourself and
   choose a license for it. It is often a good idea to use a license
   that is compatible with upstream's so that they can pick patches from
   Debian easily.
 - ebur128/queue/sys/queue.h has a different license than the rest. This
   needs to be documented.

debian/control:
 - debhelper does no longer use the X.Y.Z version scheme. Just use >= 9.
 - Standards-Version is now 3.9.5.
 - Why Priority: extra? Use optional if there is no good reason for
   extra.
 - There is no point in having ${shlibs:Depends} in libebur128-dev's
   Depends. Please remove it.
 - Section: libs in libebur128-1's paragraph is redundant. Please remove
   it.
 - Description needs some love. The short description is probably fine,
   but from the long description I would not understand what I'd need
   libebur128 for if I didn't know what EBU R128 loudness standard is.
   Please explain in a short bit what the EBU R128 loudness standard is
   and then you can list the implemented features. Please also look at
   §6.2 of the Developer's Reference ([1]).

There are warnings during the build:

dpkg-shlibdeps: warning: symbol tan used by debian/libebur128-1/usr/lib/libebur128.so.1.0.1 found in none of the libraries
dpkg-shlibdeps: warning: symbol pow used by debian/libebur128-1/usr/lib/libebur128.so.1.0.1 found in none of the libraries
dpkg-shlibdeps: warning: symbol log used by debian/libebur128-1/usr/lib/libebur128.so.1.0.1 found in none of the libraries

libebur128 needs to be linked against -lm.

Please install test/minimal_example.c as example in libebur128-dev. See
dh_installexamples(1).

Regards

[1] https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-control
-- 
Sebastian Ramacher
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20140213/0f3a3424/attachment.sig>