return of the mpalyer package?!

[Andreas Cadhalpun]

Hi,

On 16.07.2015 14:12, Miguel A. Colón Vélez wrote:
> On Thu, Jul 16, 2015 at 6:34 AM, Fabian Greffrath <fabian at debian.org> wrote:
>> has anyone seen this yet?
>>
>> https://ftp-master.debian.org/new/mplayer_2:1.1.1+r37401-1.html
>>
>> Does anyone know what is going on, has anyone been informed, has anyone
>> been contacted by the package maintainer or sponsor (CC:ed)?
>>
>> I mean, even if this package was removed from unstable and was not in
>> jessie, it is still a pkg-multimedia package, or not? So this tastes
>> like package hijack to me. Please clarify.
> 
> I saw the ITP on 2014-12-01 and contacted the person on IRC the same
> day (~2 weeks after the ITP).
> 
> micove> hello ... I'm from the debian multimedia team .... I was about
> to commit some changes to the git repo but I noticed that you had
> filed a ITP
> <micove> would you like to join the team?
> <frozencemetery> hi, nice to meet you.  Sure; I'd love to cooperate
> with you all!  This is my first debian package, so apologies if I'm a
> little slow on thing
> 
> He joined the #debian-multimedia channel since that day. My
> understanding was that he was going to formally join the team and help
> maintain the package under the team umbrella. I had not heard from him
> since that day so I assumed he was no longer interested in packaging
> MPlayer.

I think it would be best if Miguel and Robbie would co-maintain this
package under the umbrella of the pkg-multimedia team.
Robbie, if that's OK for you, please see [1] how to join the team.

> I was in contact with Reinhard and he had reviewed (not sure if he has
> seen the last 10 commits)
> http://anonscm.debian.org/cgit/pkg-multimedia/mplayer.git/log/?h=master.experimental
> 
> and seemed pleased with the packaging. I already finished all my
> changes as of 20 hours ago and since the transitional FFmpeg hit
> experimental a few hours ago it compiles with the new FFmpeg package
> names. Reinhard may have more information about the status of the
> package in the team.

debian/copyright misses a few files:
Files: vidix/sysdep/pci_sco.c
      vidix/sysdep/pci_os2.c
      vidix/sysdep/pci_mach386.c
      vidix/sysdep/pci_netbsd.c
      vidix/sysdep/pci_386bsd.c
      vidix/cyberblade_regs.h
      vidix/sysdep/pci_lynx.c
      vidix/sysdep/pci_isc.c
      vidix/sysdep/pci_svr4.c
      vidix/sysdep/pci_freebsd.c
      vidix/sysdep/pci_linux.c
      vidix/sysdep/pci_win32.c
      vidix/sysdep/pci_openbsd.c
License: ISC

Files: vidix/sysdep/libdha_os2.c
      vidix/unichrome_regs.h
License: Expat

debian/control:
You can use https for the homepage.
Maybe add a few build-dependencies for additional features:
 libcrystalhd-dev [i386 amd64],
 libopus-dev,
 librtmp-dev,

You can also drop the version requirement for libtheora-dev,
which is satisfied in oldoldstable.

Please multi-archify the package:
 * mencoder, mplayer, mplayer-gui, mplayer-doc -> Multi-Arch: foreign
 * mplayer-dbg -> Multi-Arch: same.

Finally, you should update the mplayer, mplayer-gui and mencoder Suggests:
ttf-freefont (transitional packgage) -> fonts-freefont-ttf

Otherwise it looks good. :-)

Best regards,
Andreas


1: https://wiki.debian.org/DebianMultimedia/Join