Packaging Advanced Gtk+ Sequencer v0.7.56

[IOhannes m zmölnig (Debian/GNU)]

On 08/29/2016 08:39 PM, Joël Krähemann wrote:
> On Mon, Aug 29, 2016 at 7:41 PM, IOhannes m zmölnig (Debian/GNU)
> <umlaeute at debian.org> wrote:
>>
>>
>> apart from that:
>> - the libags-1.0.pc seems weird: there are duplicate entries, and it
>> adds /usr/local/ paths to both include and library search paths. i'm
>> pretty sure that this is wrong.
>> it also adds include-paths and libraries for quite a number of graphic
>> libraries (from cairo to png) - i wonder whether they are really needed
>> to use libags.
>>
> The /usr/local paths doesn't happen to me it is probably a
> dh_auto_configure issue with your package builder:
> 
> prefix=/usr
> exec_prefix=${prefix}
> libdir=${prefix}/lib/x86_64-linux-gnu
> includedir=${prefix}/include

ah indeed, the problem was on my side (not the build, which was fine;
but one of the pkgconfig-dependencies got picked up from /usr/local
during runtime).

apart from that, i still think that there are way too many dependencies.
e.g. why is there an include <pango/pango.h> in X/machine/ags_ffplayer.h?
none of the pango-symbols are part of the public API of gsequencer-dev,
so there shouldn't be any need to have libpango-dev installed if i just
want to link against libgsequencer

> 
> And yes, libags-1.0.pc should rather be libgsequencer-0.7.pc

if so, then please fix it.

> 
>> - is there a specific reason to have the version encoded in library
>> names rather than the sonames (e.g. libags-1.0.so.0.0.0 rather than
>> libags.so.0.1.0)?
>>
> I just read this article:
> 
> https://autotools.io/libtool/version.html

i'm not sure i understand what you are trying to say here.
did you read simply this article, and then decided to use
libtags-1.0.so.0.0.0? or did you read this article recently, after i
complained?

i find a very good introduction to semantic versioning is http://semver.org/

> 
> I fix this upstream so I'll provide a new package gsequencer-0.7.58.tar.gz

thanks.

gfmdsar
IOhannes

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-multimedia-maintainers/attachments/20160829/273ca7b6/attachment-0001.sig>