Bug#901452: jack-midi-clock FTCBFS: upstream Makefile hard codes build architecture pkg-config

[Helmut Grohne]

Source: jack-midi-clock
Version: 0.4.3-1
Tags: patch
User: helmutg at debian.org
Usertags: rebootstrap

jack-midi-clock fails to cross build from source, because the upstream
Makefile hard codes the build architecture pkg-config. After making it
substitutable, it still fails, because dh_auto_clean does not pass cross
tools and that's fatal to the Makefile. Using dpkg's buildtools.mk, we
can export cross tools for all targets and that makes jack-midi-clock
cross buildable. Please consider applying the attached patch.

Helmut
-------------- next part --------------
diff --minimal -Nru jack-midi-clock-0.4.3/debian/changelog jack-midi-clock-0.4.3/debian/changelog
--- jack-midi-clock-0.4.3/debian/changelog	2016-10-01 23:39:20.000000000 +0200
+++ jack-midi-clock-0.4.3/debian/changelog	2018-06-13 16:03:03.000000000 +0200
@@ -1,3 +1,12 @@
+jack-midi-clock (0.4.3-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: (Closes: #-1)
+    + cross.patch: Make pkg-config substitutable.
+    + Use dpkg's buildtools.mk to pass cross tools for all targets.
+
+ -- Helmut Grohne <helmut at subdivi.de>  Wed, 13 Jun 2018 16:03:03 +0200
+
 jack-midi-clock (0.4.3-1) unstable; urgency=medium
 
   * New upstream version 0.4.3 (Closes: #839315)
diff --minimal -Nru jack-midi-clock-0.4.3/debian/patches/cross.patch jack-midi-clock-0.4.3/debian/patches/cross.patch
--- jack-midi-clock-0.4.3/debian/patches/cross.patch	1970-01-01 01:00:00.000000000 +0100
+++ jack-midi-clock-0.4.3/debian/patches/cross.patch	2018-06-13 16:03:03.000000000 +0200
@@ -0,0 +1,28 @@
+--- jack-midi-clock-0.4.3.orig/Makefile
++++ jack-midi-clock-0.4.3/Makefile
+@@ -2,12 +2,13 @@
+ bindir ?= $(PREFIX)/bin
+ mandir ?= $(PREFIX)/share/man
+ 
++PKG_CONFIG ?= pkg-config
+ CFLAGS ?= -Wall -O3
+ VERSION?=$(shell (git describe --tags HEAD 2>/dev/null || echo "v0.4.3") | sed 's/^v//')
+ 
+ ###############################################################################
+ 
+-ifeq ($(shell pkg-config --exists jack || echo no), no)
++ifeq ($(shell $(PKG_CONFIG) --exists jack || echo no), no)
+   $(warning *** libjack from http://jackaudio.org is required)
+   $(error   Please install libjack-dev, libjack-jackd2-dev)
+ endif
+@@ -16,8 +17,8 @@
+ 
+ override CFLAGS += -DWITH_JITTER
+ override CFLAGS += -DVERSION="\"$(VERSION)\""
+-override CFLAGS += `pkg-config --cflags jack`
+-LOADLIBES = `pkg-config --cflags --libs jack` -lm -lpthread
++override CFLAGS += `$(PKG_CONFIG) --cflags jack`
++LOADLIBES = `$(PKG_CONFIG) --cflags --libs jack` -lm -lpthread
+ man1dir   = $(mandir)/man1
+ 
+ ###############################################################################
diff --minimal -Nru jack-midi-clock-0.4.3/debian/patches/series jack-midi-clock-0.4.3/debian/patches/series
--- jack-midi-clock-0.4.3/debian/patches/series	2016-10-01 22:05:16.000000000 +0200
+++ jack-midi-clock-0.4.3/debian/patches/series	2018-06-13 16:02:43.000000000 +0200
@@ -1 +1,2 @@
 01-fix_prefix.patch
+cross.patch
diff --minimal -Nru jack-midi-clock-0.4.3/debian/rules jack-midi-clock-0.4.3/debian/rules
--- jack-midi-clock-0.4.3/debian/rules	2016-10-01 23:39:20.000000000 +0200
+++ jack-midi-clock-0.4.3/debian/rules	2018-06-13 16:03:03.000000000 +0200
@@ -1,6 +1,9 @@
 #!/usr/bin/make -f
 # -*- makefile -*-
 
+export DPKG_EXPORT_BUILDTOOLS=1
+-include /usr/share/dpkg/buildtools.mk
+
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 
 %: