<div dir="ltr">pushed changes to git.d.o<div>thanks lars</div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Sep 30, 2015 at 3:04 PM Lars Tangvald <<a href="mailto:lars.tangvald@oracle.com">lars.tangvald@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
The necessary flags should be provided by upstream's cmake config,
so I'd simply remove the two lines overriding CMAKE_C_FLAGS and
CMAKE_CXX_FLAGS from debian/rules.<br>
It's difficult to maintain, hard to find issues (no-exceptions
should have been removed 4 years ago, BIG_JOINS no longer exists,
etc), and using a different build setup than upstream could also
bring unforeseen issues.<br>
<br>
--<br>
Lars</div><div text="#000000" bgcolor="#FFFFFF"><br>
<br>
<div>On 09/30/2015 11:18 AM, Bjoern Boschman
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div>Hi Lars,</div>
<div><br>
</div>
so currently there are:
<div>-O3 -DBIG_JOINS=1 -felide-constructors -fno-exceptions
-fpermissive -fno-rtti -fPIC -fno-strict-aliasing<br>
</div>
<div>I'd drop <span style="line-height:1.5">-fno-exceptions and </span><span style="line-height:1.5">-fno-rtti. which other would you
suggest to drop?</span></div>
<div><span style="line-height:1.5"><br>
</span></div>
<div><span style="line-height:1.5">Cheers</span></div>
<div><span style="line-height:1.5">B</span></div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Sep 29, 2015 at 10:40 AM Lars Tangvald
<<a href="mailto:lars.tangvald@oracle.com" target="_blank">lars.tangvald@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> Upstream, this was
actually changed in 5.6.4, for MySQL worklog #5825:<br>
<a href="http://dev.mysql.com/worklog/task/?id=5825" target="_blank">http://dev.mysql.com/worklog/task/?id=5825</a><br>
Accompanying commit:<br>
<span style="font-weight:bold;color:#cc0000"> </span><a href="https://github.com/mysql/mysql-server/commit/a5ee7278a16a6a5e6e90c56c13fdda7f6f30ebad" target="_blank"><a href="https://github.com/mysql/mysql-server/commit/a5ee7278a16a6a5e6e90c56c13fdda7f6f30ebad" target="_blank">https://github.com/mysql/mysql-server/commit/a5ee7278a16a6a5e6e90c56c13fdda7f6f30ebad</a></a><br>
<br>
So the flags should probably just be removed. From what I
can see this actually applies to the other flags as well.
They all seem to be outdated.<br>
<br>
The commit causing the compile error:<br>
<a href="https://github.com/mysql/mysql-server/commit/0ff896b063916e46d3ab175594f5507756c08adb" target="_blank">https://github.com/mysql/mysql-server/commit/0ff896b063916e46d3ab175594f5507756c08adb</a><br>
<br>
<br>
--<br>
Lars</div>
<div text="#000000" bgcolor="#FFFFFF"><br>
<br>
<div>On 09/29/2015 08:20 AM, Lars Tangvald wrote:<br>
</div>
<blockquote type="cite"> Also note that both no-exceptions
and no-rtti will cause compile errors with MySQL 5.7.8. I
don't see much reason to keep either flag, as I assume
they're just holdovers from optimizations of old versions?<br>
<br>
--<br>
Lars<br>
<br>
<br>
<div>On 09/28/2015 06:25 PM, Bjoern Boschman wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi,
<div><br>
</div>
<div>while compiling 5.6.26 I got the following error:</div>
<div><br>
</div>
<div>
<div>cd
/home/jesusch/git/mysql/mysql-5.6/builddir/plugin/password_validation
&& /usr/bin/x86_64-linux-gnu-g++ Â
-DHAVE_CONFIG_H -DMYSQL_DYNAMIC_PLUGIN
-D_FORTIFY_SOURCE=2 -Dvalidate_password_EXPORTS
-O3 -DBIG_JOINS=1 -felide-constructors
-fno-exceptions -fpermissive -fno-rtti
 -fno-strict-aliasing  -Wall -Wextra
-Wformat-security -Wvla -Woverloaded-virtual
-Wno-unused-parameter -O3 -g -fabi-version=2
-fno-omit-frame-pointer -fno-strict-aliasing
-DDBUG_OFF -fPIC
-I/home/jesusch/git/mysql/mysql-5.6/builddir/include
-I/home/jesusch/git/mysql/mysql-5.6/include
-I/home/jesusch/git/mysql/mysql-5.6/sql
-I/home/jesusch/git/mysql/mysql-5.6/regex
-I/home/jesusch/git/mysql/mysql-5.6/extra/yassl/include
-I/home/jesusch/git/mysql/mysql-5.6/extra/yassl/taocrypt/include
  -o
CMakeFiles/validate_password.dir/validate_password.cc.o
-c
/home/jesusch/git/mysql/mysql-5.6/plugin/passwor</div>
<div>d_validation/validate_password.cc</div>
<div>/home/jesusch/git/mysql/mysql-5.6/plugin/password_validation/validate_password.cc:
In function ‘void read_dictionary_file()’:</div>
<div>/home/jesusch/git/mysql/mysql-5.6/plugin/password_validation/validate_password.cc:183:10:
error: exception handling disabled, use
-fexceptions to enable</div>
</div>
<div><br>
</div>
<div>Is there any reason why we
have CXXFLAGS="... -fno-exceptions"?</div>
<div><br>
</div>
<div>Cheers</div>
<div>B</div>
</div>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
pkg-mysql-maint mailing list
<a href="mailto:pkg-mysql-maint@lists.alioth.debian.org" target="_blank">pkg-mysql-maint@lists.alioth.debian.org</a>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint</a></pre>
</blockquote>
<br>
<br>
<fieldset></fieldset>
<br>
<pre>_______________________________________________
pkg-mysql-maint mailing list
<a href="mailto:pkg-mysql-maint@lists.alioth.debian.org" target="_blank">pkg-mysql-maint@lists.alioth.debian.org</a>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint</a></pre>
</blockquote>
<br>
</div>
_______________________________________________<br>
pkg-mysql-maint mailing list<br>
<a href="mailto:pkg-mysql-maint@lists.alioth.debian.org" target="_blank">pkg-mysql-maint@lists.alioth.debian.org</a><br>
<a href="http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint" rel="noreferrer" target="_blank">http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-mysql-maint</a></blockquote>
</div>
</blockquote>
<br>
</div></blockquote></div>