[Pkg-mythtv-maintainers] Bug#416855: FTBFS with GCC 4.3: the meaning of "inline" changed in C99

[Martin Michlmayr]

Package: twolame
Version: 0.3.9-1
Usertags: ftbfs-gcc-4.3
Tags: patch

Your package fails to build with GCC 4.3.  Version 4.3 has not been
released yet but I'm building with a snapshot in order to find errors
and give people an advance warning.  In C99 the meaning of "inline"
changed, see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=31389
A patch for this problem is below.

> Automatic build of twolame_0.3.9-1 on coconut0 by sbuild/ia64 0.49
...
>  cc -DHAVE_CONFIG_H -I. -I. -I../build -I ../build/ -g -Wall -O2 -std=c99 -Wunused -Wall -O3 -c crc.c  -fPIC -DPIC -o .libs/crc.o
> bitbuffer.h:44: warning: inline function 'buffer_putbits' declared but never defined
> bitbuffer.h:44: warning: inline function 'buffer_putbits' declared but never defined
...
> mkdir .libs
> cc -I../build/ -I../libtwolame/ -g -Wall -O2 -std=c99 -Wunused -Wall -O3 -o .libs/twolame frontend.o  /usr/lib/libsndfile.so /usr/lib/libFLAC.so ../libtwolame/.libs/libtwolame.so -lm
> ../libtwolame/.libs/libtwolame.so: undefined reference to `buffer_putbits'
> collect2: ld returned 1 exit status
> make[2]: *** [twolame] Error 1

--- libtwolame/common.h~	2007-03-30 20:07:53.000000000 +0000
+++ libtwolame/common.h	2007-03-30 20:08:10.000000000 +0000
@@ -33,7 +33,7 @@
 #define NO_DLL_INLINE
 #else
 #include "config.h"
-#define NO_DLL_INLINE inline
+#define NO_DLL_INLINE extern inline
 #endif
 
 

-- 
Martin Michlmayr
http://www.cyrius.com/