Bug#284897: [Pkg-nagios-devel] Bug#284897: support for non ascii characters in notifications

[sean finney]

--rwEMma7ioTxnRzrJ
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

(note, this is my second time posting, i'm now subscribed)

hi there,

i'm one of the debian developers responsible for maintaining the current
nagios packages.  we recently had a bug report from a non-english
speaking user who had characters disappearing from his notifications and
acknowledgements. =20

while some of these were directly from a config option on his server
(illegal_macro_chars), he also experienced high ascii characters being
removed as well (including characters such as =E9, =E0, etc).  i took a
look through the source code and found the location where this was
being done, which is attached in the excerpt below.

my question is, would it be possible to not strip these high-ascii
characters (either by default or via a config option) or otherwise
provide support for non-ascii charsets?

for the full bug report, please see:

http://bugs.debian.org/284897

any feedback welcome.

also, i see that nagios 2.0 is now out in beta!  keep up the good work!


thanks,
	sean

ps - please keep the cc: in all replies, they will that way be attached
     to the bug report for posterity

----- Forwarded message from sean finney <seanius@debian.org> -----

Date: Thu, 16 Dec 2004 11:58:23 -0500
=46rom: sean finney <seanius@debian.org>
To: alet@unice.fr
Subject: Re: Bug#284897: [Pkg-nagios-devel] Bug#284897: nagios-pgsql: nagio=
s eats single quotes in problem acknowledgement email messages

severity 284897 wishlist
tags 284897 upstream
thanks

hi jerome,

i'll forward this request to the upstream nagios development list for comme=
nt.

	sean

On Thu, Dec 16, 2004 at 10:27:30AM +0100, alet@unice.fr wrote:
> Hi,
>=20
> On Thu, Dec 16, 2004 at 01:54:53AM -0500, sean finney wrote:
> >=20
> > also, in the nagios source, it strips out any ascii characters greater
> > than decimal 166:
> >=20
> >                         /* illegal ASCII characters */
> >                         if(ch<32 || ch=3D=3D127)
> >                                 continue;
>=20
> ok
>=20
> >                         /* illegal extended ASCII characters */
> >                         if(ch>=3D166)
> >                                 continue;
>=20
> this one sucks big time for non-english people !
>=20
> what about using unicode strings ?
<snip>
> the problem is that the string is NOT the result of a command,
> but a comment typed in by the particular nagios admin for the=20
> service problem being acknowledged.
>=20
> while I understand the security problem which may occur, I think
> that access to nagios should be reserved to trusted people anyway,
> so allowing them to type "unsafe" characters in their own
> native language would be a great bonus...


	sean
--=20



----- End forwarded message -----

--=20

--rwEMma7ioTxnRzrJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBx6AVynjLPm522B0RAnqQAJ43AOJCGKtSCoBqrLEjFZz3I6VTEQCghm3H
c/t6OqOABArCsPz2H4KGQ8Y=
=HbO0
-----END PGP SIGNATURE-----

--rwEMma7ioTxnRzrJ--