[Pkg-nagios-devel] Bug#352652: nagios-plugins: Does never report state OK but state unknown

[Patrik Schindler]

Package: nagios-plugins
Version: 1.4-6
Severity: important
Tags: patch


check_mrtgtraf could never exit with STATE_OK, because status is defined
as STATE_UNKNOWN on top but will only be changed to critical or
warning when looking at thresholds.

Appended Patch will fix this.


--- check_mrtgtraf.c.orig	2006-02-13 09:50:52.000000000 +0100
+++ check_mrtgtraf.c	2006-02-13 09:50:34.000000000 +0100
@@ -173,6 +173,13 @@
 					 || outgoing_rate > outgoing_warning_threshold) {
 		result = STATE_WARNING;
 	}
+	else if ( ( incoming_rate <= incoming_critical_threshold
+			|| outgoing_rate <= outgoing_critical_threshold )
+			&&
+			( incoming_rate <= incoming_warning_threshold
+			|| outgoing_rate <= outgoing_warning_threshold )) {
+		result = STATE_OK;
+	}
 
 	asprintf (&error_message, _("%s. In = %0.1f %s, %s. Out = %0.1f %s|%s %s\n"),
 	          (use_average == TRUE) ? _("Avg") : _("Max"), adjusted_incoming_rate,

-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.4.32.leitrix051215
Locale: LANG=de_DE at euro, LC_CTYPE=de_DE at euro (charmap=ISO-8859-15)

Versions of packages nagios-plugins depends on:
ii  dnsutils         1:9.2.4-1               Clients provided with BIND
ii  fping            2.4b2-to-ipv6-10        sends ICMP ECHO_REQUEST packets to
ii  host             20000331-9              utility for querying DNS servers
ii  iputils-ping     3:20020927-2            Tools to test the reachability of 
ii  libc6            2.3.2.ds1-22            GNU C Library: Shared libraries an
ii  libldap2         2.1.30-8                OpenLDAP libraries
ii  libmysqlclient12 4.0.24-10sarge1         mysql database client library
ii  libnet-snmp-perl 5.0.1-1                 Script SNMP connections
ii  libpq3           7.4.7-6sarge1           PostgreSQL C client library
ii  libssl0.9.7      0.9.7e-3sarge1          SSL shared libraries
ii  ntp              1:4.2.0a+stable-2sarge1 Network Time Protocol: network uti
ii  ntp-simple       1:4.2.0a+stable-2sarge1 Network Time Protocol: daemon for 
ii  ntpdate          1:4.2.0a+stable-2sarge1 The ntpdate client for setting sys
ii  procps           1:3.2.1-2               The /proc file system utilities
ii  qstat            2.8-1                   Command-line tool for querying qua
ii  radiusclient1    0.3.2-8                 /bin/login replacement which uses 
ii  smbclient        3.0.14a-3sarge1         a LanManager-like simple client fo
ii  snmp             5.1.2-6.2               NET SNMP (Simple Network Managemen

-- no debconf information