[Pkg-nagios-devel] Bug#721621: Bug#721621: dependency change s/libradiusclient-ng2/libfreeradius-client2

[Jan Wagner]

forwarded 721621 https://github.com/monitoring-plugins/monitoring-plugins/issues/1231
tags 721621 + upstream
thanks

Hi Daniel,

Am 02.02.2014 12:25, schrieb Daniel Pocock:
> On 02/02/14 12:09, Jan Wagner wrote:
>> I discovered that this is not a drop-in replacement and thus
>> nagios-plugins-standard has unfortunately no check_radius shipped. As
>> upstream is not supporting this right now, this has to be implemented
>> first to switch over to libfreeradius-client2.
>>
>> To fix this for now, I'm falling back to libradiusclient-ng2 until we
>> get support for libfreeradius-client2.
>>
> 
> libradiusclient-ng2 may well be orphaned and removed from jessie
> 
> Please have a look at the patch we applied on the Asterisk package to
> use freeradius-client, it is very trivial

I applied the attached patch to the upstream source.

Unfortunately it does not compile clean when building against libfreeradius-client2:

i486-linux-gnu-gcc -DLOCALEDIR=\"/usr/share/locale\" -DHAVE_CONFIG_H -I. -I.. -I.. -I../lib -I../gl -I../intl -I/usr/include/ldap -I/usr/include/postgresql -I/usr/include   -DNP_VERSION='"1.5"' -Wall -g -O2 -MT check_radius.o -MD -MP -MF .deps/check_radius.Tpo -c -o check_radius.o check_radius.c
check_radius.c: In function 'main':
check_radius.c:148:2: error: unknown type name 'UINT4'
  UINT4 service;
  ^
check_radius.c:152:2: error: unknown type name 'UINT4'
  UINT4 client_id;
  ^
check_radius.c:196:2: warning: passing argument 6 of 'rc_buildreq' makes pointer from integer without a cast [enabled by default]
  my_rc_buildreq (&data, PW_ACCESS_REQUEST, server, port, (int)timeout_interval,
  ^
In file included from check_radius.c:43:0:
/usr/include/freeradius-client.h:428:6: note: expected 'char *' but argument is of type 'int'
 void rc_buildreq(rc_handle *, SEND_DATA *, int, char *, unsigned short, char *, int, int);
      ^
check_radius.c:196:2: error: too few arguments to function 'rc_buildreq'
  my_rc_buildreq (&data, PW_ACCESS_REQUEST, server, port, (int)timeout_interval,
  ^
In file included from check_radius.c:43:0:
/usr/include/freeradius-client.h:428:6: note: declared here
 void rc_buildreq(rc_handle *, SEND_DATA *, int, char *, unsigned short, char *, int, int);
      ^

As I'm not familiar with this radius specific part, this should be
investigated deeper and I reported this bug upstream. Anyways,
patches are welcome.

Cheers, Jan.
-- 
Never write mail to <waja at spamfalle.info>, you have been warned!
-----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GIT d-- s+: a C+++ UL++++ P+ L+++ E--- W+++ N+++ o++ K++ w--- O M V- PS PE Y++
PGP++ t-- 5 X R tv- b+ DI D+ G++ e++ h---- r+++ y++++ 
------END GEEK CODE BLOCK------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: freeradius.patch
Type: text/x-patch
Size: 4490 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-nagios-devel/attachments/20140202/156682da/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-nagios-devel/attachments/20140202/156682da/attachment.sig>