[Pkg-netsim-devel] Comments regarding ns2_2.35+dfsg-1_kfreebsd-amd64.changes

[Alexander Reichle-Schmehl]

Hi maintainer(s)!

I'm going to accept your package, but our tireless ftp trainee found some
smaller issues with your package you might want to address in a future
upload:

=========

A couple of notes, however:

* debian/pathces/0001-*:

  Patches makefile to include another dependency for the install
  target. This could easily be accomplished by calling both targets
  from debian/rules instead.

  Though, the patch has the advantage of being possible to send
  upstream.

* debian/patches/0002-*:

  Doesn't explain wtf is being done, and the patch name appears to
  bear no relation to what it actually does.

* debian/patches/*: The metadata on all patches is poor at best, the
  subject is most often the patch name, and no explanation is given
  why a given change is being applied.

* debian/copyright:

  It says that the Debian packaging is under the GPLv3, yet, there is
  at least one file under debian/ that are definitely not GPL:
  cmake/FindPCAP.cmake is BSD-3.

* doc/everything.pdf:

  We have the source, but do not rebuild the pdf. That's ok, but was
  worth a note nevertheless.

* debian/rules: The dfsg-orig target should really be get-orig-source
  (and tuned up a little, too).

=========


Best regards,
  Alexander