[pkg-nvidia-devel] Bug#582550: nvidia-glx-legacy-71xx: Please add LSB formatted dependency info in init.d script

[Petter Reinholdtsen]

Package:  nvidia-glx-legacy-71xx
Version:  1.0.4363-1
Severity: serious
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: missing-dependency

This package is missing the LSB style headers with dependency
information.  This patch add it.  I am not quite sure if the
dependencies are correct and complete, so please review it.

<URL:http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html>
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts/DependencyBasedBoot >.

The severity of this issue is serious, because with the new parallel
execution of init.d scripts, this init.d script might start after the
display manager is started, which I believe will make this package
fail.

--- nvidia-graphics-drivers-legacy-71xx-71.86.13/debian/nvidia-glx-legacy-71xx.init.in    2010-05-21 20:29:08.000000000 +0200
+++ nvidia-graphics-drivers-legacy-71xx-71.86.13-pere/debian/nvidia-glx-legacy-71xx.init.in       2010-05-21 20:30:22.000000000 +0200
@@ -1,5 +1,17 @@
 #!/bin/sh

+### BEGIN INIT INFO
+# Provides:          nvidia-glx-legacy-71xx
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
+# X-Start-Before:    $x-display-manager xdm kdm gdm sdm wdm nodm ldm
+# X-Stop-After:      $x-display-manager xdm kdm gdm sdm wdm nodm ldm
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
+# Short-Description: NVidia X driver initialization
+# Description:       Load kernel drivers needed for the NVidia video cards
+### END INIT INFO
+
 PATH=/sbin:/usr/sbin:/usr/local/sbin:/bin:/usr/bin:/usr/local/bin
 VERSION="#VERSION#"

The $x-display-manager virtual facility is not handled by all display
managers yet, so I list them all individually too to make sure the
script is inserted before the scripts not yet providing the
$x-display-manager facility.

Happy hacking,
-- 
Petter Reinholdtsen