Bug#686262: [RFR] templates://nvidia-support/{nvidia-support.templates, nvidia-installer-cleanup.templates, control}

[David Prévot]

Hi,

Please find, for review, the debconf templates and packages descriptions
for the nvidia-support source package.

This review will last from Thursday, August 30, 2012 to Friday,
September 7, 2012.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, a summary will be sent to the review bug report,
and a mail will be sent to this list with "[BTS]" as a subject tag.

Rationale:

> --- a/nvidia-installer-cleanup.templates
> +++ b/nvidia-installer-cleanup.templates
> @@ -3,8 +3,8 @@ Type: boolean
>  Default: true
>  _Description: Run "nvidia-installer --uninstall"?
>   The nvidia-installer program was found on this system. This is
> - probably left over from an earlier installation of the non-free Nvidia
> - graphics driver, installed using the Nvidia *.run file directly. This
> + probably left over from an earlier installation of the non-free NVIDIA
> + graphics driver, installed using the NVIDIA *.run file directly. This
>   installation is incompatible with the Debian packages. To install the
>   Debian packages safely, it is therefore necessary to undo the changes
>   performed by nvidia-installer.

s/Nvidia/NVIDIA/g for consistency

> --- a/nvidia-support.templates
> +++ b/nvidia-support.templates
> @@ -63,7 +63,7 @@ _Description: Nvidia driver is still enabled in xorg.conf
>  Template: nvidia-support/create-nvidia-conf
>  Type: boolean
>  Default: true
> -Description: Create a minimal Xorg configuration to enable NVIDIA?
> +_Description: Create a minimal Xorg configuration to enable NVIDIA?
>   The NVIDIA Xorg driver that was just installed requires manual configuration
>   to be activated.
>   .

Make template translatable by prepending "_" (the actual reason while
I've spotted this package).


Other members of the list may have other remarks and improvements to
propose, thus this formal call for review.

Thanks in advance.

Regards

David

-------------- next part --------------
A non-text attachment was scrubbed...
Name: nvidia.patch
Type: text/x-diff
Size: 3959 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-nvidia-devel/attachments/20120830/21dd5b6c/attachment-0001.patch>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nvidia-installer-cleanup.templates
URL: <http://lists.alioth.debian.org/pipermail/pkg-nvidia-devel/attachments/20120830/21dd5b6c/attachment-0003.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nvidia-support.templates
URL: <http://lists.alioth.debian.org/pipermail/pkg-nvidia-devel/attachments/20120830/21dd5b6c/attachment-0004.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: nvidia-support.control
URL: <http://lists.alioth.debian.org/pipermail/pkg-nvidia-devel/attachments/20120830/21dd5b6c/attachment-0005.ksh>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-nvidia-devel/attachments/20120830/21dd5b6c/attachment-0001.pgp>