[Pkg-octave-devel] Bug#684930: unblock (pre-approval): octave/3.6.2-5

[Adam D. Barratt]

Control: tags -1 -moreinfo +confirmed

On Sat, 2012-08-18 at 14:17 +0200, Sébastien Villemot wrote:
> Rafael Laboissiere <rafael at laboissiere.net> writes:
> > * Adam D. Barratt <adam at adam-barratt.org.uk> [2012-08-16 22:13]:
> >> +--- a/src/mkoctfile.in
> >> ++++ b/src/mkoctfile.in
> >> +@@ -77,7 +77,7 @@
> >> [...]
> >> +-: ${XTRA_CXXFLAGS=%OCTAVE_CONF_XTRA_CXXFLAGS%}
> >> ++: ${XTRA_CXXFLAGS=-I/usr/include/mpi %OCTAVE_CONF_XTRA_CXXFLAGS%}
> >> 
> >> Does this have any side-effects in the case where the MPI variant wasn't
> >> installed?
> 
> AFAIK, it does not. mkoctfile being essentially a wrapper around gcc,
> this change results in an additional -I flag on GCC command line. When
> /usr/include/mpi does not exists, this has no effect. If
> /usr/include/mpi exists but libhdf5-{openmpi,mpich2}-dev is not
> installed, it should not have any effect either, because Octave files
> don't include MPI headers.

Okay; thanks.  Please go ahead with the upload and let us know once it's
been accepted.

Regards,

Adam