[Pkg-octave-devel] Bug#681064: Bug#681064: Bug#681064: octave: does not configure properly
Rafael Laboissiere
rafael at laboissiere.net
Wed Jul 11 17:58:43 UTC 2012
* Jordi Gutiérrez Hermoso <jordigh at octave.org> [2012-07-11 13:02]:
> On 11 July 2012 12:44, Rafael Laboissiere <rafael at laboissiere.net> wrote:
> > At any rate, the following is a reproducible bug:
> >
> > $ sudo rmdir /usr/share/octave/packages/
> > $ sudo octave --silent --no-history --no-init-file --no-window-system --eval "pkg ('rebuild');"
> > error: could not find the file or path /usr/share/octave/packages
> > error: called from:
> > error: /usr/share/octave/3.6.2/m/pkg/pkg.m at line 1234, column 5
> > error: /usr/share/octave/3.6.2/m/pkg/pkg.m at line 418, column 16
> > error: /usr/share/octave/3.6.2/m/startup/octaverc at line 26, column 1
> [snip]
> > For fixing the bug, I propose the patch attached below, that changes the
> > code in pkg.m.
>
> I'm not sure the fix in the catch block is right. What if creating the
> directory fails? Or do we know at that point that this is a writable
> location?
Well, in pkg.m we have already this:
try
archprefix = absolute_pathname (archprefix);
catch
mkdir (archprefix);
warning ("creating the directory %s\n", archprefix);
archprefix = absolute_pathname (archprefix);
end_try_catch
My fix regarding the "prefix" variable was inspired in the code above.
Your criticisms would also apply to this.
BTW, should we move this discussion to the octave-maintainers mailing
list?
Rafael
More information about the Pkg-octave-devel
mailing list