[Pkg-ofed-commits] [mstflint] 02/02: Disable -Werror compiler flag

Benjamin Drung bdrung at moszumanska.debian.org
Fri Aug 19 13:38:48 UTC 2016


This is an automated email from the git hooks/post-receive script.

bdrung pushed a commit to branch master
in repository mstflint.

commit b0cde150e98a859cfa097a1e134e621016d6684d
Author: Benjamin Drung <benjamin.drung at profitbricks.com>
Date:   Fri Aug 19 15:35:54 2016 +0200

    Disable -Werror compiler flag
    
    The -Werror compiler flag converts warnings into errors, so that warnings
    will cause the package build to fail. The -Werror option is useful for the
    upstream maintainer to keep the code clean, but is not recommended for
    packaging, because it might break the package if we upgrade the compiler
    to a new release.
    
    The configure script should gain an option to enable or disable -Werror.
    In the meantime just remove -Werror everywhere.
---
 debian/patches/disable-werror.patch | 68 +++++++++++++++++++++++++++++++++++++
 debian/patches/series               |  1 +
 2 files changed, 69 insertions(+)

diff --git a/debian/patches/disable-werror.patch b/debian/patches/disable-werror.patch
new file mode 100644
index 0000000..1c59eb3
--- /dev/null
+++ b/debian/patches/disable-werror.patch
@@ -0,0 +1,68 @@
+Description: Disable -Werror compiler flag
+ The -Werror compiler flag converts warnings into errors, so that warnings
+ will cause the package build to fail. The -Werror option is useful for the
+ upstream maintainer to keep the code clean, but is not recommended for
+ packaging, because it might break the package if we upgrade the compiler
+ to a new release.
+ .
+ The configure script should gain an option to enable or disable -Werror.
+ In the meantime just remove -Werror everywhere.
+Author: Benjamin Drung <benjamin.drung at profitbricks.com>
+
+--- a/cmdif/Makefile.am
++++ b/cmdif/Makefile.am
+@@ -36,7 +36,7 @@
+ TOOLS_LAYOUTS_DIR = $(USER_DIR)/tools_layouts
+ AM_CPPFLAGS = -I. -I../common -I../tools_layouts  -I$(MTCR_DIR) -I.. -I$(USER_DIR)/mtcr_ul
+ 
+-AM_CFLAGS = -W -Wall -Werror -g -MP -MD $(COMPILER_FPIC) -DCMDIF_EXPORTS
++AM_CFLAGS = -W -Wall -g -MP -MD $(COMPILER_FPIC) -DCMDIF_EXPORTS
+ CMDIF_VERSION = 1
+ noinst_LIBRARIES = libcmdif.a
+ 
+--- a/configure.ac
++++ b/configure.ac
+@@ -77,8 +77,8 @@
+   LDFLAGS="$LDFLAGS -Wl,--dynamic-linker=/lib64/ld64.so.2"
+ ])
+ 
+-CFLAGS="$CFLAGS -Werror -DMST_UL"
+-CXXFLAGS="$CXXFLAGS -Werror -DMST_UL"
++CFLAGS="$CFLAGS -DMST_UL"
++CXXFLAGS="$CXXFLAGS -DMST_UL"
+ 
+ AC_CONFIG_FILES( mstflint.spec )
+ 
+--- a/mft_utils/Makefile.am
++++ b/mft_utils/Makefile.am
+@@ -34,7 +34,7 @@
+ USER_DIR = $(top_srcdir)
+ AM_CPPFLAGS = -I. -I$(USER_DIR)/common
+ 
+-AM_CFLAGS = -MD -pipe -Wall -W -Werror
++AM_CFLAGS = -MD -pipe -Wall -W
+ 
+ noinst_HEADERS = mft_sig_handler.h errmsg.h
+ 
+--- a/reg_access/Makefile.am
++++ b/reg_access/Makefile.am
+@@ -38,7 +38,7 @@
+ 
+ AM_CPPFLAGS = -I. -I$(USER_DIR) -I$(srcdir) -I$(LAYOUTS_DIR) -I$(USER_DIR)/include/mtcr_ul
+ 
+-AM_CFLAGS = -W -Wall -Werror -g -MP -MD $(COMPILER_FPIC)
++AM_CFLAGS = -W -Wall -g -MP -MD $(COMPILER_FPIC)
+ 
+ noinst_LTLIBRARIES = libreg_access.a
+ 
+--- a/tools_res_mgmt/Makefile.am
++++ b/tools_res_mgmt/Makefile.am
+@@ -35,7 +35,7 @@
+ MTCR_DIR = $(USER_DIR)/include/mtcr_ul
+ AM_CPPFLAGS = -I. -I../common -I$(MTCR_DIR) -I.. -I$(USER_DIR)/mtcr_ul
+ 
+-AM_CFLAGS = -W -Wall -Werror -g -MP -MD $(COMPILER_FPIC) 
++AM_CFLAGS = -W -Wall -g -MP -MD $(COMPILER_FPIC)
+ noinst_LIBRARIES = libtools_res_mgmt.a
+ 
+ libtools_res_mgmt_a_SOURCES = tools_res_mgmt.c tools_time.c
diff --git a/debian/patches/series b/debian/patches/series
index 70ee3bf..5c80cec 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -6,3 +6,4 @@
 0006-Fix-man-page-errors.patch
 0007-Pass-foreign-to-automake.patch
 Fix-compilation-on-unknown-architectures.patch
+disable-werror.patch

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-ofed/mstflint.git



More information about the Pkg-ofed-commits mailing list