Bug#369484: [Pkg-openldap-devel] Bug#369484: slapd: Bug in initscript, could wreck database

[Torsten Landschoff]

Hi Helge, 

On Tue, May 30, 2006 at 11:43:38AM +0200, Helge Hafting wrote:
> >(b) OpenLDAP 2.3 already has a file (alock) that determines whether or 
> >not recover should be performed.  In no case should an init script be 
> >calling db_recover itself.  If that is the case, the init script is 
> >horribly broken.
> >
> Either way, the slapd package needs fixing.  What I saw was clearly wrong,
> the script ran 'pidof'  against a nonexistant filename.  So I tried to
> fix that.  Of course my simple fix doesn't help if what the script tries to
> do is wrong anyway.  I do not know the details of slapd & bdb,
> I assumed the comments were accurate with just an implementation error.
> I am now looking forward for the proper fix, which I don't know
> enough to make myself.
 
This db_recover call was in there because many people asked for it as
they discovered they had to run it manually to get slapd working again. 
Somehow the database behind OpenLDAP broke for many people. After a lot 
of discussion against it (I'd rather know my database is borked and fix 
it manually instead of an automatic fix which still might break some
data) I added it to the init script. 

The check against a running slapd was mostly a safeguard which I
inserted, fearing that slapd and db_recover could kill the database when 
running concurrently. Back when it was inserted into the package, the 
binary was still sitting in /usr/sbin. 

In my opinion, db_recover can be removed from the init script and I
think, Matthijs already did that anyway ;-)

Greetings

	Torsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-openldap-devel/attachments/20060601/76d03427/attachment-0001.pgp