[Pkg-openldap-devel] Bug#465588: openldap2.3: Restarts build from beginning due to wrong rules dependency

[Michael Banck]

Package: openldap2.3
Version: 2.4.7-5
Tags: patch

Hi,

The openldap2.3 build aborted on the hurd-i386 buildd.  I wanted to
finish it manually, but saw that it re-ran autogen, then configure and
make depend and subsequently seemed to build a lot of stuff all over
again.

I tracked this down to the $(builddir)/Makefile rule depending on the
PHONY patch target, and make apparently thinks it needs to run that
(which is a no-op, as the implementation of the patch target in
quilt.make depends on debian/stamp-patched which exists) and
subsequently $(builddir)/Makefile again, even though that file
exists.

Making $(builddir)/Makefile depend on debian/stamp-patched instead seems
to do what is expected (i.e., run make -C $(builddir) directly), patch
attached.  This has the possible downside that it exposes a more or less
internal implementation detail of quilt.make (OTOH one could argue
Debian/Ubuntu should standardize on those debian/rules targets and
stamp-files anyway...)


Michael
-------------- next part --------------
--- openldap2.3-2.4.7/debian/rules.orig	2008-02-13 14:49:40.000000000 +0100
+++ openldap2.3-2.4.7/debian/rules	2008-02-13 14:49:26.000000000 +0100
@@ -65,7 +65,7 @@
 	rm -r openldap2.3_$(VERSION).orig
 	gzip -9 openldap2.3_$(VERSION).orig.tar
 
-$(builddir)/Makefile: patch
+$(builddir)/Makefile: debian/stamp-patched
 	# Check if we include the RFCs and Internet-Drafts (which are non
 	# DFSG-free).  You can set DFSG_NONFREE to build the packages from the
 	# unchanged upstream sources but Debian can not ship the RFCs in main