[Pkg-opt-media-team] [PATCH 01/07] Fixes for some typos

Monty Montgomery xiphmont at gmail.com
Mon Dec 14 21:18:53 UTC 2009


Removing the application version from the manpage: I assume there's a
policy behind that?  Personally I find it very useful to know what
version of an application matches a manpage as my manpages typically
update with every release.   Also, as someone who typically has more
than one version installed....

"Is anal-retentive hyphenated?"  Usage consistency is good, but many
of these changes are swapping one accepted usage for another, akin to
a patch that replaces all occurences or 'gray' with 'grey'. Some are
incorrect.  The changes are rather inconsistent (why is 'LSB-first'
hyphenated but 'little endian' not? Oh wait, it is... later on...
gah!) I'm happy to take the ones that work.

Many of the grammatical, spelling, and punctuation chages are good.
However many comma changes are incorrect/inconsistent:

-or raw format.  Most ATAPI, SCSI and several proprietary CDROM drive
+or raw format.  Most ATAPI and SCSI and several proprietary CDROM drive

and

-.BR \-w ", " \-a ", " \-r " or " \-R " is used (" \-w
+.BR \-w ", " \-a ", " \-r " or, " \-R " is used (" \-w

^^^ in each case the second is simply incorrect English and there are
quite a few other examples.  The first is only potentially wrong due
to inconsistent usage (the decision whether or not to preceed 'and' or
'or' with a  comma in a homogenous list of three or more items).
There are other places where the patch makes the change correctly.

Also, why are some options broken out to bolding:

-number of retries can be specified; for comparison, default without -z is
+number of retries can be specified; for comparison, default without
+.B -z
+is

but most still aren't:

-data verification and correction features.  When using -Z, cdparanoia
-reads data exactly as would cdda2wav with an overlap setting of zero.
+data verification and correction features.  When using -Z,
+.B cdparanoia
+reads data exactly as would
+.BR cdda2wav (1)
+with an overlap setting of zero.

?

That said, it caught a bunch of real mistakes, so I'm applying the good bits.

Monty



More information about the Pkg-opt-media-team mailing list