[Pkg-opt-media-team] Bug#589112: Bug#589112: cdparanoia: add an option to not suppress progress bar when stderr is redirected

[Rogério Brito]

Hi, Frank.

On Jul 15 2010, Frank Heckenbach wrote:
> Package: cdparanoia
> Version: 3.10.2+debian-9
> Severity: wishlist
(...)
> In contrast, adding an option to cdparanoia to show the progress bar
> even if stderr is redirected is quite simple. The patch below
> (tested) does this. I've implemented it so that it can be combined
> with "-q", in which case only the progress bar is shown (which is
> what I prefer), or without "-q", so everything appears (what others
> might want to redirect/page the whole output).
(...)

Your patch seems good. Just one minor naming thing:

> --- cdparanoia-3.10.2+debian/main.c	2008-09-11 23:11:02.000000000 +0200
> +++ cdparanoia-3.10.2+debian/main.c	2010-07-12 22:10:07.000000000 +0200
>  "                                    stderr (for wrapper scripts)\n"
> +"  -E --progress                   : force output of progress bar even if\n"
> +"                                    stderr is not a terminal\n"
(...)
>  long callscript=0;
> +long force_progress_bar=0;
(...)
>  struct option options [] = {
>  	{"stderr-progress",no_argument,NULL,'e'},
> +	{"progress",no_argument,NULL,'E'},
>  	{"search-for-drive",no_argument,NULL,'s'},
(...)

Perhaps it would be a good thing to make a consistent choice between the
command line option and the variable used, for the developer's sanity?
:-)

Say, something like "-E --force-progress-bar" and leaving the variable
name the same?


Regards,

-- 
Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 1024D/7C2CAEB8
http://rb.doesntexist.org : Packages for LaTeX : algorithms.berlios.de
DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br