[Pkg-owncloud-maintainers] XML_DTD and MBD2_Schema

[Thomas Goirand]

On 05/21/2012 11:02 PM, Paul van Tilburg wrote:
> Hello Thomas,
> 
> On Mon, May 21, 2012 at 07:13:39PM +0800, Thomas Goirand wrote:
>> On 05/21/2012 05:54 PM, Thomas Müller wrote:
>>> thanks a lot! I really appreciate your support on this!
>>>
>>> I think we will build these packages your self for further testing.
>>>
>>> THX a lot,
> 
> Yes thanks a lot!
> 
>> What's the other package you said you needed, and where can I get it to
>> check on the packaging? (sorry, it's buried in my tons of mail, and I
>> don't really want to dig...)
> 
> It's php-sabredav.  I have already sponsored the upload of the package
> and it's in NEW: http://ftp-master.debian.org/new/php-sabredav_1.6.2-1.html
> 
> The packaging stuff is available here:
> Vcs-Browser: http://git.debian.org/?p=pkg-owncloud/php-sabredav.git
> Vcs-Git: http://git.debian.org/git/pkg-owncloud/php-sabredav.git
> 
> We uploaded it already to unburden you a bit and speed up some things. 
> However, you are very welcome to inspect the packaging and/or take it
> over.  I guess it belongs more in the pkg-php repository.  For
> pkg-owncloud it's just a dependency.
> 
> Cheers,
> Paul

Hi Paul,

I had a quick look in your packaging. I saw in debian/TODO the following
statement:

* Tests depend on PHPUnit_Framework_TestCase, which is not available in
Debian

Well, this might have been truth at the time of writing, but you can now
depend on phpunit (>= 3.6), as I have finally uploaded it. I would
warmly welcome you to run unit tests at build time. Also, you actually
*CAN* run MySQL unit tests at build time. To do so, you can do the way I
did with libdbi-drivers. Please see this:

http://anonscm.debian.org/gitweb/?p=users/zigo/libdbi-drivers.git;a=blob;f=debian/test_mysql.sh;h=6a5b2a6c7120da040abbc42c8056f93279b4f7be;hb=aa5826c232868ba9a90339b8c884c345b13e3a46

As you can see, what the test script does is starting a local MySQL
server instance at build time, with --skip-networking (in order not to
conflict with the installed MySQL server), and using a MySQL socket in
/tmp (and with --datadir in the /tmp as well). You can then populate
your db as it pleases you, and use it for your tests. This works quite well.

Also, when you do tests like this, don't forgot to honor
DEB_BUILD_OPTIONS. Something like this in your debian/rules would do:

ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
	./debian/run_tests
endif

Apart from that, I see no issue in your packaging. Maybe one tiny thing:
you should remove debian/docs which is currently an empty file. Also,
you didn't use the PKG-PHP team standard for branch names, which are
explained here:

http://pkg-php.alioth.debian.org/

If you could use this scheme for branch names, that'd be great, but
that's of course not mandatory.

As for taking over maintenance, well, I got plenty of food in my plate
already. I'm the main person behind most PEAR packages, and here's the
quite impressive list of packages that I work on:

http://qa.debian.org/developer.php?login=pkg-php-pear@lists.alioth.debian.org

In fact, I'd welcome help on these rather than adding more work... :)
Oh, and of course, I have my own qa page with even more... :/

Cheers,

Thomas Goirand (zigo)