r1510 - in packages/libmail-box-perl/trunk: debian lib/Mail/Box

[Gunnar Wolf]

Author: gwolf
Date: 2005-11-17 17:05:29 +0000 (Thu, 17 Nov 2005)
New Revision: 1510

Modified:
   packages/libmail-box-perl/trunk/debian/changelog
   packages/libmail-box-perl/trunk/lib/Mail/Box/Dir.pm
   packages/libmail-box-perl/trunk/lib/Mail/Box/File.pm
Log:
Makes write checks ACL-friendly


Modified: packages/libmail-box-perl/trunk/debian/changelog
===================================================================
--- packages/libmail-box-perl/trunk/debian/changelog	2005-11-17 16:16:54 UTC (rev 1509)
+++ packages/libmail-box-perl/trunk/debian/changelog	2005-11-17 17:05:29 UTC (rev 1510)
@@ -1,3 +1,11 @@
+libmail-box-perl (2.062-2) unstable; urgency=low
+
+  * Added "use filetest 'access'" before checking for write access to work
+    correctly in filesystems with ACLs - Thanks, Niko Tyni, for the answer!
+    (Closes: #321076) 
+
+ -- Gunnar Wolf <gwolf at debian.org>  Thu, 17 Nov 2005 10:59:16 -0600
+
 libmail-box-perl (2.062-1) unstable; urgency=low
 
   * New upstream release

Modified: packages/libmail-box-perl/trunk/lib/Mail/Box/Dir.pm
===================================================================
--- packages/libmail-box-perl/trunk/lib/Mail/Box/Dir.pm	2005-11-17 16:16:54 UTC (rev 1509)
+++ packages/libmail-box-perl/trunk/lib/Mail/Box/Dir.pm	2005-11-17 17:05:29 UTC (rev 1510)
@@ -53,9 +53,13 @@
 
     # Check if we can write to the folder, if we need to.
 
-    if($self->writable && -e $directory && ! -w $directory)
-    {   $self->log(WARNING=> "Folder directory $directory is write-protected.");
-        $self->{MB_access} = 'r';
+    {   # filetest 'access' is slower, but works correctly if we have a 
+	# filesystem with ACLs
+	use filetest 'access';
+	if($self->writable && -e $directory && ! -w $directory)
+	{   $self->log(WARNING=> "Folder directory $directory is write-protected.");
+	    $self->{MB_access} = 'r';
+	}
     }
 
     $self;

Modified: packages/libmail-box-perl/trunk/lib/Mail/Box/File.pm
===================================================================
--- packages/libmail-box-perl/trunk/lib/Mail/Box/File.pm	2005-11-17 16:16:54 UTC (rev 1509)
+++ packages/libmail-box-perl/trunk/lib/Mail/Box/File.pm	2005-11-17 17:05:29 UTC (rev 1510)
@@ -82,9 +82,13 @@
 
     # Check if we can write to the folder, if we need to.
 
-    if($self->writable && ! -w $filename)
-    {   $self->log(WARNING => "Folder $self file $filename is write-protected.");
-        $self->{MB_access} = 'r';
+    {   # filetest 'access' is slower, but works correctly if we have a 
+	# filesystem with ACLs
+	use filetest 'access';
+	if($self->writable && ! -w $filename)
+	{   $self->log(WARNING => "Folder $self file $filename is write-protected.");
+	    $self->{MB_access} = 'r';
+	}
     }
 
     # Start parser if reading is required.