r1888 - in packages/libversion-perl/trunk: . debian lib lib/version
t vutil
Krzysztof Krzyzaniak
eloy at costa.debian.org
Tue Jan 10 11:10:57 UTC 2006
Author: eloy
Date: 2006-01-10 11:10:56 +0000 (Tue, 10 Jan 2006)
New Revision: 1888
Modified:
packages/libversion-perl/trunk/Changes
packages/libversion-perl/trunk/META.yml
packages/libversion-perl/trunk/README
packages/libversion-perl/trunk/debian/changelog
packages/libversion-perl/trunk/debian/control
packages/libversion-perl/trunk/lib/version.pm
packages/libversion-perl/trunk/lib/version.pod
packages/libversion-perl/trunk/lib/version/vxs.pm
packages/libversion-perl/trunk/t/01base.t
packages/libversion-perl/trunk/t/02derived.t
packages/libversion-perl/trunk/t/coretests.pm
packages/libversion-perl/trunk/vutil/vutil.c
Log:
eloy: new upstream version
Modified: packages/libversion-perl/trunk/Changes
===================================================================
--- packages/libversion-perl/trunk/Changes 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/Changes 2006-01-10 11:10:56 UTC (rev 1888)
@@ -1,3 +1,46 @@
+2006-01-06 John Peacock <jpeacock at cpan.org>
+
+ New version to deal with malformed input data that came up
+ in bleadperl:
+
+ sprintf of version objects
+ <https://rt.perl.org/rt3/Ticket/Display.html?id=37897>
+
+ * README
+ lib/version/vxs.pm
+ lib/version.pm
+ Bump version.
+
+ * vutil/vutil.c
+ Die if input value has underscore but no decimal.
+
+ * t/01base.t
+ t/02derived.t
+ Use no_plan so I don't need to increment tests any more.
+
+ * t/coretests.pm
+ Check for malformed input.
+
+2006-01-05 John Peacock <jpeacock at cpan.org>
+
+ Ready for new release to CPAN with minor changes.
+
+ * README
+ Describe minor changes
+
+ * lib/version/vxs.pm
+ lib/version.pm
+ Bump $VERSION.
+
+ * vutil/vutil.c
+ Eliminate code I'm never going to use.
+
+2005-12-03 John Peacock <jpeacock at cpan.org>
+
+ * lib/version.pod
+ PAUSE does so support version objects. Elaborate on support
+ for Module::Build and lack thereof for ExtUtils::MakeMaker.
+
2005-12-02 John Peacock <jpeacock at cpan.org>
* version/vxs.pm
Modified: packages/libversion-perl/trunk/META.yml
===================================================================
--- packages/libversion-perl/trunk/META.yml 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/META.yml 2006-01-10 11:10:56 UTC (rev 1888)
@@ -1,6 +1,6 @@
---
name: version
-version: 0.50
+version: 0.52
author: ~
abstract: ~
license: perl
@@ -10,8 +10,8 @@
provides:
version:
file: lib/version.pm
- version: 0.50
+ version: 0.52
version::vxs:
file: lib/version/vxs.pm
- version: 0.50
+ version: 0.52
generated_by: Module::Build version 0.2611
Modified: packages/libversion-perl/trunk/README
===================================================================
--- packages/libversion-perl/trunk/README 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/README 2006-01-10 11:10:56 UTC (rev 1888)
@@ -1,4 +1,4 @@
-version 0.50
+version 0.52
==================================
Provides the same version objects as included in Perl v5.9.x (and hopefully in
@@ -9,9 +9,22 @@
in the core). If you are testing bleadperl, you will need to check out the
latest release of 5.9.x to get the changes included in 0.50.
+Major changes in 0.52
+==================================
+Check for malformed initializer ("1_2") based on discussion about
+some bleadperl bugs with vector printing:
-Major changes in this release:
+ sprintf of version objects
+ <https://rt.perl.org/rt3/Ticket/Display.html?id=37897>
+
+Minor changes in 0.51
==================================
+Continue rewriting the POD as the situation changes with regards to support
+for version objects in various scaffolding programs (CPAN indexer does so
+support version objects).
+
+Major changes in 0.50
+==================================
Completely rewritten POD to hopefully make it clear what is the recommended
Best Practices (to go along with Damien's book). I also hid the forthcoming
pure Perl module better (you cannot accidently use it, in other words,
@@ -25,30 +38,6 @@
<https://rt.cpan.org/Ticket/Display.html?id=16249>
-Major changes in 0.49
-==================================
-Changes in 0.48 accidently broke modules depending on qv() returning an
-object derived from 'version'. Tests were simplified since the
-implementation class 'version::vxs' is no longer independent of the main
-class.
-
-
-Major changes in 0.48
-==================================
-Significant archectectural change (object hash has to contain reference to
-array not the array itself); see
-
- <https://rt.cpan.org/Ticket/Display.html?id=14439>
-
-for details. Initial changes to support pure Perl variant (not
-included yet), see
-
- <https://rt.cpan.org/Ticket/Display.html?id=14417>
-
-for more details. All POD moved to seperate file. Tests
-abstracted out for reuse by different classes.
-
-
Please read the POD documentation for usage/details. See the CHANGES file
for full details of all changes to the module behavior.
Modified: packages/libversion-perl/trunk/debian/changelog
===================================================================
--- packages/libversion-perl/trunk/debian/changelog 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/debian/changelog 2006-01-10 11:10:56 UTC (rev 1888)
@@ -1,3 +1,10 @@
+libversion-perl (0.52-1) unstable; urgency=low
+
+ * New upstream release
+ * "Donated" to Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
+
+ -- Krzysztof Krzyzaniak (eloy) <eloy at debian.org> Tue, 10 Jan 2006 12:07:54 +0100
+
libversion-perl (0.50-1) unstable; urgency=low
* New upstream release
Modified: packages/libversion-perl/trunk/debian/control
===================================================================
--- packages/libversion-perl/trunk/debian/control 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/debian/control 2006-01-10 11:10:56 UTC (rev 1888)
@@ -2,7 +2,8 @@
Section: perl
Priority: optional
Build-Depends: debhelper (>= 4), perl (>= 5.8.0-7), perl (<< 5.9.0), libmodule-build-perl
-Maintainer: Krzysztof Krzyzaniak (eloy) <eloy at debian.org>
+Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
+Uploaders: Krzysztof Krzyzaniak (eloy) <eloy at debian.org>
Standards-Version: 3.6.2
Package: libversion-perl
Modified: packages/libversion-perl/trunk/lib/version/vxs.pm
===================================================================
--- packages/libversion-perl/trunk/lib/version/vxs.pm 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/lib/version/vxs.pm 2006-01-10 11:10:56 UTC (rev 1888)
@@ -12,7 +12,7 @@
@EXPORT = qw(qv);
-$VERSION = "0.50";
+$VERSION = 0.52;
$CLASS = 'version::vxs';
Modified: packages/libversion-perl/trunk/lib/version.pm
===================================================================
--- packages/libversion-perl/trunk/lib/version.pm 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/lib/version.pm 2006-01-10 11:10:56 UTC (rev 1888)
@@ -11,7 +11,7 @@
@EXPORT = qw(qv);
-$VERSION = "0.50";
+$VERSION = 0.52;
$CLASS = 'version';
Modified: packages/libversion-perl/trunk/lib/version.pod
===================================================================
--- packages/libversion-perl/trunk/lib/version.pod 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/lib/version.pod 2006-01-10 11:10:56 UTC (rev 1888)
@@ -55,14 +55,25 @@
=item * Be careful
If you are using Module::Build or ExtUtils::MakeMaker, so that you can
-release your module to CPAN, you have to recognize that none of those
-programs currently handles version objects natively (yet). That also
-goes for the CPAN indexer (PAUSE). Although there are modules on CPAN
-that employ the version module internally, the support for assigning a
-module $VERSION scalar is still lacking. Both Module::Build and the
-PAUSE indexer will [hopefully soon] include support for version
-objects.
+release your module to CPAN, you have to recognize that neither of those
+programs completely handles version objects natively (yet). If you use
+version objects with Module::Build, you should add an explicit dependency
+to the release of version.pm in your Build.PL:
+ my $builder = Module::Build->new(
+ ...
+ requires => {
+ ... ,
+ 'version' => 0.50,
+ ...,
+ },
+ ...
+ );
+
+and it should Just Work(TM). Module::Build will [hopefully soon]
+include full support for version objects; there are no current plans
+to patch ExtUtils::MakeMaker to support version objects.
+
=head2 What IS a version
For the purposes of this module, a version "number" is a sequence of
Modified: packages/libversion-perl/trunk/t/01base.t
===================================================================
--- packages/libversion-perl/trunk/t/01base.t 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/t/01base.t 2006-01-10 11:10:56 UTC (rev 1888)
@@ -4,7 +4,7 @@
#########################
-use Test::More tests => 96;
+use Test::More qw/no_plan/;
require "t/coretests.pm";
diag "Tests with base class" unless $ENV{PERL_CORE};
Modified: packages/libversion-perl/trunk/t/02derived.t
===================================================================
--- packages/libversion-perl/trunk/t/02derived.t 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/t/02derived.t 2006-01-10 11:10:56 UTC (rev 1888)
@@ -4,7 +4,7 @@
#########################
-use Test::More tests => 107;
+use Test::More qw/no_plan/;
BEGIN {
use_ok("version", 0.49); # If we made it this far, we are ok.
}
Modified: packages/libversion-perl/trunk/t/coretests.pm
===================================================================
--- packages/libversion-perl/trunk/t/coretests.pm 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/t/coretests.pm 2006-01-10 11:10:56 UTC (rev 1888)
@@ -41,6 +41,10 @@
like($@, qr/underscores before decimal/,
"Invalid version format (underscores before decimal)");
+ eval {my $version = $CLASS->new("1_2")};
+ like($@, qr/alpha without decimal/,
+ "Invalid version format (alpha without decimal)");
+
$version = $CLASS->new("99 and 44/100 pure");
ok ("$version" eq "99.000", '$version eq "99.000"');
ok ($version->numify == 99.0, '$version->numify == 99.0');
Modified: packages/libversion-perl/trunk/vutil/vutil.c
===================================================================
--- packages/libversion-perl/trunk/vutil/vutil.c 2006-01-10 11:07:45 UTC (rev 1887)
+++ packages/libversion-perl/trunk/vutil/vutil.c 2006-01-10 11:10:56 UTC (rev 1888)
@@ -34,14 +34,6 @@
AV *av = newAV();
SV *hv = newSVrv(rv, "version"); /* create an SV and upgrade the RV */
(void)sv_upgrade(hv, SVt_PVHV); /* needs to be an HV type */
-#if 0
- /* upgrade the RV and tie it to the hash (the hard way) */
- HV *hv = newHV();
- (void)sv_upgrade(rv, SVt_RV);
- SvRV(rv) = (SV *)hv;
- SvROK_on(rv);
- (void)sv_bless(rv, gv_stashpv("version", TRUE));
-#endif
#ifndef NODEFAULT_SHAREKEYS
HvSHAREKEYS_on(hv); /* key-sharing on by default */
@@ -77,6 +69,9 @@
pos++;
}
+ if ( alpha && !saw_period )
+ Perl_croak(aTHX_ "Invalid version format (alpha without decimal)");
+
if ( saw_period > 1 )
qv = 1; /* force quoted version processing */
More information about the Pkg-perl-cvs-commits
mailing list