r9578 - in /scripts/qa/DebianQA: DebVersions.pm Watch.pm

[tincho-guest at users.alioth.debian.org]

Author: tincho-guest
Date: Mon Nov 19 03:58:04 2007
New Revision: 9578

URL: http://svn.debian.org/wsvn/?sc=1&rev=9578
Log:
Added a couple of sanity checks.

Modified:
    scripts/qa/DebianQA/DebVersions.pm
    scripts/qa/DebianQA/Watch.pm

Modified: scripts/qa/DebianQA/DebVersions.pm
URL: http://svn.debian.org/wsvn/scripts/qa/DebianQA/DebVersions.pm?rev=9578&op=diff
==============================================================================
--- scripts/qa/DebianQA/DebVersions.pm (original)
+++ scripts/qa/DebianQA/DebVersions.pm Mon Nov 19 03:58:04 2007
@@ -11,12 +11,17 @@
 package DebianQA::DebVersions;
 use strict;
 use warnings;
+use Carp;
 
 our @ISA = "Exporter";
 our @EXPORT = qw( deb_compare deb_compare_nofail );
 
 sub deb_parse($) {
     my $v = shift;
+    unless($v) {
+        carp "Empty debian package version passed";
+        return ();
+    }
     unless($v =~ /^(?:(\d+):)?([A-Za-z0-9+.:~_-]*?)(?:-([+.~_A-Za-z0-9]+))?$/) {
         warn "Invalid debian package version: $v\n";
         return ();

Modified: scripts/qa/DebianQA/Watch.pm
URL: http://svn.debian.org/wsvn/scripts/qa/DebianQA/Watch.pm?rev=9578&op=diff
==============================================================================
--- scripts/qa/DebianQA/Watch.pm (original)
+++ scripts/qa/DebianQA/Watch.pm Mon Nov 19 03:58:04 2007
@@ -84,7 +84,7 @@
             my $diff;
             if($watch{$md5}{upstream_mangled}) {
                 $diff = deb_compare($wline->{mangled_ver},
-                    $watch{$md5}{upstream_mangled});
+                    $watch{$md5}{upstream_mangled}) if($wline->{mangled_ver});
                 $watch{$md5}{watch_error} = "InvalidVersion" unless(
                     defined $diff);
             } else {