r7873 - in /trunk/libcompress-zlib-perl: Changes META.yml README debian/changelog lib/Compress/Zlib.pm t/03zlib-v1.t t/14gzopen.t
dmn at users.alioth.debian.org
dmn at users.alioth.debian.org
Sat Sep 22 17:00:17 UTC 2007
Author: dmn
Date: Sat Sep 22 17:00:16 2007
New Revision: 7873
URL: http://svn.debian.org/wsvn/?sc=1&rev=7873
Log:
* New upstream release
Fixes compatibility issyes with 1.x series
Closes: #440943 -- Documentation and/or API inconsistencies
Modified:
trunk/libcompress-zlib-perl/Changes
trunk/libcompress-zlib-perl/META.yml
trunk/libcompress-zlib-perl/README
trunk/libcompress-zlib-perl/debian/changelog
trunk/libcompress-zlib-perl/lib/Compress/Zlib.pm
trunk/libcompress-zlib-perl/t/03zlib-v1.t
trunk/libcompress-zlib-perl/t/14gzopen.t
Modified: trunk/libcompress-zlib-perl/Changes
URL: http://svn.debian.org/wsvn/trunk/libcompress-zlib-perl/Changes?rev=7873&op=diff
==============================================================================
--- trunk/libcompress-zlib-perl/Changes (original)
+++ trunk/libcompress-zlib-perl/Changes Sat Sep 22 17:00:16 2007
@@ -1,5 +1,12 @@
CHANGES
-------
+
+ 2.007 22 September 20007
+
+ * lib/Compress/Zlib.pm -- 1.x Backward Compatability issues
+ gzclose - documented return value was wrong, should be 0 for ok.
+ gzflush - return value didn't match 1.x, should return 0 if ok.
+ [rt.cpan.org #29215] and Debian bug #440943 http://bugs.debian.org/440943
2.006 1 September 20007
Modified: trunk/libcompress-zlib-perl/META.yml
URL: http://svn.debian.org/wsvn/trunk/libcompress-zlib-perl/META.yml?rev=7873&op=diff
==============================================================================
--- trunk/libcompress-zlib-perl/META.yml (original)
+++ trunk/libcompress-zlib-perl/META.yml Sat Sep 22 17:00:16 2007
@@ -1,6 +1,6 @@
--- #YAML:1.0
name: Compress-Zlib
-version: 2.006
+version: 2.007
abstract: Interface to zlib compression library
license: perl
generated_by: ExtUtils::MakeMaker version 6.36
Modified: trunk/libcompress-zlib-perl/README
URL: http://svn.debian.org/wsvn/trunk/libcompress-zlib-perl/README?rev=7873&op=diff
==============================================================================
--- trunk/libcompress-zlib-perl/README (original)
+++ trunk/libcompress-zlib-perl/README Sat Sep 22 17:00:16 2007
@@ -1,9 +1,9 @@
Compress::Zlib
- Version 2.006
+ Version 2.007
- 1st September 2007
+ 22nd September 2007
Copyright (c) 1995-2007 Paul Marquess. All rights reserved.
Modified: trunk/libcompress-zlib-perl/debian/changelog
URL: http://svn.debian.org/wsvn/trunk/libcompress-zlib-perl/debian/changelog?rev=7873&op=diff
==============================================================================
--- trunk/libcompress-zlib-perl/debian/changelog (original)
+++ trunk/libcompress-zlib-perl/debian/changelog Sat Sep 22 17:00:16 2007
@@ -1,3 +1,11 @@
+libcompress-zlib-perl (2.007-1) UNRELEASED; urgency=low
+
+ * New upstream release
+ Fixes compatibility issyes with 1.x series
+ Closes: #440943 -- Documentation and/or API inconsistencies
+
+ -- Damyan Ivanov <dmn at debian.org> Sat, 22 Sep 2007 19:59:03 +0300
+
libcompress-zlib-perl (2.006-1) unstable; urgency=low
* New upstream release
Modified: trunk/libcompress-zlib-perl/lib/Compress/Zlib.pm
URL: http://svn.debian.org/wsvn/trunk/libcompress-zlib-perl/lib/Compress/Zlib.pm?rev=7873&op=diff
==============================================================================
--- trunk/libcompress-zlib-perl/lib/Compress/Zlib.pm (original)
+++ trunk/libcompress-zlib-perl/lib/Compress/Zlib.pm Sat Sep 22 17:00:16 2007
@@ -18,7 +18,7 @@
use bytes ;
our ($VERSION, $XS_VERSION, @ISA, @EXPORT, $AUTOLOAD);
-$VERSION = '2.006';
+$VERSION = '2.007';
$XS_VERSION = $VERSION;
$VERSION = eval $VERSION;
@@ -242,8 +242,8 @@
my $gz = $self->[0] ;
my $status = $gz->flush($f) ;
- _save_gzerr($gz);
- return $status ;
+ my $err = _save_gzerr($gz);
+ return $status ? 0 : $err;
}
sub Compress::Zlib::gzFile::gzclose
@@ -252,8 +252,8 @@
my $gz = $self->[0] ;
my $status = $gz->close() ;
- _save_gzerr($gz);
- return ! $status ;
+ my $err = _save_gzerr($gz);
+ return $status ? 0 : $err;
}
sub Compress::Zlib::gzFile::gzeof
@@ -806,7 +806,7 @@
can seriously degrade the level of compression achieved. See the C<zlib>
documentation for details.
-Returns 1 on success, 0 on failure.
+Returns 0 on success.
=item B<$offset = $gz-E<gt>gztell() ;>
@@ -831,7 +831,7 @@
Closes the compressed file. Any pending data is flushed to the file
before it is closed.
-Returns 1 on success, 0 on failure.
+Returns 0 on success.
=item B<$gz-E<gt>gzsetparams($level, $strategy>
Modified: trunk/libcompress-zlib-perl/t/03zlib-v1.t
URL: http://svn.debian.org/wsvn/trunk/libcompress-zlib-perl/t/03zlib-v1.t?rev=7873&op=diff
==============================================================================
--- trunk/libcompress-zlib-perl/t/03zlib-v1.t (original)
+++ trunk/libcompress-zlib-perl/t/03zlib-v1.t Sat Sep 22 17:00:16 2007
@@ -23,10 +23,10 @@
my $count = 0 ;
if ($] < 5.005) {
- $count = 383 ;
+ $count = 390 ;
}
else {
- $count = 394 ;
+ $count = 401 ;
}
@@ -1168,3 +1168,21 @@
is slurp($name), $data1 . $data2 . $trailing, "got expected data from slurp" ;
is trickle($name), $data1 . $data2 . $trailing, "got expected data from trickle" ;
}
+
+{
+ title "gzclose & gzflush return codes";
+ # rt.29215
+
+ my $lex = new LexFile my $name ;
+ my $data1 = "the is some text";
+ my $status;
+
+ $fil = gzopen($name, "wb") ;
+ ok $fil, "opened first file";
+ is $fil->gzwrite($data1), length $data1, "write data1" ;
+ $status = $fil->gzflush(0xfff);
+ ok $status, "flush not ok" ;
+ is $status, Z_STREAM_ERROR;
+ ok ! $fil->gzflush(), "flush ok" ;
+ ok ! $fil->gzclose(), "Closed";
+}
Modified: trunk/libcompress-zlib-perl/t/14gzopen.t
URL: http://svn.debian.org/wsvn/trunk/libcompress-zlib-perl/t/14gzopen.t?rev=7873&op=diff
==============================================================================
--- trunk/libcompress-zlib-perl/t/14gzopen.t (original)
+++ trunk/libcompress-zlib-perl/t/14gzopen.t Sat Sep 22 17:00:16 2007
@@ -95,7 +95,7 @@
is $fil->gzwrite($number), $num_len, "gzwrite returned $num_len" ;
is $gzerrno, 0, 'gzerrno is 0';
-ok $fil->gzflush(Z_FINISH) ;
+ok ! $fil->gzflush(Z_FINISH) ;
is $gzerrno, 0, 'gzerrno is 0';
More information about the Pkg-perl-cvs-commits
mailing list