r23760 - /scripts/KGB/server/KGB

[dmn at users.alioth.debian.org]

Author: dmn
Date: Mon Aug  4 17:21:40 2008
New Revision: 23760

URL: http://svn.debian.org/wsvn/?sc=1&rev=23760
Log:
do_commit* do pass $kernel and $response as ordinary arguments

Modified:
    scripts/KGB/server/KGB

Modified: scripts/KGB/server/KGB
URL: http://svn.debian.org/wsvn/scripts/KGB/server/KGB?rev=23760&op=diff
==============================================================================
--- scripts/KGB/server/KGB (original)
+++ scripts/KGB/server/KGB Mon Aug  4 17:21:40 2008
@@ -200,9 +200,7 @@
     undef;
 }
 sub do_commit_01 {
-    my $kernel = $_[KERNEL];
-    my $response = $_[ARG0];
-    my($repo_id, $rev, $paths, $log, $author) = @_;
+    my($kernel, $response, $repo_id, $rev, $paths, $log, $author) = @_;
     my @log = split(/\n+/, $log);
     my @string = ("\002$repo_id\017: \00303$author\017 * r\002$rev\017 " .
         "(files: \00310@$paths\017) $log[0]");
@@ -234,15 +232,13 @@
     $kernel->post( SOAPServer => 'DONE', $response );
 }
 sub do_commit_0 {
-    my $kernel = $_[KERNEL];
-    my $response = $_[ARG0];
+    my($kernel, $response, $repo_id, $passwd, $rev, $paths, $log, $author) = @_;
     unless($conf->{min_protocol_version} == 0) {
         $kernel->post(SOAPServer => 'FAULT', $response, 'Client.Arguments',
             "Protocol version 0 not welcome");
         warn("Protocol version 0 rejected\n");
         return
     }
-    my($repo_id, $passwd, $rev, $paths, $log, $author) = @_;
     unless($conf->{repositories}{$repo_id}) {
         $kernel->post(SOAPServer => 'FAULT', $response, 'Client.Arguments',
             "Repository $repo_id is unknown");
@@ -256,12 +252,10 @@
         warn("Invalid password\n");
         return
     }
-    do_commit_01($repo_id, $rev, $paths, $log, $author);
+    do_commit_01($kernel, $response, $repo_id, $rev, $paths, $log, $author);
 }
 sub do_commit_1 {
-    my $kernel = $_[KERNEL];
-    my $response = $_[ARG0];
-    my($repo_id, $checksum, $rev, $paths, $log, $author) = @_;
+    my($kernel, $response, $repo_id, $checksum, $rev, $paths, $log, $author) = @_;
     unless($conf->{repositories}{$repo_id}) {
         $kernel->post(SOAPServer => 'FAULT', $response, 'Client.Arguments',
             "Repository $repo_id is unknown");
@@ -275,7 +269,7 @@
         warn("Authentication failed\n");
         return
     }
-    do_commit_01($repo_id, $rev, $paths, $log, $author);
+    do_commit_01($kernel, $response, $repo_id, $rev, $paths, $log, $author);
 }
 sub do_commit {
     my $kernel = $_[KERNEL];
@@ -292,7 +286,7 @@
     }
     if( @{$params->{Array}} == 6 ) {
     	# protocol 0
-	return do_commit_0(@{$params->{Array}});
+	return do_commit_0($kernel, $response, @{$params->{Array}});
     } 
     my $proto_ver = shift @{$params->{Array}};
     unless(defined($proto_ver) and $proto_ver =~ /^\d{1,5}$/
@@ -306,7 +300,7 @@
         return
     }
     if($proto_ver == 1) {
-	return do_commit_1(@{$params->{Array}})
+	return do_commit_1($kernel, $response, @{$params->{Array}})
     } else {
         $kernel->post(SOAPServer => 'FAULT', $response, 'Client.Arguments',
             "Invalid protocol version ($proto_ver)");