r24521 - in /branches/upstream/libdbd-pg-perl/current: Changes META.yml Makefile.PL Pg.pm README SIGNATURE dbdimp.c lib/Bundle/DBD/Pg.pm t/02attribs.t t/09arrays.t t/99_perlcritic.t t/99_spellcheck.t

gregoa at users.alioth.debian.org gregoa at users.alioth.debian.org
Sat Aug 23 17:02:10 UTC 2008


Author: gregoa
Date: Sat Aug 23 17:02:08 2008
New Revision: 24521

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=24521
Log:
[svn-upgrade] Integrating new upstream version, libdbd-pg-perl (2.9.2)

Modified:
    branches/upstream/libdbd-pg-perl/current/Changes
    branches/upstream/libdbd-pg-perl/current/META.yml
    branches/upstream/libdbd-pg-perl/current/Makefile.PL
    branches/upstream/libdbd-pg-perl/current/Pg.pm
    branches/upstream/libdbd-pg-perl/current/README
    branches/upstream/libdbd-pg-perl/current/SIGNATURE
    branches/upstream/libdbd-pg-perl/current/dbdimp.c
    branches/upstream/libdbd-pg-perl/current/lib/Bundle/DBD/Pg.pm
    branches/upstream/libdbd-pg-perl/current/t/02attribs.t
    branches/upstream/libdbd-pg-perl/current/t/09arrays.t
    branches/upstream/libdbd-pg-perl/current/t/99_perlcritic.t
    branches/upstream/libdbd-pg-perl/current/t/99_spellcheck.t

Modified: branches/upstream/libdbd-pg-perl/current/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/Changes?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/Changes (original)
+++ branches/upstream/libdbd-pg-perl/current/Changes Sat Aug 23 17:02:08 2008
@@ -1,6 +1,17 @@
 ('GSM' is Greg Sabino Mullane, greg at turnstep.com)
 
-2.9.0 Released August 3, 2008
+2.9.2 Released August 18, 2008
+
+	- Empty Postgres arrays should return empty Perl arrays, not undef.
+		(CPAN bug #38552) [David E. Wheeler]
+
+2.9.1 Released August 17, 2008 (subversion r11660)
+
+	- Return undef when mapping Postgres array to Perl array and 
+		the array is empty '{}'. (CPAN bug #38552) [GSM]
+	- Minor documentation improvements. [GSM]
+
+2.9.0 Released August 3, 2008 (subversion r11624)
 
 	- Add support for database handle attribute "ReadOnly". This allows 
 		use of $dbh->{ReadOnly} = 1 to enforce read only mode at 
@@ -13,8 +24,8 @@
 
 2.8.7 Released July 24, 2008 (subversion r11582)
 
-	- Modify test scripts to work better on FreeBSD boxes.
-	- Much documentation improvement and POD tweaking.
+	- Modify test scripts to work better on FreeBSD boxes. [GSM]
+	- Much documentation improvement and POD tweaking. [GSM]
 
 2.8.6 Released July 21, 2008 (subversion r11558)
 
@@ -27,21 +38,21 @@
 	  	is set to DEBUG3 or greater, and we then exit without disconnecting 
 		while AutoCommit is off. The new behavior is to simply not attempt to 
 		output the debugging information about the final 'rollback'. [GSM]
-	- More documentation improvements.
+	- More documentation improvements. [GSM]
 
 2.8.4 Released July 10, 2008 (subversion r11520)
 
-	- Minor Perl::Critic test adjustments.
-	- Documentation enhancements.
-	- Yet more minor testing tweaks.
+	- Minor Perl::Critic test adjustments. [GSM]
+	- Documentation enhancements. [GSM]
+	- Yet more minor testing tweaks. [GSM]
 
 2.8.3 Released July 6, 2008 (subversion r11495)
 
-	- Minor testing functionality tweaks, lots of test cleanups, minor doc enhancements.
+	- Minor testing functionality tweaks, lots of test cleanups, minor doc enhancements. [GSM]
 
 2.8.2 Released June 29, 2008 (subversion r11466)
 
-	- Minor testing tweaks, doc fixes.
+	- Minor testing tweaks, doc fixes. [GSM]
 
 2.8.1 Released June 11, 2008 (subversion r11417)
 
@@ -78,7 +89,7 @@
 
 2.6.6 Released May 7, 2008 (subversion r11214)
 
-	- Fix minor problem in t/99_spellcheck.t
+	- Fix minor problem in t/99_spellcheck.t [GSM]
 
 2.6.5 Released May 7, 2008 (subversion r11209)
 
@@ -87,11 +98,11 @@
 
 2.6.4 Released May 2, 2008 (subversion r11186)
 
-	- More tweaks to the test suite.
+	- More tweaks to the test suite. [GSM]
 
 2.6.3 Released May 1, 2008 (subversion r11169)
 
-	- Minor tweaks to the test suite.
+	- Minor tweaks to the test suite. [GSM]
 
 2.6.2 Released April 30, 2008 (subversion r11161)
 
@@ -123,7 +134,7 @@
 
 	- Add pg_enum_values to $dbh->column_info()
 		[Dave Rolsky] (CPAN ticket #34351)
-	- Minor test fixes.
+	- Minor test fixes. [GSM]
 
 2.4.0 Released March 21, 2008 (subversion r10974)
 
@@ -137,26 +148,22 @@
 
 2.2.2 Released March 3, 2008 (subversion r10873)
 
-	- Remove non-working tracing from types.c and quote.c
-
-	- Add parse_trace_flag as statement handle method.
+	- Remove non-working tracing from types.c and quote.c [GSM]
+
+	- Add parse_trace_flag as statement handle method. [GSM]
 
 2.2.1 Released March 1, 2008 (subversion r10865)
 
-	- Fix memory leaks in dbdimp.c (CPAN bug #33743)
-		[Alexey Tourbin]
-	- Fix strlen problems in dbdimp.c (CPAN bug #33737)
-		[Alexey Tourbin]
-	- Fix char count in Renew() (CPAN bug #33738)
-		[Alexey Tourbin]
-	- Change local trace_flags to lowercase.
+	- Fix memory leaks in dbdimp.c (CPAN bug #33743) [Alexey Tourbin]
+	- Fix strlen problems in dbdimp.c (CPAN bug #33737) [Alexey Tourbin]
+	- Fix char count in Renew() (CPAN bug #33738) [Alexey Tourbin]
+	- Change local trace_flags to lowercase. [GSM]
 
 2.2.0 Released February 27, 2008 (subversion r10849)
 
 	- Introduce enhanced trace flags. See the documentation 
 		 on parse_trace_flags() for details. [GSM]
-	- Remove version.pm dependency from Makefile.PL
-		(CPAN bug #33429)
+	- Remove version.pm dependency from Makefile.PL (CPAN bug #33429)
 
 2.1.3 Released February 20, 2008 (subversion r10813)
 
@@ -166,24 +173,23 @@
 
 	- Do not build if environment variables POSTGRES_HOME, POSTGRES_LIB, 
 		or POSTGRES_INCLUDE are set but not valid.
-	- Fix dependency requirements, especially version.pm
+	- Fix dependency requirements, especially version.pm [GSM]
 
 2.1.1 Released February 19, 2008 (subversion r10798)
 
-	- Better URLs to cpan.org resources.
+	- Better URLs to cpan.org resources. [GSM]
 
 2.1.0 Released February 18, 2008 (subversion r10793)
 
 	- Use version.pm (CPAN bug #33206) [GSM]
-	- Add PERL_NO_GET_CONTEXT #define to improve performance on threaded Perls
-	- Raise the minimum DBI version to 1.52.
+	- Add PERL_NO_GET_CONTEXT #define to improve performance on threaded Perls [GSM]
+	- Raise the minimum DBI version to 1.52. [GSM]
 	- Allow arrayrefs into bind_col (CPAN bug #33193) [GSM]
 	- Remove '//' style comments to make strict ANSI compilers happy.
 		[Trevor Inman] (CPAN bug #33089)
-	- Force client encoding of UTF8 for some tests.
-	- Make 03dbmethod.t pass minor test for version 8.1.9
-		(CPAN bug #33282)
-	- Add a local copy of dbivport.h
+	- Force client encoding of UTF8 for some tests. [GSM]
+	- Make 03dbmethod.t pass minor test for version 8.1.9 (CPAN bug #33282) [GSM]
+	- Add a local copy of dbivport.h [GSM]
 
 2.0.0 Released February 10, 2008 (subversion r10715)
 
@@ -205,8 +211,8 @@
 		things such as 'PREPARE TRANSACTION' to work properly.
 		(CPAN bug #32423) [GSM]
 	- Overhauled the data type system. [GSM]
-	- Switch from cvs to subversion. Switch from gborg to perl.org.
-	- Change versioning system to three numbered system.
+	- Switch from cvs to subversion. Switch from gborg to perl.org. [GSM]
+	- Change versioning system to three numbered system. [GSM]
 
 Bug fixes:
 
@@ -215,8 +221,7 @@
 		placeholders, i.e. the geometric operator '?#' (CPAN bug #24124) [GSM]
 	- Fix memory leak in bytea quoting. (CPAN bug #21392). Fix memory leak 
 		in pg_notifies. [Stephen Marshall smarshall at wsi.com]
-	- Fix memory leak when using savepoints. (CPAN bug #29791)
-		[airwave at cpan.org]
+	- Fix memory leak when using savepoints. (CPAN bug #29791) [airwave at cpan.org]
 	- Use adbin, not adsrc, when figuring out the sequence name for the 
 		last_insert_id() method. This allows the function to work properly 
 		if the sequence name is changed. Note that {pg_cache=>0} should be 

Modified: branches/upstream/libdbd-pg-perl/current/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/META.yml?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/META.yml (original)
+++ branches/upstream/libdbd-pg-perl/current/META.yml Sat Aug 23 17:02:08 2008
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name                        : DBD-Pg
-version                     : 2.9.0
+version                     : 2.9.2
 abstract                    : DBI PostgreSQL interface
 author:              
   - Greg Sabino Mullane <greg at turnstep.com>
@@ -26,7 +26,7 @@
   Test::Pod::Coverage       : 0
   Test::Warn                : 0.08
   Test::YAML::Meta          : 0.03
-  Text::Spellchecker        : 0
+  Text::SpellChecker        : 0
 build_requires:
   DBI                       : 1.52
   Test::More                : 0.61
@@ -38,10 +38,10 @@
 provides:
   DBD::Pg:
     file                    : Pg.pm
-    version                 : 2.9.0
+    version                 : 2.9.2
   Bundle::DBD::Pg:
     file                    : lib/Bundle/DBD/Pg.pm
-    version                 : 2.9.0
+    version                 : 2.9.2
 
 keywords:
   - Postgres

Modified: branches/upstream/libdbd-pg-perl/current/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/Makefile.PL?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/Makefile.PL (original)
+++ branches/upstream/libdbd-pg-perl/current/Makefile.PL Sat Aug 23 17:02:08 2008
@@ -1,4 +1,4 @@
-# $Id: Makefile.PL 11607 2008-07-29 03:51:23Z turnstep $
+# $Id: Makefile.PL 11662 2008-08-18 13:43:05Z turnstep $
 
 use ExtUtils::MakeMaker;
 use Config;
@@ -7,7 +7,7 @@
 use 5.006001;
 
 ## No version.pm for this one, as the prereqs are not loaded yet.
-my $VERSION = '2.9.0';
+my $VERSION = '2.9.2';
 
 my $lib;
 BEGIN {

Modified: branches/upstream/libdbd-pg-perl/current/Pg.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/Pg.pm?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/Pg.pm (original)
+++ branches/upstream/libdbd-pg-perl/current/Pg.pm Sat Aug 23 17:02:08 2008
@@ -1,5 +1,5 @@
 #  -*-cperl-*-
-#  $Id: Pg.pm 11621 2008-08-03 01:11:02Z turnstep $
+#  $Id: Pg.pm 11663 2008-08-18 13:56:12Z turnstep $
 #
 #  Copyright (c) 2002-2008 Greg Sabino Mullane and others: see the Changes file
 #  Portions Copyright (c) 2002 Jeffrey W. Baker
@@ -17,7 +17,7 @@
 {
 	package DBD::Pg;
 
-	use version; our $VERSION = qv('2.9.0');
+	use version; our $VERSION = qv('2.9.2');
 
 	use DBI ();
 	use DynaLoader ();
@@ -1696,7 +1696,7 @@
 
 =head1 VERSION
 
-This documents version 2.9.0 of the DBD::Pg module
+This documents version 2.9.2 of the DBD::Pg module
 
 =head1 DESCRIPTION
 
@@ -2120,7 +2120,7 @@
 
 Forces errors to always raise an exception. Although it defaults to off, it is recommended that this 
 be turned on, as the alternative is to check the return value of every method (prepare, execute, fetch, etc.) 
-to check for any problems. See the DBI docs for more information.
+manually, which is easy to forget to do.
 
 =head3 B<PrintError> (boolean, inherited)
 
@@ -2145,11 +2145,6 @@
 attribute to false for database handles. For statement handles, any call to L</execute> or its variants will flip the value to 
 true for the lifetime of the statement handle.
 
-=head3 B<Type> (scalar)
-
-Returns C<dr> for a driver handle, C<db> for a database handle, and C<st> for a statement handle. 
-Should be rarely needed.
-
 =head3 B<TraceLevel> (integer, inherited)
 
 Sets the trace level, similar to the L</trace> method. See the sections on 
@@ -2203,7 +2198,7 @@
 
 =head3 B<ChopBlanks> (boolean, inherited)
 
-Supported by this driver as proposed by DBI. This method is similar to the
+Supported by DBD::Pg as proposed by DBI. This method is similar to the
 SQL function C<RTRIM>.
 
 =head3 B<Taint> (boolean, inherited)
@@ -2222,17 +2217,22 @@
 
 Implemented by DBI, no driver-specific impact.
 
+=head3 B<Type> (scalar)
+
+Returns C<dr> for a driver handle, C<db> for a database handle, and C<st> for a statement handle. 
+Should be rarely needed.
+
 =head3 B<LongReadLen> (integer, inherited)
 
-Not used by this driver.
+Not used by DBD::Pg
 
 =head3 B<LongTruncOk> (boolean, inherited)
 
-Not used by this driver.
+Not used by DBD::Pg
 
 =head3 B<CompatMode> (boolean, inherited)
 
-Not used by this driver.
+Not used by DBD::Pg
 
 =head1 DBI DATABASE HANDLE OBJECTS
 
@@ -2887,7 +2887,8 @@
 
   @type_info = $dbh->type_info($data_type);
 
-Implemented by DBI, no driver-specific impact.
+Returns a list of hash references holding information about one or more variants of $data_type. 
+See the DBI documentation for more details.
 
 =head3 B<quote>
 
@@ -2995,7 +2996,7 @@
 
 =head3 B<AutoCommit> (boolean)
 
-Supported by this driver as proposed by DBI. According to the classification of
+Supported by DBD::Pg as proposed by DBI. According to the classification of
 DBI, PostgreSQL is a database in which a transaction must be explicitly
 started. Without starting a transaction, every change to the database becomes
 immediately permanent. The default of AutoCommit is on, but this may change
@@ -3015,7 +3016,7 @@
 Specifies if the current database connection should be in read-only mode or not. 
 In this mode, changes that change the database are not allowed and will throw 
 an error. Note: this method will B<not> work if L</AutoCommit> is true. The 
-read-only effect is accomplished by sending a SET TRANSACTION READ ONLY after 
+read-only effect is accomplished by sending a S<SET TRANSACTION READ ONLY> after 
 every begin. For more details, please see:
 
 http://www.postgresql.org/docs/current/interactive/sql-set-transaction.html
@@ -3449,7 +3450,7 @@
 
   $rv = $sth->rows;
 
-Returns the number of rows returned by the last query. In contrast to many other drivers, 
+Returns the number of rows returned by the last query. In contrast to many other DBD modules, 
 the number of rows is available immediately after calling C<$sth-E<gt>execute>. Note that 
 the L</execute> method itself returns the number of rows itself, which means that this 
 method is rarely needed.
@@ -3488,8 +3489,8 @@
 
   $blob = $sth->blob_read($id, $offset, $len);
 
-Supported by this driver as proposed by DBI. Implemented by DBI but not
-documented, so this method might change.
+Supported by DBD::Pg. This method is implemented by DBI but not
+currently documented by DBI, so this method might change.
 
 This method seems to be heavily influenced by the current implementation of
 blobs in Oracle. Nevertheless we try to be as compatible as possible. Whereas
@@ -3499,7 +3500,7 @@
 why the C<blob_read> method is blessed into the STATEMENT package and not part of
 the DATABASE package. Here the field parameter has been used to handle this
 object identifier. The offset and len parameters may be set to zero, in which
-case the driver fetches the whole blob at once.
+case the whole blob is fetched at once.
 
 See also the PostgreSQL-specific functions concerning blobs, which are
 available via the C<func> interface.
@@ -3575,26 +3576,26 @@
 indicates if the column is nullable or not. 0 = not nullable, 1 = nullable, 2 = unknown. 
 This method returns undef if called before C<execute()>.
 
-=head3 B<CursorName> (string, read-only)
-
-Not supported by this driver. See the note about L</Cursors> elsewhere in this
-document.
-
 =head3 B<Database> (dbh, read-only)
 
 Returns the database handle this statement handle was created from.
 
 =head3 B<ParamValues> (hash ref, read-only)
 
-Supported by this driver as proposed by DBI. If called before L</execute>, the
-literal values passed in are returned. If called after L</execute>, then
-the quoted versions of the values are shown.
+Returns a reference to a hash containing the values currently bound to placeholders. If the "named parameters" 
+type of placeholders are being used (such as ":foo"), then the keys of the hash will be the names of the 
+placeholders (without the colon). If the "dollar sign numbers" type of placeholders are being used, the keys of the hash will 
+be the numbers, without the dollar signs. If the "question mark" type is used, integer numbers will be returned, 
+starting at one and increasing for every placeholder.
+
+If this method is called before L</execute>, the literal values passed in are returned. If called after 
+L</execute>, then the quoted versions of the values are returned.
 
 =head3 B<ParamTypes> (hash ref, read-only)
 
-Returns a hash of all current placeholders. The keys are the names of the placeholders, 
-and the values are the types that have been bound to each one. Placeholders that 
-have not yet been bound will return undef as the value.
+Returns a reference to a hash containing the type names currently bound to placeholders. The keys 
+are the same as returned by the ParamValues method. Placeholders that have not yet been bound will return 
+undef as the value.
 
 =head3 B<Statement> (string, read-only)
 
@@ -3684,6 +3685,10 @@
 =head3 B<RowCache> (integer, read-only)
 
 Not used by DBD::Pg
+
+=head3 B<CursorName> (string, read-only)
+
+Not used by DBD::Pg. See the note about L</Cursors> elsewhere in this document.
 
 =head1 FURTHER INFORMATION
 
@@ -4021,7 +4026,7 @@
 
 =head2 Large Objects
 
-This driver supports all largeobject functions provided by libpq via the
+DBD::Pg supports all largeobject functions provided by libpq via the
 C<func> method. Please note that access to a large object, even read-only 
 large objects, must be put into a transaction.
 

Modified: branches/upstream/libdbd-pg-perl/current/README
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/README?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/README (original)
+++ branches/upstream/libdbd-pg-perl/current/README Sat Aug 23 17:02:08 2008
@@ -1,12 +1,12 @@
 
 DBD::Pg  --  the DBI PostgreSQL interface for Perl
 
-# $Id: README 11596 2008-07-27 03:01:22Z turnstep $
+# $Id: README 11662 2008-08-18 13:43:05Z turnstep $
 
 DESCRIPTION:
 ------------
 
-This is version 2.9.0 of DBD::Pg, the Perl interface to Postgres using DBI. 
+This is version 2.9.2 of DBD::Pg, the Perl interface to Postgres using DBI. 
 The web site for this interface, and the latest version, can be found at:
 
 	http://search.cpan.org/dist/DBD-Pg/

Modified: branches/upstream/libdbd-pg-perl/current/SIGNATURE
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/SIGNATURE?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/SIGNATURE (original)
+++ branches/upstream/libdbd-pg-perl/current/SIGNATURE Sat Aug 23 17:02:08 2008
@@ -15,41 +15,41 @@
 Hash: RIPEMD160
 
 SHA1 14d7a3c7a0b0497e4ab463b67850bd5e1f70409d .perlcriticrc
-SHA1 b02f73e0cb6b7059fe0fd0340b5634f4e4fa661c Changes
+SHA1 4a4e4482f78ed8c5d0a33ff768cbcd3e2a7fcdda Changes
 SHA1 4d91c71e5dbb19ece1505ab75c36d00a744bb076 MANIFEST
 SHA1 22055b195f5cf15d7909e8a08468e617f46154e7 MANIFEST.SKIP
-SHA1 2d5589247173c880087e646e6c89b1637fc10fef META.yml
-SHA1 652637b54c5fffff60e6cf8703b9309374480071 Makefile.PL
+SHA1 6f84819a1c50ae442299db27de8eac43b5c4596f META.yml
+SHA1 d4625971f94dffb69d751718652055846bd5f292 Makefile.PL
 SHA1 c51356c52c139265e20a2ad33bc8d3ee04f6ff48 Pg.h
-SHA1 ec88735ebeb10eee7d4957505ee33e94f2b60a47 Pg.pm
+SHA1 85166d9faa677761e0d3578c13ee1e15f470d3ec Pg.pm
 SHA1 06d991c871e5f2b3b900990fc71e6207c94ad8cf Pg.xs
-SHA1 7e06fafd21c1f40f35b838d634571bbaf42adaae README
+SHA1 3b6c9cbf977c30795e7c1b889944261e2b6328f3 README
 SHA1 c6d2633bdb72186bfb2887d6a1efab3a06f44cbd README.dev
 SHA1 968d5fad61bce160b31a9cb1a21dd240b9df930f README.win32
 SHA1 5ff93c2ee0668aeda441a52d5c7c2ecdacb29570 TODO
-SHA1 1e43a0e343f5e3c9455546d1de7da5dfd3a6f65b dbdimp.c
+SHA1 6a337ff4a1df36ce10f882cc20e1713001ba0ca7 dbdimp.c
 SHA1 e079dca9f560b265daba52e7daee42e1a17184bb dbdimp.h
 SHA1 6c33bcf138e577722283bef02fceb8cbce4d100d dbivport.h
-SHA1 bc0663c8bab6df3cd928bd8acc3e0adf2daa6a05 lib/Bundle/DBD/Pg.pm
+SHA1 63403370eb706c2e037189b0a926a1353891ae9d lib/Bundle/DBD/Pg.pm
 SHA1 76a2c65c065a93775ceadf933a5d38bb25c8afa4 quote.c
 SHA1 0a1fdd0406c5c367a9aba366d1d35cfa8d5272ae quote.h
 SHA1 93aa7e8cae0a361d1e6163dea0281ebff41f3c5f t/00-signature.t
 SHA1 073baf503a601ceeb49516d61bd275f0c1e51563 t/00basic.t
 SHA1 d4680dbe6b7d5bd5d68c2cdffdc7d2c62c895b2d t/01connect.t
 SHA1 ec842e6aaf11d6a55809318d69bd11ce8245092f t/01constants.t
-SHA1 c5a38d01dcb10a5204f9d8f170871b884419a991 t/02attribs.t
+SHA1 806b8b7dfac746f8d4624a61cd0de387baa206ee t/02attribs.t
 SHA1 0d0a07674d2c493601a6807d22c2c8f2bdbbcd91 t/03dbmethod.t
 SHA1 7ce47f4163e23b3f3df589487707257f5158001a t/03smethod.t
 SHA1 910d6c2234d77a74a49cf189b6c799e13bf75280 t/04misc.t
 SHA1 ee7ecab04b202d5cd8816fbb8c2703971161dd53 t/06bytea.t
 SHA1 2aac29d06766d0edbf0848c433c2ff837908e6ea t/07copy.t
 SHA1 1413c886eaf1714db1cf8abfb989dabfd86dee87 t/08async.t
-SHA1 bbd13111ba3619b7b35542e56b56707746321ae4 t/09arrays.t
+SHA1 acfbfcdbbf4f285b068da11c1031d0afc1c365b5 t/09arrays.t
 SHA1 ee401c485a5c6f36844268eac0e95485359790bf t/12placeholders.t
 SHA1 85b5df8ef0c78b1d2d0018d874c62af7ef01a28f t/20savepoints.t
-SHA1 db3e7d1f050075c1f9fa1f4ed68e777b008c25ee t/99_perlcritic.t
+SHA1 4b8d73523c30a0569b769f8374f5c99e9d17ba3b t/99_perlcritic.t
 SHA1 9f94e06ec6b6a27512f1f4c638635e4095ae6be7 t/99_pod.t
-SHA1 dca708d4390f1662f67b604ff7a3bc6bc15aae88 t/99_spellcheck.t
+SHA1 8910669c9217011efc9a91b4cd5da0f6e7537cc2 t/99_spellcheck.t
 SHA1 540fb0b335d5af08fcc322f18c4166671b50a89b t/99_yaml.t
 SHA1 60031c2db489d77291078ab6a418723e1a35f137 t/99cleanup.t
 SHA1 978844798c01484e029b0ae8ee377c18b0602fd0 t/dbdpg_test_setup.pl
@@ -65,7 +65,7 @@
 SHA1 f07cd5ecaeb854c81ceb9206364979cf607e6546 win32.mak
 -----BEGIN PGP SIGNATURE-----
 
-iEYEAREDAAYFAkiWCjAACgkQvJuQZxSWSsg36ACghOA3o+xifgbB1j5Mwk2XlD+W
-EYUAnisrnG1HLUD7zdkg57uCtNnypSQ8
-=ikkJ
+iEYEAREDAAYFAkipf4sACgkQvJuQZxSWSsgAWgCeIAV+hmQ0x4eX9NGBzitA13XO
+Z7cAoNGyvPYASa0McGItzFi/0PMWRErj
+=0q6E
 -----END PGP SIGNATURE-----

Modified: branches/upstream/libdbd-pg-perl/current/dbdimp.c
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/dbdimp.c?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/dbdimp.c (original)
+++ branches/upstream/libdbd-pg-perl/current/dbdimp.c Sat Aug 23 17:02:08 2008
@@ -1,6 +1,6 @@
 /*
 
-  $Id: dbdimp.c 11596 2008-07-27 03:01:22Z turnstep $
+  $Id: dbdimp.c 11661 2008-08-18 13:42:05Z turnstep $
 
   Copyright (c) 2002-2008 Greg Sabino Mullane and others: see the Changes file
   Portions Copyright (c) 2002 Jeffrey W. Baker
@@ -2471,6 +2471,7 @@
 	char*  string;
 	STRLEN section_size = 0;
 	bool   in_quote = 0;
+	bool   seen_quotes = 0;
 	int    opening_braces = 0;
 	int    closing_braces = 0;
 
@@ -2522,7 +2523,7 @@
 		else if ('}' == *input) {
 		}
 		else if ('"' == *input) {
-			in_quote = (bool)1;
+			in_quote = seen_quotes = (bool)1;
 		}
 		else {
 			string[section_size++] = *input;
@@ -2530,7 +2531,10 @@
 
 		if ('}' == *input || (coltype->array_delimeter == *input && '}' != *(input-1))) {
 			string[section_size] = '\0';
-			if (4 == section_size && 0 == strncmp(string, "NULL", 4) && '"' != *(input-1)) {
+			if (0 == section_size && !seen_quotes) {
+				/* Just an empty array */
+			}
+			else if (4 == section_size && 0 == strncmp(string, "NULL", 4) && '"' != *(input-1)) {
 				av_push(currentav, &PL_sv_undef);
 			}
 			else {

Modified: branches/upstream/libdbd-pg-perl/current/lib/Bundle/DBD/Pg.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/lib/Bundle/DBD/Pg.pm?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/lib/Bundle/DBD/Pg.pm (original)
+++ branches/upstream/libdbd-pg-perl/current/lib/Bundle/DBD/Pg.pm Sat Aug 23 17:02:08 2008
@@ -4,7 +4,7 @@
 use strict;
 use warnings;
 
-$VERSION = '2.9.0';
+$VERSION = '2.9.2';
 
 1;
 

Modified: branches/upstream/libdbd-pg-perl/current/t/02attribs.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/t/02attribs.t?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/t/02attribs.t (original)
+++ branches/upstream/libdbd-pg-perl/current/t/02attribs.t Sat Aug 23 17:02:08 2008
@@ -18,7 +18,7 @@
 if (! defined $dbh) {
 	plan skip_all => 'Connection to database failed, cannot continue testing';
 }
-plan tests => 250;
+plan tests => 245;
 
 isnt ($dbh, undef, 'Connect to database for handle attributes testing');
 
@@ -617,20 +617,24 @@
 $t='Statement handle attribute "NAME" returns empty arrayref for updates';
 is_deeply ($sth->{'NAME'}, [], $t);
 
-$t='Statement handle attribute "NAME_lc" returns empty arrayref for updates';
-is_deeply ($sth->{'NAME_lc'}, [], $t);
-
-$t='Statement handle attribute "NAME_uc" returns empty arrayref for updates';
-is_deeply ($sth->{'NAME_uc'}, [], $t);
-
-$t='Statement handle attribute "NAME_hash" returns empty hashref for updates';
-is_deeply ($sth->{'NAME_hash'}, {}, $t);
-
-$t='Statement handle attribute "NAME_uc_hash" returns empty hashref for updates';
-is_deeply ($sth->{'NAME_lc_hash'}, {}, $t);
-
-$t='Statement handle attribute "NAME_uc_hash" returns empty hashref for updates';
-is_deeply ($sth->{'NAME_uc_hash'}, {}, $t);
+## These cause assertion errors, may be a DBI bug.
+## Commenting out for now until we can examine closer
+## Please see: http://www.nntp.perl.org/group/perl.cpan.testers/2008/08/msg2012293.html
+
+#$t='Statement handle attribute "NAME_lc" returns empty arrayref for updates';
+#is_deeply ($sth->{'NAME_lc'}, [], $t);
+
+#$t='Statement handle attribute "NAME_uc" returns empty arrayref for updates';
+#is_deeply ($sth->{'NAME_uc'}, [], $t);
+
+#$t='Statement handle attribute "NAME_hash" returns empty hashref for updates';
+#is_deeply ($sth->{'NAME_hash'}, {}, $t);
+
+#$t='Statement handle attribute "NAME_uc_hash" returns empty hashref for updates';
+#is_deeply ($sth->{'NAME_lc_hash'}, {}, $t);
+
+#$t='Statement handle attribute "NAME_uc_hash" returns empty hashref for updates';
+#is_deeply ($sth->{'NAME_uc_hash'}, {}, $t);
 
 $t='Statement handle attribute "TYPE" returns empty arrayref for updates';
 is_deeply ($sth->{'TYPE'}, [], $t);

Modified: branches/upstream/libdbd-pg-perl/current/t/09arrays.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/t/09arrays.t?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/t/09arrays.t (original)
+++ branches/upstream/libdbd-pg-perl/current/t/09arrays.t Sat Aug 23 17:02:08 2008
@@ -18,7 +18,7 @@
 if (! defined $dbh) {
 	plan skip_all => 'Connection to database failed, cannot continue testing';
 }
-plan tests => 245;
+plan tests => 242;
 
 isnt ($dbh, undef, 'Connect to database for array testing');
 
@@ -36,15 +36,17 @@
 $SQL = q{INSERT INTO dbd_pg_test(id,pname,testarray) VALUES (99,'Array Testing',?)};
 my $addarray = $dbh->prepare($SQL);
 
+$SQL = q{INSERT INTO dbd_pg_test(id,pname,testarray2) VALUES (99,'Array Testing',?)};
+my $addarray_int = $dbh->prepare($SQL);
+
 $SQL = q{SELECT testarray FROM dbd_pg_test WHERE pname= 'Array Testing'};
 my $getarray = $dbh->prepare($SQL);
 
+$SQL = q{SELECT testarray2 FROM dbd_pg_test WHERE pname= 'Array Testing'};
+my $getarray_int = $dbh->prepare($SQL);
+
 my $array_tests =
-q![]
-{}
-Empty array
-
-['']
+q!['']
 {""}
 Empty array
 
@@ -291,7 +293,29 @@
 
 }
 
+
+## Test of no-item and empty string arrays
+
+$t=q{String array with no items returns empty array};
 $cleararray->execute();
+$addarray->execute('{}');
+$getarray->execute();
+$result = $getarray->fetchall_arrayref();
+is_deeply ($result, [[[]]], $t);
+
+$t=q{String array with empty string returns empty string};
+$cleararray->execute();
+$addarray->execute('{""}');
+$getarray->execute();
+$result = $getarray->fetchall_arrayref();
+is_deeply ($result, [[['']]], $t);
+
+$t=q{Integer array with no items returns empty array};
+$cleararray->execute();
+$addarray_int->execute('{}');
+$getarray_int->execute();
+$result = $getarray_int->fetchall_arrayref();
+is_deeply ($result, [[[]]], $t);
 
 ## Pure string to array conversion testing
 

Modified: branches/upstream/libdbd-pg-perl/current/t/99_perlcritic.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/t/99_perlcritic.t?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/t/99_perlcritic.t (original)
+++ branches/upstream/libdbd-pg-perl/current/t/99_perlcritic.t Sat Aug 23 17:02:08 2008
@@ -52,8 +52,8 @@
 	for my $linenum (sort {$a <=> $b} keys %{$fileslurp{$file}}) {
 		for my $func (sort keys %{$fileslurp{$file}{$linenum}}) {
 			$t=qq{Test::More method "$func" is in standard format inside $file at line $linenum};
-			## Must be at start of line (optional whitepace), a space, a paren, and something interesting
-			like ($fileslurp{$file}{$linenum}{$func}, qr{^\s*$func \(['\S]}, $t);
+			## Must be at start of line (optional whitespace and comment), a space, a paren, and something interesting
+			like ($fileslurp{$file}{$linenum}{$func}, qr{^\s*#?$func \(['\S]}, $t);
 		}
 	}
 }

Modified: branches/upstream/libdbd-pg-perl/current/t/99_spellcheck.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-pg-perl/current/t/99_spellcheck.t?rev=24521&op=diff
==============================================================================
--- branches/upstream/libdbd-pg-perl/current/t/99_spellcheck.t (original)
+++ branches/upstream/libdbd-pg-perl/current/t/99_spellcheck.t Sat Aug 23 17:02:08 2008
@@ -796,6 +796,7 @@
 PARAMS
 encodings
 lc
+msg
 uc
 unicode
 




More information about the Pkg-perl-cvs-commits mailing list