r26547 - in /trunk/libcgi-session-perl: ./ debian/ debian/patches/ lib/CGI/ lib/CGI/Session/ lib/CGI/Session/Driver/ lib/CGI/Session/ID/ lib/CGI/Session/Serialize/ lib/CGI/Session/Test/ t/

ansgar-guest at users.alioth.debian.org ansgar-guest at users.alioth.debian.org
Sun Nov 2 14:40:39 UTC 2008


Author: ansgar-guest
Date: Sun Nov  2 14:40:35 2008
New Revision: 26547

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=26547
Log:
* New upstream release.
* Add myself to Uploaders.
* Convert debian/copyright to current revision of proposed format.
* debian/copyright: List individual contributors as copyright holders for
  the Debian packaging, not the Debian Perl Group.
  The list of contributors was taken from the changelog.
* debian/watch: Use dist-based URL.
* debian/control: Do not start short description with a capital letter

Modified:
    trunk/libcgi-session-perl/Build.PL
    trunk/libcgi-session-perl/Changes
    trunk/libcgi-session-perl/META.yml
    trunk/libcgi-session-perl/Makefile.PL
    trunk/libcgi-session-perl/debian/changelog
    trunk/libcgi-session-perl/debian/control
    trunk/libcgi-session-perl/debian/copyright
    trunk/libcgi-session-perl/debian/patches/fix_name_section_pod.patch
    trunk/libcgi-session-perl/debian/watch
    trunk/libcgi-session-perl/lib/CGI/Session.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Driver.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Driver/DBI.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Driver/db_file.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Driver/file.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Driver/mysql.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Driver/postgresql.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Driver/sqlite.pm
    trunk/libcgi-session-perl/lib/CGI/Session/ErrorHandler.pm
    trunk/libcgi-session-perl/lib/CGI/Session/ID/incr.pm
    trunk/libcgi-session-perl/lib/CGI/Session/ID/static.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Serialize/default.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Serialize/freezethaw.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Serialize/storable.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Test/Default.pm
    trunk/libcgi-session-perl/lib/CGI/Session/Tutorial.pm
    trunk/libcgi-session-perl/t/find.t

Modified: trunk/libcgi-session-perl/Build.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/Build.PL?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/Build.PL (original)
+++ trunk/libcgi-session-perl/Build.PL Sun Nov  2 14:40:35 2008
@@ -135,11 +135,12 @@
 	},
 	requires =>
 	{
+        'CGI'          => 3.26,
 		'Data::Dumper' => 0,
 		'Digest::MD5'  => 0,
 		'Scalar::Util' => 0,
 	},
     no_index => {
-        'package' => 'SimpleObjectClass',
+        'package' => [ 'CGI::Session::Test::SimpleObjectClass'],
     },
 ) -> create_build_script();

Modified: trunk/libcgi-session-perl/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/Changes?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/Changes (original)
+++ trunk/libcgi-session-perl/Changes Sun Nov  2 14:40:35 2008
@@ -1,8 +1,34 @@
 CGI::Session Change Log
 =====================================================================
 
+4.38 - Friday, October 31, 2008
+    * INTERNAL: Rename SimpleObjectClass to CGI::Session::Test::SimpleObjectClass 
+                to avoid namespace ownership issue (Mark Stosberg). 
+    * INTERNAL: We now list CGI.pm 3.26 or greater as a dependency. You are still  
+                welcome to use other query objects, but this version of CGI.pm
+                fixes a bug in the strictness of HTTP expiration times, which
+                Safari in particular is sensitive to. So, if you are using
+                CGI.pm, you should upgrade to at least this version.  RT#34216,
+                thanks to Astar, Michael Hampton, Ron Savage and Mark Stosberg. 
+    * INTERNAL: return explicit values in _set_status and _unset_status 
+                (RT#39201, Mario Domgoergen, Mark Stosberg) 
+
+    * FIX: RT#37877: The storable serializer wasn't properly inheriting the 'errstr'
+           method. This could have resulted an error like:
+           "Can't locate errstr via package "CGI::Session::Serialize::storable"
+           Thanks to Michael Greenish, Mark Stosberg.  
+    * FIX: RT#40405 reported a case where the default serializer would have a problem after the user
+      	   set a parameter's value to undef, in certain circumstances.
+    	   A test file was kindly provided by cowomally[...]nullium.net.
+    	   The fix was spelled out by Matt LeBlanc
+    * FIX: RT#39679 pointed out a simplification in method remove() in CGI::Session::Driver::file.
+      	   By calling _file() instead of duplicating code, we get the benefit of extra error checking.
+      	   Thanx to Sergiy Borodych for noticing this
+    * FIX: Stop using the return value of delete() in t/find.t. This means that when the patch
+	  	   provided in RT#37752 is applied, t/find.t will not start failing
+
 4.37 - Wednesday, October 22, 2008
-    * INTERNAL - Patch Makefile.PL and Build.PL to request that SimpleObjectClass not be indexed. 
+    * INTERNAL: Patch Makefile.PL and Build.PL to request that SimpleObjectClass not be indexed. 
 
 4.36 - Friday, September 12, 2008
     * FIX: The sample code for find() had 2 errors in it:
@@ -381,4 +407,4 @@
     * Bug in POD documentation is fixed (thanks to Graham Barr)
 
 
-$Id: Changes 434 2008-10-23 02:56:38Z markstos $
+$Id: Changes 446 2008-11-01 03:01:15Z ron $

Modified: trunk/libcgi-session-perl/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/META.yml?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/META.yml (original)
+++ trunk/libcgi-session-perl/META.yml Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 ---
 name: CGI-Session
-version: 4.37
+version: 4.38
 author:
   - 'Sherzod Ruzmetov <sherzodr at cpan.org>'
 abstract: Persistent session data in CGI applications
@@ -8,6 +8,7 @@
 resources:
   license: http://opensource.org/licenses/artistic-license.php
 requires:
+  CGI: 3.26
   Data::Dumper: 0
   Digest::MD5: 0
   Scalar::Util: 0
@@ -17,61 +18,62 @@
 provides:
   CGI::Session:
     file: lib/CGI/Session.pm
-    version: 4.37
+    version: 4.38
   CGI::Session::Driver:
     file: lib/CGI/Session/Driver.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Driver::DBI:
     file: lib/CGI/Session/Driver/DBI.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Driver::db_file:
     file: lib/CGI/Session/Driver/db_file.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Driver::file:
     file: lib/CGI/Session/Driver/file.pm
-    version: 4.34
+    version: 4.38
   CGI::Session::Driver::mysql:
     file: lib/CGI/Session/Driver/mysql.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Driver::postgresql:
     file: lib/CGI/Session/Driver/postgresql.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Driver::sqlite:
     file: lib/CGI/Session/Driver/sqlite.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::ErrorHandler:
     file: lib/CGI/Session/ErrorHandler.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::ID::incr:
     file: lib/CGI/Session/ID/incr.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::ID::md5:
     file: lib/CGI/Session/ID/md5.pm
     version: 4.33
   CGI::Session::ID::static:
     file: lib/CGI/Session/ID/static.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Serialize::default:
     file: lib/CGI/Session/Serialize/default.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Serialize::freezethaw:
     file: lib/CGI/Session/Serialize/freezethaw.pm
-    version: 4.2
+    version: 4.38
   CGI::Session::Serialize::storable:
     file: lib/CGI/Session/Serialize/storable.pm
-    version: 4.33
+    version: 4.38
   CGI::Session::Test::Default:
     file: lib/CGI/Session/Test/Default.pm
-    version: 4.33
+    version: 4.38
+  CGI::Session::Test::SimpleObjectClass:
+    file: lib/CGI/Session/Test/Default.pm
   CGI::Session::Tutorial:
     file: lib/CGI/Session/Tutorial.pm
-    version: 4.33
+    version: 4.38
   OverloadedObjectClass:
     file: lib/CGI/Session/Test/Default.pm
-  SimpleObjectClass:
-    file: lib/CGI/Session/Test/Default.pm
 no_index:
-  package: SimpleObjectClass
+  package:
+    - CGI::Session::Test::SimpleObjectClass
 generated_by: Module::Build version 0.2806
 meta-spec:
   url: http://module-build.sourceforge.net/META-spec-v1.2.html

Modified: trunk/libcgi-session-perl/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/Makefile.PL?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/Makefile.PL (original)
+++ trunk/libcgi-session-perl/Makefile.PL Sun Nov  2 14:40:35 2008
@@ -1,4 +1,4 @@
-# $Id: Makefile.PL 433 2008-10-23 02:48:10Z markstos $
+# $Id: Makefile.PL 440 2008-11-01 01:34:54Z markstos $
 
 use strict;
 use Text::Wrap;
@@ -123,6 +123,7 @@
     VERSION_FROM => 'lib/CGI/Session.pm',
     PL_FILES     => {},
     PREREQ_PM    => {
+        'CGI'           => 3.26,
         'Digest::MD5'   => undef,
         'Data::Dumper'  => undef,
         'Test::More'    => undef,
@@ -134,7 +135,7 @@
     EXTRA_META => "
 no_index:
     package:
-    - SimpleObjectClass
+    - CGI::Session::Test::SimpleObjectClass
 ",
 );
 

Modified: trunk/libcgi-session-perl/debian/changelog
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/debian/changelog?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/debian/changelog (original)
+++ trunk/libcgi-session-perl/debian/changelog Sun Nov  2 14:40:35 2008
@@ -1,3 +1,16 @@
+libcgi-session-perl (4.38-1) unstable; urgency=low
+
+  * New upstream release.
+  * Add myself to Uploaders.
+  * Convert debian/copyright to current revision of proposed format.
+  * debian/copyright: List individual contributors as copyright holders for
+    the Debian packaging, not the Debian Perl Group.
+    The list of contributors was taken from the changelog.
+  * debian/watch: Use dist-based URL.
+  * debian/control: Do not start short description with a capital letter
+
+ -- Ansgar Burchardt <ansgar at 43-1.org>  Sun, 02 Nov 2008 15:39:50 +0100
+
 libcgi-session-perl (4.37-1) unstable; urgency=low
 
   * New upstream release

Modified: trunk/libcgi-session-perl/debian/control
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/debian/control?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/debian/control (original)
+++ trunk/libcgi-session-perl/debian/control Sun Nov  2 14:40:35 2008
@@ -7,7 +7,8 @@
 Maintainer: Debian Perl Group <pkg-perl-maintainers at lists.alioth.debian.org>
 Uploaders: Julien Danjou <acid at debian.org>, 
  Rene Mayorga <rmayorga at debian.org.sv>,
- gregor herrmann <gregoa at debian.org>
+ gregor herrmann <gregoa at debian.org>,
+ Ansgar Burchardt <ansgar at 43-1.org>
 Standards-Version: 3.8.0
 Homepage: http://search.cpan.org/dist/CGI-Session/
 Vcs-Svn: svn://svn.debian.org/pkg-perl/trunk/libcgi-session-perl/
@@ -17,7 +18,7 @@
 Architecture: all
 Depends: ${perl:Depends}, ${misc:Depends}
 Recommends: libdbi-perl
-Description: Persistent session data in CGI applications
+Description: persistent session data in CGI applications
  CGI-Session is a Perl5 library that provides an easy, reliable and modular
  session management system across HTTP requests. Persistency is a key feature
  for such applications as shopping carts, login/authentication routines, and

Modified: trunk/libcgi-session-perl/debian/copyright
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/debian/copyright?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/debian/copyright (original)
+++ trunk/libcgi-session-perl/debian/copyright Sun Nov  2 14:40:35 2008
@@ -1,18 +1,18 @@
-This package was debianized by Julien Danjou <acid at debian.org> on
-Wed, 30 Apr 2003 15:50:12 +0200, and is Maintainined by the 
-Debian Perl Group (pkg-perl) 
-
-It was downloaded from: http://www.cpan.org/modules/by-module/CGI/
-
-Upstream Author: Sherzod Ruzmetov <sherzodr at cpan.org>
- Mark Stosberg <markstos at cpan.org>
- Ron Savage <rsavage at cpan.org>
+Format-Specification: http://wiki.debian.org/Proposals/CopyrightFormat?action=recall&rev=228
+Upstream-Name: CGI-Session
+Upstream-Maintainer: Mark Stosberg
+Upstream-Source: http://search.cpan.org/dist/CGI-Session/
 
 Files: *
 Copyright: © 2001-2005 Sherzod Ruzmetov <sherzodr at cpan.org>
 License: GPL-1+ | Artistic
  These modules are free software. They may be used, redistributed
  and/or modified under the same terms as Perl itsel.
+ .
+ Perl is distributed under your choice of the GNU General Public License or
+ the Artistic License.  On Debian GNU/Linux systems, the complete text of the
+ GNU General Public License can be found in `/usr/share/common-licenses/GPL'
+ and the Artistic Licence in `/usr/share/common-licenses/Artistic'.
 
 Files: lib/CGI/Session/ID/static.pm
 Copyright: © 2002 Adam Jacob <adam at sysadminsith.org>
@@ -27,21 +27,11 @@
  same terms as Perl itself
 
 Files: debian/*
-Copyright: © 2008 Debian Perl Group
-                  <pkg-perl-maintainers at lists.alioth.debian.org>
-           © 2003-2008 Julien Danjou <julien at debian.org>
+Copyright:
+ © 2003-2008, Julien Danjou <julien at debian.org>
+ © 2008, Rene Mayorga <rmayorga at debian.org.sv>
+ © 2008, Damyan Ivanov <dmn at debian.org>
+ © 2008, gregor herrmann <gregoa at debian.org>
+ © 2008, Ansgar Burchardt <ansgar at 43-1.org>
 License: GPL-1+ | Artistic
 
-The Perl license is:
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of either:
-
-    a) the GNU General Public License as published by the Free Software
-       Foundation; either version 1, or (at your option) any later
-       version, or
-
-    b) the "Artistic License" which comes with Perl.
-
-On Debian GNU/Linux systems, the complete text of the GNU General Public
-License can be found in `/usr/share/common-licenses/GPL' and the Artistic
-Licence in `/usr/share/common-licenses/Artistic'.

Modified: trunk/libcgi-session-perl/debian/patches/fix_name_section_pod.patch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/debian/patches/fix_name_section_pod.patch?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/debian/patches/fix_name_section_pod.patch (original)
+++ trunk/libcgi-session-perl/debian/patches/fix_name_section_pod.patch Sun Nov  2 14:40:35 2008
@@ -2,7 +2,7 @@
 +++ libcgi-session-perl/lib/CGI/Session/Test/Default.pm
 @@ -13,9 +13,9 @@
  
- $CGI::Session::Test::Default::VERSION = '4.33';
+ $CGI::Session::Test::Default::VERSION = '4.38';
  
 -=head1 CGI::Session::Test::Default
 +=head1 NAME

Modified: trunk/libcgi-session-perl/debian/watch
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/debian/watch?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/debian/watch (original)
+++ trunk/libcgi-session-perl/debian/watch Sun Nov  2 14:40:35 2008
@@ -1,3 +1,3 @@
 version=3
-# http://search.cpan.org/dist/CGI-Session/ doesn't have the current versions
-http://www.cpan.org/modules/by-module/CGI/CGI-Session-([\d\.]+).tar.gz
+http://search.cpan.org/dist/CGI-Session/ .*/CGI-Session-v?(\d[\d_.-]+)\.(?:tar(?:\.gz|\.bz2)?|tgz|zip)$
+

Modified: trunk/libcgi-session-perl/lib/CGI/Session.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session.pm Sun Nov  2 14:40:35 2008
@@ -1,20 +1,21 @@
 package CGI::Session;
 
-# $Id: Session.pm 434 2008-10-23 02:56:38Z markstos $
+# $Id: Session.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 use Carp;
 use CGI::Session::ErrorHandler;
 
 @CGI::Session::ISA      = qw( CGI::Session::ErrorHandler );
-$CGI::Session::VERSION  = '4.37';
+$CGI::Session::VERSION  = '4.38';
 $CGI::Session::NAME     = 'CGISESSID';
 $CGI::Session::IP_MATCH = 0;
 
-sub STATUS_NEW      () { 1 }        # denotes session that's just created
-sub STATUS_MODIFIED () { 2 }        # denotes session that needs synchronization
-sub STATUS_DELETED  () { 4 }        # denotes session that needs deletion
-sub STATUS_EXPIRED  () { 8 }        # denotes session that was expired.
+sub STATUS_UNSET    () { 1 << 0 } # denotes session that's resetted
+sub STATUS_NEW      () { 1 << 1 } # denotes session that's just created
+sub STATUS_MODIFIED () { 1 << 2 } # denotes session that needs synchronization
+sub STATUS_DELETED  () { 1 << 3 } # denotes session that needs deletion
+sub STATUS_EXPIRED  () { 1 << 4 } # denotes session that was expired.
 
 sub import {
     my ($class, @args) = @_;
@@ -195,19 +196,19 @@
 sub _set_status {
     my $self    = shift;
     croak "_set_status(): usage error" unless @_;
-    $self->{_STATUS} |= $_ for @_;
+    $self->{_STATUS} |= $_[0];
 }
 
 
 sub _unset_status {
     my $self = shift;
     croak "_unset_status(): usage error" unless @_;
-    $self->{_STATUS} &= ~$_ for @_;
+    $self->{_STATUS} &= ~$_[0];
 }
 
 
 sub _reset_status {
-    $_[0]->{_STATUS} = 0;
+    $_[0]->{_STATUS} = STATUS_UNSET;
 }
 
 sub _test_status {
@@ -224,11 +225,13 @@
     # return unless defined $self;
 
     return unless $self->id;            # <-- empty session
-    return if !defined($self->{_STATUS}) or $self->{_STATUS} == 0;    # <-- neither new, nor deleted nor modified
+    
+    # neither new, nor deleted nor modified
+    return if !defined($self->{_STATUS}) or $self->{_STATUS} == STATUS_UNSET;
 
     if ( $self->_test_status(STATUS_NEW) && $self->_test_status(STATUS_DELETED) ) {
         $self->{_DATA} = {};
-        return $self->_unset_status(STATUS_NEW, STATUS_DELETED);
+        return $self->_unset_status(STATUS_NEW | STATUS_DELETED);
     }
 
     my $driver      = $self->_driver();
@@ -242,14 +245,14 @@
         return $self->_unset_status(STATUS_DELETED);
     }
 
-    if ( $self->_test_status(STATUS_NEW) || $self->_test_status(STATUS_MODIFIED) ) {
+    if ( $self->_test_status(STATUS_NEW | STATUS_MODIFIED) ) {
         my $datastr = $serializer->freeze( $self->dataref );
         unless ( defined $datastr ) {
             return $self->set_error( "flush(): couldn't freeze data: " . $serializer->errstr );
         }
         defined( $driver->store($self->id, $datastr) ) or
             return $self->set_error( "flush(): couldn't store datastr: " . $driver->errstr);
-        $self->_unset_status(STATUS_NEW, STATUS_MODIFIED);
+        $self->_unset_status(STATUS_NEW | STATUS_MODIFIED);
     }
     return 1;
 }
@@ -452,7 +455,7 @@
     return 1;
 }
 
-# $Id: Session.pm 434 2008-10-23 02:56:38Z markstos $
+# $Id: Session.pm 447 2008-11-01 03:46:08Z markstos $
 
 =pod
 
@@ -734,7 +737,7 @@
         _OBJECTS    => {},          # keeps necessary objects
         _DRIVER_ARGS=> {},          # arguments to be passed to driver
         _CLAIMED_ID => undef,       # id **claimed** by client
-        _STATUS     => 0,           # status of the session object
+        _STATUS     => STATUS_UNSET,# status of the session object
         _QUERY      => undef        # query object
     }, $class;
 
@@ -829,8 +832,8 @@
     # checking for expiration ticker
     if ( $self->{_DATA}->{_SESSION_ETIME} ) {
         if ( ($self->{_DATA}->{_SESSION_ATIME} + $self->{_DATA}->{_SESSION_ETIME}) <= time() ) {
-            $self->_set_status( STATUS_EXPIRED );   # <-- so client can detect expired sessions
-            $self->_set_status( STATUS_DELETED );   # <-- session should be removed from database
+            $self->_set_status( STATUS_EXPIRED |    # <-- so client can detect expired sessions
+                                STATUS_DELETED );   # <-- session should be removed from database
             $self->flush();                         # <-- flush() will do the actual removal!
             return $self;
         }

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Driver.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Driver.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Driver.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Driver.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::Driver;
 
-# $Id: Driver.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: Driver.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 #use diagnostics;
@@ -8,7 +8,7 @@
 use Carp;
 use CGI::Session::ErrorHandler;
 
-$CGI::Session::Driver::VERSION = '4.33';
+$CGI::Session::Driver::VERSION = '4.38';
 @CGI::Session::Driver::ISA     = qw(CGI::Session::ErrorHandler);
 
 sub new {

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Driver/DBI.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Driver/DBI.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Driver/DBI.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Driver/DBI.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::Driver::DBI;
 
-# $Id: DBI.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: DBI.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 
@@ -9,7 +9,7 @@
 use CGI::Session::Driver;
 
 @CGI::Session::Driver::DBI::ISA = ( "CGI::Session::Driver" );
-$CGI::Session::Driver::DBI::VERSION = '4.33';
+$CGI::Session::Driver::DBI::VERSION = '4.38';
 
 
 sub init {

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Driver/db_file.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Driver/db_file.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Driver/db_file.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Driver/db_file.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::Driver::db_file;
 
-# $Id: db_file.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: db_file.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 
@@ -13,7 +13,7 @@
 use vars qw( @ISA $VERSION $FILE_NAME $UMask $NO_FOLLOW );
 
 @ISA         = ( "CGI::Session::Driver" );
-$VERSION     = '4.33';
+$VERSION     = '4.38';
 $FILE_NAME   = "cgisess.db";
 $UMask       = 0660;
 $NO_FOLLOW   = eval { O_NOFOLLOW } || 0;

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Driver/file.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Driver/file.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Driver/file.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Driver/file.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::Driver::file;
 
-# $Id: file.pm 425 2008-07-13 02:38:51Z markstos $
+# $Id: file.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 
@@ -19,7 +19,7 @@
 }
 
 @CGI::Session::Driver::file::ISA        = ( "CGI::Session::Driver" );
-$CGI::Session::Driver::file::VERSION    = '4.34';
+$CGI::Session::Driver::file::VERSION    = '4.38';
 $FileName                               = "cgisess_%s";
 $NoFlock                                = 0;
 $UMask                                  = 0660;
@@ -122,12 +122,9 @@
 
 
 sub remove {
-    my $self = shift;
+    my $self  = shift;
     my ($sid) = @_;
-
-    my $directory = $self->{Directory};
-    my $file      = sprintf( $FileName, $sid );
-    my $path      = File::Spec->catfile($directory, $file);
+    my $path  = $self -> _file($sid);
     unlink($path) or return $self->set_error( "remove(): couldn't unlink '$path': $!" );
     return 1;
 }

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Driver/mysql.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Driver/mysql.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Driver/mysql.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Driver/mysql.pm Sun Nov  2 14:40:35 2008
@@ -1,13 +1,13 @@
 package CGI::Session::Driver::mysql;
 
-# $Id: mysql.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: mysql.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 use Carp;
 use CGI::Session::Driver::DBI;
 
 @CGI::Session::Driver::mysql::ISA       = qw( CGI::Session::Driver::DBI );
-$CGI::Session::Driver::mysql::VERSION   = '4.33';
+$CGI::Session::Driver::mysql::VERSION   = '4.38';
 
 sub _mk_dsnstr {
     my ($class, $dsn) = @_;

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Driver/postgresql.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Driver/postgresql.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Driver/postgresql.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Driver/postgresql.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::Driver::postgresql;
 
-# $Id: postgresql.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: postgresql.pm 447 2008-11-01 03:46:08Z markstos $
 
 # CGI::Session::Driver::postgresql - PostgreSQL driver for CGI::Session
 #
@@ -15,7 +15,7 @@
 use CGI::Session::Driver::DBI;
 use DBD::Pg qw(PG_BYTEA PG_TEXT);
 
-$CGI::Session::Driver::postgresql::VERSION = '4.33';
+$CGI::Session::Driver::postgresql::VERSION = '4.38';
 @CGI::Session::Driver::postgresql::ISA     = qw( CGI::Session::Driver::DBI );
 
 

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Driver/sqlite.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Driver/sqlite.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Driver/sqlite.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Driver/sqlite.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::Driver::sqlite;
 
-# $Id: sqlite.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: sqlite.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 
@@ -9,7 +9,7 @@
 use DBI qw(SQL_BLOB);
 use Fcntl;
 
-$CGI::Session::Driver::sqlite::VERSION    = '4.33';
+$CGI::Session::Driver::sqlite::VERSION    = '4.38';
 
 sub init {
     my $self = shift;

Modified: trunk/libcgi-session-perl/lib/CGI/Session/ErrorHandler.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/ErrorHandler.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/ErrorHandler.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/ErrorHandler.pm Sun Nov  2 14:40:35 2008
@@ -1,9 +1,9 @@
 package CGI::Session::ErrorHandler;
 
-# $Id: ErrorHandler.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: ErrorHandler.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
-$CGI::Session::ErrorHandler::VERSION = '4.33';
+$CGI::Session::ErrorHandler::VERSION = '4.38';
 
 =pod
 
@@ -13,7 +13,7 @@
 
 =head1 SYNOPSIS
 
-    require CGI::Session::ErrorHandler
+    require CGI::Session::ErrorHandler;
     @ISA = qw( CGI::Session::ErrorHandler );
 
     sub some_method {

Modified: trunk/libcgi-session-perl/lib/CGI/Session/ID/incr.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/ID/incr.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/ID/incr.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/ID/incr.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::ID::incr;
 
-# $Id: incr.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: incr.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 use File::Spec;
@@ -8,7 +8,7 @@
 use Fcntl qw( :DEFAULT :flock );
 use CGI::Session::ErrorHandler;
 
-$CGI::Session::ID::incr::VERSION = '4.33';
+$CGI::Session::ID::incr::VERSION = '4.38';
 @CGI::Session::ID::incr::ISA     = qw( CGI::Session::ErrorHandler );
 
 

Modified: trunk/libcgi-session-perl/lib/CGI/Session/ID/static.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/ID/static.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/ID/static.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/ID/static.pm Sun Nov  2 14:40:35 2008
@@ -1,12 +1,12 @@
 package CGI::Session::ID::static;
 
-# $Id: static.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: static.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 use Carp ("croak");
 use CGI::Session::ErrorHandler;
 
-$CGI::Session::ID::static::VERSION = '4.33';
+$CGI::Session::ID::static::VERSION = '4.38';
 @::CGI::Session::ID::static::ISA   = qw( CGI::Session::ErrorHandler );
 
 sub generate_id {

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Serialize/default.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Serialize/default.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Serialize/default.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Serialize/default.pm Sun Nov  2 14:40:35 2008
@@ -1,6 +1,6 @@
 package CGI::Session::Serialize::default;
 
-# $Id: default.pm 420 2008-07-08 01:23:06Z markstos $ 
+# $Id: default.pm 447 2008-11-01 03:46:08Z markstos $ 
 
 use strict;
 use Safe;
@@ -12,7 +12,7 @@
 require overload;
 
 @CGI::Session::Serialize::default::ISA = ( "CGI::Session::ErrorHandler" );
-$CGI::Session::Serialize::default::VERSION = '4.33';
+$CGI::Session::Serialize::default::VERSION = '4.38';
 
 
 sub freeze {
@@ -48,8 +48,12 @@
     my %seen;
     my @filter = __scan(shift);
     local %overloaded;
-    
-    while (defined(my $x = shift @filter)) {
+
+    # We allow the value assigned to a key to be undef.
+    # Hence the defined() test is not in the while().
+
+    while (@filter) {
+		defined(my $x = shift @filter) or next;
         $seen{refaddr $x || ''}++ and next;
           
         my $r = reftype $x or next;

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Serialize/freezethaw.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Serialize/freezethaw.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Serialize/freezethaw.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Serialize/freezethaw.pm Sun Nov  2 14:40:35 2008
@@ -1,12 +1,12 @@
 package CGI::Session::Serialize::freezethaw;
 
-# $Id: freezethaw.pm 351 2006-11-24 14:16:50Z markstos $ 
+# $Id: freezethaw.pm 447 2008-11-01 03:46:08Z markstos $ 
 
 use strict;
 use FreezeThaw;
 use CGI::Session::ErrorHandler;
 
-$CGI::Session::Serialize::freezethaw::VERSION = 4.2;
+$CGI::Session::Serialize::freezethaw::VERSION = 4.38;
 @CGI::Session::Serialize::freezethaw::ISA     = ( "CGI::Session::ErrorHandler" );
 
 sub freeze {

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Serialize/storable.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Serialize/storable.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Serialize/storable.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Serialize/storable.pm Sun Nov  2 14:40:35 2008
@@ -1,13 +1,13 @@
 package CGI::Session::Serialize::storable;
 
-# $Id: storable.pm 420 2008-07-08 01:23:06Z markstos $
+# $Id: storable.pm 447 2008-11-01 03:46:08Z markstos $
 
 use strict;
 use Storable;
 require CGI::Session::ErrorHandler;
 
-$CGI::Session::Serialize::storable::VERSION = '4.33';
- at CGI::Session::Serialize::ISA               = ( "CGI::Session::ErrorHandler" );
+$CGI::Session::Serialize::storable::VERSION = '4.38';
+ at CGI::Session::Serialize::storable::ISA               = ( "CGI::Session::ErrorHandler" );
 
 =pod
 

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Test/Default.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Test/Default.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Test/Default.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Test/Default.pm Sun Nov  2 14:40:35 2008
@@ -11,7 +11,7 @@
 sub ok_later (&;$);
     
 
-$CGI::Session::Test::Default::VERSION = '4.33';
+$CGI::Session::Test::Default::VERSION = '4.38';
 
 =head1 CGI::Session::Test::Default
 
@@ -258,8 +258,8 @@
 
         #
         # creating a simple object to be stored into session
-        my $simple_class = SimpleObjectClass->new();
-        ok($simple_class, "SimpleObjectClass created successfully");
+        my $simple_class = CGI::Session::Test::SimpleObjectClass->new();
+        ok($simple_class, "CGI::Session::Test::SimpleObjectClass created successfully");
 
         $simple_class->name("Sherzod Ruzmetov");
         $simple_class->emails(0, 'sherzodr at handalak.com');
@@ -282,8 +282,8 @@
         
         ok($session->param("overloaded_object") eq "ABCDEFG");
         
-        my $simple_class2 = SimpleObjectClass->new();
-        ok($simple_class2, "SimpleObjectClass created successfully");
+        my $simple_class2 = CGI::Session::Test::SimpleObjectClass->new();
+        ok($simple_class2, "CGI::Session::Test::SimpleObjectClass created successfully");
 
         $simple_class2->name("Sherzod Ruzmetov");
         $simple_class2->emails(0, 'sherzodr at handalak.com');
@@ -314,7 +314,7 @@
 
 
         my $simple_object = $session->param("simple_object");
-        ok(ref $simple_object eq "SimpleObjectClass", "SimpleObjectClass loaded successfully");
+        ok(ref $simple_object eq "CGI::Session::Test::SimpleObjectClass", "CGI::Session::Test::SimpleObjectClass loaded successfully");
 
         my $dsn = CGI::Session->parse_dsn($self->{dsn});
         ok_later { $simple_object->name eq "Sherzod Ruzmetov" };
@@ -328,7 +328,7 @@
         ok(!defined($session->param("embedded_simple_and_overloaded")->[0]),"First element of anonymous array undef");
         
         my $simple_object2 = $session->param("embedded_simple_and_overloaded")->[1];
-        ok(ref $simple_object2 eq "SimpleObjectClass", "SimpleObjectClass loaded successfully");
+        ok(ref $simple_object2 eq "CGI::Session::Test::SimpleObjectClass", "CGI::Session::Test::SimpleObjectClass loaded successfully");
 
         ok_later { $simple_object2->name eq "Sherzod Ruzmetov" };
         ok_later { $simple_object2->emails(1) eq 'sherzodr at cpan.org' };
@@ -386,7 +386,7 @@
 sub DESTROY { 1; }
 
 
-package SimpleObjectClass;
+package CGI::Session::Test::SimpleObjectClass;
 use strict;
 use Class::Struct;
 

Modified: trunk/libcgi-session-perl/lib/CGI/Session/Tutorial.pm
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/lib/CGI/Session/Tutorial.pm?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/lib/CGI/Session/Tutorial.pm (original)
+++ trunk/libcgi-session-perl/lib/CGI/Session/Tutorial.pm Sun Nov  2 14:40:35 2008
@@ -1,8 +1,8 @@
 package CGI::Session::Tutorial;
 
-# $Id: Tutorial.pm 420 2008-07-08 01:23:06Z markstos $
-
-$CGI::Session::Tutorial::VERSION = '4.33';
+# $Id: Tutorial.pm 447 2008-11-01 03:46:08Z markstos $
+
+$CGI::Session::Tutorial::VERSION = '4.38';
 
 =pod
 

Modified: trunk/libcgi-session-perl/t/find.t
URL: http://svn.debian.org/wsvn/pkg-perl/trunk/libcgi-session-perl/t/find.t?rev=26547&op=diff
==============================================================================
--- trunk/libcgi-session-perl/t/find.t (original)
+++ trunk/libcgi-session-perl/t/find.t Sun Nov  2 14:40:35 2008
@@ -16,7 +16,7 @@
 
     if (CGI::Session->can('find') )
     {
-        plan tests => 8;
+        plan tests => 7;
 
         # Remove any other test sessions, so sub find is called once,
         # which means the test count above is correct, since every extra
@@ -58,7 +58,9 @@
     isa_ok($session, 'CGI::Session', 'CGI::Session::find() found a session whose class');
     ok($session->param('purpose'), "The found session's param called 'purpose' has a true value");
     is($original_purpose, $session->param('purpose'), "The found session's param called 'purpose' has the expected value");
-    ok(! $session->delete(), 'The found session has been deleted');
+    $session->delete();
+    $session->flush();
+    diag 'The found session has been deleted and flushed';
 
 }   
 




More information about the Pkg-perl-cvs-commits mailing list