r32729 - in /branches/upstream/libdbd-sqlite3-perl/current: ./ inc/ inc/Test/ inc/Test/NoWarnings/ lib/DBD/ t/ t/lib/

eloy at users.alioth.debian.org eloy at users.alioth.debian.org
Tue Apr 7 21:16:13 UTC 2009


Author: eloy
Date: Tue Apr  7 21:16:08 2009
New Revision: 32729

URL: http://svn.debian.org/wsvn/pkg-perl/?sc=1&rev=32729
Log:
[svn-upgrade] Integrating new upstream version, libdbd-sqlite3-perl (1.20)

Added:
    branches/upstream/libdbd-sqlite3-perl/current/inc/
    branches/upstream/libdbd-sqlite3-perl/current/inc/Test/
    branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings/
    branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings.pm
    branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings/Warning.pm
    branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t
Modified:
    branches/upstream/libdbd-sqlite3-perl/current/Changes
    branches/upstream/libdbd-sqlite3-perl/current/MANIFEST
    branches/upstream/libdbd-sqlite3-perl/current/META.yml
    branches/upstream/libdbd-sqlite3-perl/current/Makefile.PL
    branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm
    branches/upstream/libdbd-sqlite3-perl/current/t/12_unicode.t
    branches/upstream/libdbd-sqlite3-perl/current/t/30_auto_rollback.t
    branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm
    branches/upstream/libdbd-sqlite3-perl/current/t/rt_21406_auto_finish.t
    branches/upstream/libdbd-sqlite3-perl/current/t/rt_29058_group_by.t

Modified: branches/upstream/libdbd-sqlite3-perl/current/Changes
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/Changes?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/Changes (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/Changes Tue Apr  7 21:16:08 2009
@@ -1,4 +1,10 @@
 Changes for Perl extension DBD-SQLite.
+
+1.20 to be released
+    - Moving to the first production release of the new era.
+    - Check DBI version in Makefile.PL (CHORNY)
+    - Bundling Test::NoWarings into /inc to remove a dependency (ADAMK)
+    - Correcting use 5.00503 to 5.006 in SQLite.pm (ADAMK)
 
 1.19_10 Mon  6 Apr 2009
     - A few more tests moved to Test::More (ADAMK)

Modified: branches/upstream/libdbd-sqlite3-perl/current/MANIFEST
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/MANIFEST?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/MANIFEST (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/MANIFEST Tue Apr  7 21:16:08 2009
@@ -35,6 +35,8 @@
 hash.c
 hash.h
 hwtime.h
+inc/Test/NoWarnings.pm
+inc/Test/NoWarnings/Warning.pm
 insert.c
 journal.c
 keywordhash.h
@@ -128,6 +130,7 @@
 t/lib/Test.pm
 t/rt_15186_prepcached.t
 t/rt_21406_auto_finish.t
+t/rt_25371_asymmetric_unicode.t
 t/rt_25460_numeric_aggregate.t
 t/rt_27553_prepared_cache_and_analyze.t
 t/rt_29058_group_by.t

Modified: branches/upstream/libdbd-sqlite3-perl/current/META.yml
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/META.yml?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/META.yml (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/META.yml Tue Apr  7 21:16:08 2009
@@ -1,6 +1,6 @@
 --- #YAML:1.0
 name:               DBD-SQLite
-version:            1.19_10
+version:            1.20
 abstract:           Self Contained SQLite RDBMS in a DBI Driver
 author:
     - Adam Kennedy <adamk at cpan.org>
@@ -11,13 +11,13 @@
     ExtUtils::MakeMaker:  6.48
     File::Spec:           0.82
 build_requires:
-    Test::More:        0.42
-    Test::NoWarnings:  0.081
+    File::Spec:  0.82
+    Test::More:  0.42
 requires:
-    DBI:               1.43
-    perl:              5.006
-    Test::More:        0.42
-    Test::NoWarnings:  0.081
+    DBI:         1.57
+    File::Spec:  0.82
+    perl:        5.006
+    Test::More:  0.42
 resources:
     bugtracker:   http://rt.cpan.org/NoAuth/ReportBug.html?Queue=DBD-SQLite
     license:      http://dev.perl.org/licenses/

Modified: branches/upstream/libdbd-sqlite3-perl/current/Makefile.PL
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/Makefile.PL?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/Makefile.PL (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/Makefile.PL Tue Apr  7 21:16:08 2009
@@ -45,6 +45,17 @@
 		}
 	}
 };
+
+# Because DBI generates a postamble at configure-time, we need
+# the required version of DBI very early.
+my $DBI_required = 1.57;
+eval {
+	require DBI;
+};
+if ( $@ or DBI->VERSION < $DBI_required ) {
+	print "DBI 1.57 is required to configure this module, please install it or upgrade your CPAN/CPANPLUS shell\n";
+	exit(0);
+}
 
 # 2005/6/19, by rjray at blackperl.com
 #
@@ -192,9 +203,9 @@
 	ABSTRACT         => 'Self Contained SQLite RDBMS in a DBI Driver',
 	VERSION_FROM     => 'lib/DBD/SQLite.pm',
 	PREREQ_PM        => {
-		'DBI'              => '1.43',
+		'File::Spec'       => (WINLIKE ? '3.27' : '0.82'),
+		'DBI'              => $DBI_required,
 		'Test::More'       => '0.42',
-		'Test::NoWarnings' => '0.081',
 	},
 	OPTIONAL( '6.48',
 		MIN_PERL_VERSION => '5.006',
@@ -203,18 +214,19 @@
 		LICENSE => 'perl',	
 	),
 	OPTIONAL( '6.11',
-		AUTHOR  => 'Adam Kennedy <adamk at cpan.org>', # Maintainer
+		AUTHOR  => 'Adam Kennedy <adamk at cpan.org>', # Release manager (can this be an array?)
 	),
 	OPTIONAL( '6.46',
 		META_MERGE => {
 			configure_requires => {
 				'ExtUtils::MakeMaker' => '6.48',
-				'File::Spec'          => (WINLIKE ? '3.27' : '0.82'),
-				'DBI'                 => '1.57',
+				'File::Spec'          => '0.82', # This is not allowed to be computed
+				'DBI'                 => $DBI_required,
 			},
 			build_requires => {
+				'File::Spec'          => (WINLIKE ? '3.27' : '0.82'),
 				'Test::More'          => '0.42',
-				'Test::NoWarnings'    => '0.081',
+				# 'Test::NoWarnings'    => '0.081', # Bundled in /inc
 			},
 			resources => {
 				license     => 'http://dev.perl.org/licenses/',

Added: branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings.pm?rev=32729&op=file
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings.pm (added)
+++ branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings.pm Tue Apr  7 21:16:08 2009
@@ -1,0 +1,310 @@
+use strict;
+use warnings;
+
+package Test::NoWarnings;
+
+use Test::Builder;
+
+use Test::NoWarnings::Warning;
+
+my $Test = Test::Builder->new;
+my $PID = $$;
+
+use Carp;
+
+use vars qw(
+	$VERSION @EXPORT_OK @ISA $do_end_test
+);
+
+$VERSION = '0.084';
+
+require Exporter;
+ at ISA = qw( Exporter );
+
+ at EXPORT_OK = qw(
+	clear_warnings had_no_warnings warnings
+);
+
+my @warnings;
+
+$SIG{__WARN__} = make_catcher(\@warnings);
+
+$do_end_test = 0;
+
+sub import
+{
+	$do_end_test = 1;
+
+	goto &Exporter::import;
+}
+
+# the END block must be after the "use Test::Builder" to make sure it runs
+# before Test::Builder's end block
+# only run the test if there have been other tests
+END {
+	had_no_warnings() if $do_end_test;
+}
+
+sub make_warning
+{
+	local $SIG{__WARN__};
+
+	my $msg = shift;
+
+	my $warning = Test::NoWarnings::Warning->new;
+
+	$warning->setMessage($msg);
+	$warning->fillTest($Test);
+	$warning->fillTrace(__PACKAGE__);
+
+	$Carp::Internal{__PACKAGE__.""}++;
+	local $Carp::CarpLevel = $Carp::CarpLevel + 1;
+	$warning->fillCarp($msg);
+	$Carp::Internal{__PACKAGE__.""}--;
+
+	return $warning;
+}
+
+sub make_catcher
+{
+	# this make a subroutine which can be used in $SIG{__WARN__}
+	# it takes one argument, a ref to an array
+	# it will push the details of the warning onto the end of the array.
+
+	my $array = shift;
+
+	return sub {
+		my $msg = shift;
+
+		$Carp::Internal{__PACKAGE__.""}++;
+		push(@$array, make_warning($msg));
+		$Carp::Internal{__PACKAGE__.""}--;
+
+		return $msg;
+	};
+}
+
+sub had_no_warnings
+{
+	return 0 if $$ != $PID;
+
+	local $SIG{__WARN__};
+	my $name = shift || "no warnings";
+
+	my $ok;
+	my $diag;
+	if (@warnings == 0)
+	{
+		$ok = 1;
+	}
+	else
+	{
+		$ok = 0;
+		$diag = "There were ". at warnings." warning(s)\n";
+		$diag .= join("----------\n", map { $_->toString } @warnings);
+	}
+
+	$Test->ok($ok, $name) || $Test->diag($diag);
+
+	return $ok;
+}
+
+sub clear_warnings
+{
+	local $SIG{__WARN__};
+	@warnings = ();
+}
+
+sub warnings
+{
+	local $SIG{__WARN__};
+	return @warnings;
+}
+
+sub builder
+{
+	local $SIG{__WARN__};
+	if (@_)
+	{
+		$Test = shift;
+	}
+	return $Test;
+}
+
+1;
+
+__END__
+
+=head1 NAME
+
+Test::NoWarnings - Make sure you didn't emit any warnings while testing
+
+=head1 SYNOPSIS
+
+For scripts that have no plan
+
+  use Test::NoWarnings;
+
+that's it, you don't need to do anything else
+
+For scripts that look like
+
+  use Test::More tests => x;
+
+change to  
+
+  use Test::More tests => x + 1;
+  use Test::NoWarnings;
+
+=head1 DESCRIPTION
+
+In general, your tests shouldn't produce warnings. This modules causes any
+warnings to be captured and stored. It automatically adds an extra test that
+will run when your script ends to check that there were no warnings. If
+there were any warings, the test will give a "not ok" and diagnostics of
+where, when and what the warning was, including a stack trace of what was
+going on when the it occurred.
+
+If some of your tests B<are supposed to> produce warnings then you should be
+capturing and checking them with L<Test::Warn>, that way L<Test::NoWarnings>
+will not see them and so not complain.
+
+The test is run by an END block in Test::NoWarnings. It will not be run when
+any forked children exit.
+
+=head1 USAGE
+
+Simply by using the module, you automatically get an extra test at the end
+of your script that checks that no warnings were emitted. So just stick
+
+  use Test::NoWarnings
+
+at the top of your script and continue as normal.
+
+If you want more control you can invoke the test manually at any time with
+C<had_no_warnings()>.
+
+The warnings your test has generated so far are stored in an array. You can
+look inside and clear this whenever you want with C<warnings()> and
+C<clear_warnings()>, however, if you are doing this sort of thing then you
+probably want to use L<Test::Warn> in combination with L<Test::NoWarnings>.
+
+=head1 USE vs REQUIRE
+
+You will almost always want to do
+
+  use Test::NoWarnings
+
+If you do a C<require> rather than a C<use>, then there will be no automatic
+test at the end of your script.
+
+=head1 OUTPUT
+
+If warning is captured during your test then the details will output as part
+of the diagnostics. You will get:
+
+=over 2
+
+=item o
+
+the number and name of the test that was executed just before the warning
+(if no test had been executed these will be 0 and '')
+
+=item o
+
+the message passed to C<warn>,
+
+=item o
+
+a full dump of the stack when warn was called, courtesy of the C<Carp>
+module
+
+=back
+
+=head1 EXPORTABLE FUNCTIONS
+
+=head2 had_no_warnings()
+
+This checks that there have been warnings emitted by your test scripts.
+Usually you will not call this explicitly as it is called automatically when
+your script finishes.
+
+=head2 clear_warnings()
+
+This will clear the array of warnings that have been captured. If the array
+is empty then a call to C<had_no_warnings()> will produce a pass result.
+
+=head2 warnings()
+
+This will return the array of warnings captured so far. Each element of this
+array is an object containing information about the warning. The following
+methods are available on these object.
+
+=over 2
+
+=item *
+
+$warn-E<gt>getMessage
+
+Get the message that would been printed by the warning.
+
+=item *
+
+$warn-E<gt>getCarp
+
+Get a stack trace of what was going on when the warning happened, this stack
+trace is just a string generated by the L<Carp> module.
+
+=item *
+
+$warn-E<gt>getTrace
+
+Get a stack trace object generated by the L<Devel::StackTrace> module. This
+will return undef if L<Devel::StackTrace> is not installed.
+
+=item *
+
+$warn-E<gt>getTest
+
+Get the number of the test that executed before the warning was emitted.
+
+=item *
+
+$warn-E<gt>getTestName
+
+Get the name of the test that executed before the warning was emitted.
+
+=back
+
+=head1 PITFALLS
+
+When counting your tests for the plan, don't forget to include the test that
+runs automatically when your script ends.
+
+=head1 BUGS
+
+None that I know of.
+
+=head1 HISTORY
+
+This was previously known as L<Test::Warn::None>
+
+=head1 SEE ALSO
+
+L<Test::Builder>, L<Test::Warn>
+
+=head1 AUTHOR
+
+Written by Fergal Daly <fergal at esatclear.ie>.
+
+=head1 COPYRIGHT
+
+Copyright 2003 by Fergal Daly E<lt>fergal at esatclear.ieE<gt>.
+
+This program is free software and comes with no warranty. It is distributed
+under the LGPL license
+
+See the file F<LGPL> included in this distribution or
+F<http://www.fsf.org/licenses/licenses.html>.
+
+=cut

Added: branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings/Warning.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings/Warning.pm?rev=32729&op=file
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings/Warning.pm (added)
+++ branches/upstream/libdbd-sqlite3-perl/current/inc/Test/NoWarnings/Warning.pm Tue Apr  7 21:16:08 2009
@@ -1,0 +1,106 @@
+use strict;
+
+package Test::NoWarnings::Warning;
+
+use Carp;
+
+my $has_st = eval "require Devel::StackTrace" || 0;
+
+sub new
+{
+	my $pkg = shift;
+
+	my %args = @_;
+
+	my $self = bless \%args, $pkg;
+
+	return $self;
+}
+
+sub getTrace
+{
+	my $self = shift;
+
+	return $self->{Trace};
+}
+
+sub fillTrace
+{
+	my $self = shift;
+	$self->{Trace} = Devel::StackTrace->new(
+		ignore_class => [__PACKAGE__, @_],
+	) if $has_st;
+}
+
+sub getCarp
+{
+	my $self = shift;
+
+	return $self->{Carp};
+}
+
+sub fillCarp
+{
+	my $self = shift;
+
+	my $msg = shift;
+
+	$Carp::Internal{__PACKAGE__.""}++;
+	local $Carp::CarpLevel = $Carp::CarpLevel + 1;
+	$self->{Carp} = Carp::longmess($msg);
+	$Carp::Internal{__PACKAGE__.""}--;
+}
+
+sub getMessage
+{
+	my $self = shift;
+
+	return $self->{Message};
+}
+
+sub setMessage
+{
+	my $self = shift;
+
+	$self->{Message} = shift;
+}
+
+sub fillTest
+{
+	my $self = shift;
+
+	my $builder = shift;
+
+	my $prev_test = $builder->current_test;
+	$self->{Test} = $prev_test;
+
+	my @tests = $builder->details;
+	my $prev_test_name = $prev_test ? $tests[$prev_test - 1]->{name} : "";
+	$self->{TestName} =  $prev_test_name;
+}
+
+sub getTest
+{
+	my $self = shift;
+
+	return $self->{Test};
+}
+
+sub getTestName
+{
+	my $self = shift;
+
+	return $self->{TestName};
+}
+
+sub toString
+{
+	my $self = shift;
+
+	return <<EOM;
+	Previous test $self->{Test} '$self->{TestName}'
+	$self->{Carp}
+EOM
+}
+
+1;

Modified: branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/lib/DBD/SQLite.pm Tue Apr  7 21:16:08 2009
@@ -1,6 +1,6 @@
 package DBD::SQLite;
 
-use 5.00503;
+use 5.006;
 use strict;
 use DBI   1.57 ();
 use DynaLoader ();
@@ -8,7 +8,7 @@
 use vars qw($VERSION @ISA);
 use vars qw{$err $errstr $drh $sqlite_version};
 BEGIN {
-    $VERSION = '1.19_10';
+    $VERSION = '1.20';
     @ISA     = ('DynaLoader');
 
     # Driver singleton
@@ -95,10 +95,6 @@
 
 sub _get_version {
     return( DBD::SQLite::db::FETCH($_[0], 'sqlite_version') );
-}
-
-sub disconnect {
-	$DB::single = 1;
 }
 
 my %info = (

Modified: branches/upstream/libdbd-sqlite3-perl/current/t/12_unicode.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/12_unicode.t?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/12_unicode.t (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/12_unicode.t Tue Apr  7 21:16:08 2009
@@ -9,9 +9,9 @@
 	$^W = 1;
 }
 
+use t::lib::Test;
 use Test::More tests => 16;
 use Test::NoWarnings;
-use t::lib::Test;
 
 #
 #   Include std stuff

Modified: branches/upstream/libdbd-sqlite3-perl/current/t/30_auto_rollback.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/30_auto_rollback.t?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/30_auto_rollback.t (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/30_auto_rollback.t Tue Apr  7 21:16:08 2009
@@ -8,10 +8,9 @@
 	$^W = 1;
 }
 
-my $have_nowarnings;
-BEGIN{ eval 'use Test::NoWarnings; $have_nowarnings = 1;' };
-use Test::More tests => 5+($have_nowarnings || 0);
 use t::lib::Test;
+use Test::More tests => 6;
+use Test::NoWarnings;
 
 SCOPE: {
 	my $dbh = connect_ok( RaiseError => 1, PrintWarn => 0 );

Modified: branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/lib/Test.pm Tue Apr  7 21:16:08 2009
@@ -9,9 +9,12 @@
 
 use vars qw{$VERSION @ISA @EXPORT};
 BEGIN {
-	$VERSION = '1.19_10';
+	$VERSION = '1.20';
 	@ISA     = qw{ Exporter };
 	@EXPORT  = qw{ connect_ok };
+
+	# Allow tests to load modules bundled in /inc
+	unshift @INC, 'inc';
 }
 
 # Always load the DBI module

Modified: branches/upstream/libdbd-sqlite3-perl/current/t/rt_21406_auto_finish.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/rt_21406_auto_finish.t?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/rt_21406_auto_finish.t (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/rt_21406_auto_finish.t Tue Apr  7 21:16:08 2009
@@ -6,11 +6,9 @@
 	$^W = 1;
 }
 
-my $have_nowarnings;
-BEGIN{ eval 'use Test::NoWarnings; $have_nowarnings = 1;' };
-use Test::More tests => 10+($have_nowarnings || 0);
-
 use t::lib::Test;
+use Test::More tests => 11;
+use Test::NoWarnings;
 
 SCOPE: {
 	my $dbh = connect_ok( RaiseError => 1 );

Added: branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t?rev=32729&op=file
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t (added)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/rt_25371_asymmetric_unicode.t Tue Apr  7 21:16:08 2009
@@ -1,0 +1,28 @@
+#!/usr/bin/perl
+
+use strict;
+BEGIN {
+	$|  = 1;
+	$^W = 1;
+}
+
+use t::lib::Test;
+# use Test::More tests => 15;
+use Test::More skip_all => 'Temporarily disabling known-bad test';
+use Test::NoWarnings;
+
+my $dbh = connect_ok();
+$dbh->{unicode} = 1;
+
+ok( $dbh->do(<<'END_SQL'), 'CREATE TABLE' );
+CREATE TABLE foo (
+    bar varchar(255)
+)
+END_SQL
+
+foreach ( "\0", "A", "\xe9", "\x{20ac}" ) {
+    ok( $dbh->do("INSERT INTO foo VALUES ( ? )", {}, $_), 'INSERT' );
+    my $foo = $dbh->selectall_arrayref("SELECT bar FROM foo");
+    is_deeply( $foo, [ [ $_ ] ], 'Value round-tripped ok' );
+    ok( $dbh->do("DELETE FROM foo"), 'DELETE ok' );
+}

Modified: branches/upstream/libdbd-sqlite3-perl/current/t/rt_29058_group_by.t
URL: http://svn.debian.org/wsvn/pkg-perl/branches/upstream/libdbd-sqlite3-perl/current/t/rt_29058_group_by.t?rev=32729&op=diff
==============================================================================
--- branches/upstream/libdbd-sqlite3-perl/current/t/rt_29058_group_by.t (original)
+++ branches/upstream/libdbd-sqlite3-perl/current/t/rt_29058_group_by.t Tue Apr  7 21:16:08 2009
@@ -5,11 +5,9 @@
     $^W = 1;
 }
 
-my $have_nowarnings;
-BEGIN{ eval 'use Test::NoWarnings; $have_nowarnings = 1;' };
-use Test::More tests => 5+($have_nowarnings || 0);
-
 use t::lib::Test;
+use Test::More tests => 6;
+use Test::NoWarnings;
 
 my $dbh = connect_ok();
 $dbh->do('CREATE TABLE foo (bar TEXT, num INT)');




More information about the Pkg-perl-cvs-commits mailing list